Skip to content

Commit abdc5e6

Browse files
committed
refactor to change language to highlight unread notifications
Signed-off-by: Adam Setch <[email protected]>
1 parent 9b333af commit abdc5e6

File tree

3 files changed

+10
-10
lines changed

3 files changed

+10
-10
lines changed

src/renderer/context/App.tsx

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -43,10 +43,10 @@ import {
4343
encryptValue,
4444
setAutoLaunch,
4545
setKeyboardShortcut,
46+
setUseAlternateIdleIcon,
47+
setUseUnreadActiveIcon,
4648
updateTrayIcon,
4749
updateTrayTitle,
48-
useAlternateIdleIcon,
49-
useUnreadActiveIcon,
5050
} from '../utils/comms';
5151
import { getNotificationCount } from '../utils/notifications/notifications';
5252
import { clearState, loadState, saveState } from '../utils/storage';
@@ -162,7 +162,7 @@ export const AppProvider = ({ children }: { children: ReactNode }) => {
162162
useEffect(() => {
163163
const count = getNotificationCount(notifications);
164164

165-
useUnreadActiveIcon(settings.useUnreadActiveIcon);
165+
setUseUnreadActiveIcon(settings.useUnreadActiveIcon);
166166

167167
updateTrayIcon(count);
168168
}, [settings.useUnreadActiveIcon, notifications]);
@@ -172,7 +172,7 @@ export const AppProvider = ({ children }: { children: ReactNode }) => {
172172
}, [settings.openAtStartup]);
173173

174174
useEffect(() => {
175-
useAlternateIdleIcon(settings.useAlternateIdleIcon);
175+
setUseAlternateIdleIcon(settings.useAlternateIdleIcon);
176176
}, [settings.useAlternateIdleIcon]);
177177

178178
useEffect(() => {
@@ -278,8 +278,8 @@ export const AppProvider = ({ children }: { children: ReactNode }) => {
278278
// Restore settings before accounts to ensure filters are available before fetching notifications
279279
if (existing.settings) {
280280
setKeyboardShortcut(existing.settings.keyboardShortcut);
281-
useUnreadActiveIcon(existing.settings.useUnreadActiveIcon);
282-
useAlternateIdleIcon(existing.settings.useAlternateIdleIcon);
281+
setUseUnreadActiveIcon(existing.settings.useUnreadActiveIcon);
282+
setUseAlternateIdleIcon(existing.settings.useAlternateIdleIcon);
283283
setSettings({ ...defaultSettings, ...existing.settings });
284284
window.gitify.zoom.setLevel(
285285
zoomPercentageToLevel(existing.settings.zoomPercentage),

src/renderer/utils/comms.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,10 @@ import {
99
quitApp,
1010
setAutoLaunch,
1111
setKeyboardShortcut,
12+
setUseAlternateIdleIcon,
1213
showWindow,
1314
updateTrayIcon,
1415
updateTrayTitle,
15-
useAlternateIdleIcon,
1616
} from './comms';
1717
import * as storage from './storage';
1818

@@ -123,7 +123,7 @@ describe('renderer/utils/comms.ts', () => {
123123
});
124124

125125
it('sets alternate idle icon', () => {
126-
useAlternateIdleIcon(false);
126+
setUseAlternateIdleIcon(false);
127127

128128
expect(window.gitify.tray.useAlternateIdleIcon).toHaveBeenCalledTimes(1);
129129
expect(window.gitify.tray.useAlternateIdleIcon).toHaveBeenCalledWith(

src/renderer/utils/comms.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,11 +45,11 @@ export function setAutoLaunch(value: boolean): void {
4545
window.gitify.setAutoLaunch(value);
4646
}
4747

48-
export function useAlternateIdleIcon(value: boolean): void {
48+
export function setUseAlternateIdleIcon(value: boolean): void {
4949
window.gitify.tray.useAlternateIdleIcon(value);
5050
}
5151

52-
export function useUnreadActiveIcon(value: boolean): void {
52+
export function setUseUnreadActiveIcon(value: boolean): void {
5353
window.gitify.tray.useUnreadActiveIcon(value);
5454
}
5555

0 commit comments

Comments
 (0)