fix: adjust min volume level (#2033)

* fix: adjust min volume level

Signed-off-by: Adam Setch <[email protected]>

* refactor test suite grouping

Signed-off-by: Adam Setch <[email protected]>

* refactor test suite names

Signed-off-by: Adam Setch <[email protected]>

---------

Signed-off-by: Adam Setch <[email protected]>

Author: setchy

src/renderer/components/settings/SystemSettings.test.tsx

@@ -149,7 +149,7 @@ describe('renderer/components/settings/SystemSettings.tsx', () => {
       expect(screen.getByTestId('settings-volume-group')).not.toBeVisible();
     });
 
-    it('should increase playSound volume', async () => {
+    it('should increase notification volume', async () => {
       render(
         <AppContext.Provider
           value={{
@@ -170,7 +170,7 @@ describe('renderer/components/settings/SystemSettings.tsx', () => {
       expect(updateSetting).toHaveBeenCalledWith('notificationVolume', 30);
     });
 
-    it('should decrease playSound volume', async () => {
+    it('should decrease notification volume', async () => {
       render(
         <AppContext.Provider
           value={{
@@ -191,7 +191,7 @@ describe('renderer/components/settings/SystemSettings.tsx', () => {
       expect(updateSetting).toHaveBeenCalledWith('notificationVolume', 10);
     });
 
-    it('should reset playSound volume', async () => {
+    it('should reset notification volume', async () => {
       render(
         <AppContext.Provider
           value={{

src/renderer/components/settings/SystemSettings.tsx

@@ -106,7 +106,7 @@ export const SystemSettings: FC = () => {
                 onClick={() => {
                   const newVolume = Math.max(
                     settings.notificationVolume - 10,
-                    0,
+                    10,
                   );
                   updateSetting('notificationVolume', newVolume);
                 }}

src/renderer/utils/notifications/native.test.ts

@@ -133,14 +133,8 @@ describe('renderer/utils/notifications/native.ts', () => {
       native.raiseSoundNotification();
       expect(window.Audio.prototype.play).toHaveBeenCalledTimes(1);
     });
-  });
-
-  describe('triggerNativeNotifications', () => {
-    afterEach(() => {
-      jest.clearAllMocks();
-    });
 
-    it('should raise only sound notification with correct volume', () => {
+    it('should play notification sound with correct volume', () => {
       const settings: SettingsState = {
         ...defaultSettings,
         playSound: true,