feat: search notifications

Signed-off-by: Adam Setch <[email protected]>

Author: setchy

src/renderer/components/filters/SearchFilterSuggestions.tsx

@@ -5,8 +5,8 @@ import { Box, Popover, Stack, Text } from '@primer/react';
 import { Opacity } from '../../types';
 import { cn } from '../../utils/cn';
 import {
-  BASE_QUALIFIERS,
-  QUALIFIERS,
+  BASE_SEARCH_QUALIFIERS,
+  ALL_SEARCH_QUALIFIERS,
   SEARCH_DELIMITER,
 } from '../../utils/notifications/filters/search';
 
@@ -28,7 +28,7 @@ export const SearchFilterSuggestions: FC<SearchFilterSuggestionsProps> = ({
   }
 
   const lower = inputValue.toLowerCase();
-  const base = isDetailedNotificationsEnabled ? QUALIFIERS : BASE_QUALIFIERS;
+  const base = isDetailedNotificationsEnabled ? ALL_SEARCH_QUALIFIERS : BASE_SEARCH_QUALIFIERS;
   const suggestions = base.filter(
     (q) => q.prefix.startsWith(lower) || inputValue === '',
   );

src/renderer/utils/notifications/filters/filter.ts

@@ -13,8 +13,8 @@ import {
   subjectTypeFilter,
   userTypeFilter,
   type SearchQualifier,
-  BASE_QUALIFIERS,
-  DETAILED_ONLY_QUALIFIERS,
+  BASE_SEARCH_QUALIFIERS,
+  DETAILED_ONLY_SEARCH_QUALIFIERS,
 } from '.';
 
 
@@ -27,7 +27,7 @@ export function filterBaseNotifications(
     let passesFilters = true;
 
     // Apply base qualifier include/exclude filters (org, repo, etc.)
-    for (const qualifier of BASE_QUALIFIERS) {
+    for (const qualifier of BASE_SEARCH_QUALIFIERS) {
       if (!passesFilters) break;
       passesFilters =
         passesFilters &&
@@ -139,7 +139,7 @@ function passesUserFilters(
   }
 
   // Apply detailed-only qualifier search token filters (e.g. author)
-  for (const qualifier of DETAILED_ONLY_QUALIFIERS) {
+  for (const qualifier of DETAILED_ONLY_SEARCH_QUALIFIERS) {
     if (!passesFilters) break;
     passesFilters =
       passesFilters &&

src/renderer/utils/notifications/filters/search.test.ts

@@ -1,44 +1,40 @@
 import { partialMockNotification } from '../../../__mocks__/partial-mocks';
 import type { Link } from '../../../types';
 import type { Owner } from '../../../typesGitHub';
-import {
-  filterNotificationBySearchTerm,
-  matchQualifierByPrefix,
-  QUALIFIERS,
-} from './search';
+import { filterNotificationBySearchTerm, parseSearchToken, ALL_SEARCH_QUALIFIERS } from './search';
 
 // (helper removed – no longer used)
 
 describe('renderer/utils/notifications/filters/search.ts', () => {
-  describe('matchQualifierByPrefix', () => {
+  describe('parseSearchToken (prefix matching behavior)', () => {
     it('returns null for empty string', () => {
-      expect(matchQualifierByPrefix('')).toBeNull();
+      expect(parseSearchToken('')).toBeNull();
     });
 
     it('returns null when no qualifier prefix matches', () => {
-      expect(matchQualifierByPrefix('unknown:value')).toBeNull();
-      expect(matchQualifierByPrefix('auth:foo')).toBeNull(); // near miss
+      expect(parseSearchToken('unknown:value')).toBeNull();
+      expect(parseSearchToken('auth:foo')).toBeNull(); // near miss
     });
 
     it('matches each known qualifier by its exact prefix and additional value', () => {
-      for (const q of QUALIFIERS) {
+      for (const q of ALL_SEARCH_QUALIFIERS) {
         const token = q.prefix + 'someValue';
-        const qualifier = matchQualifierByPrefix(token);
-        expect(qualifier).not.toBeNull();
-        expect(qualifier).toBe(q);
+        const parsed = parseSearchToken(token);
+        expect(parsed).not.toBeNull();
+        expect(parsed?.qualifier).toBe(q);
       }
     });
 
     it('is case-sensitive (does not match mismatched casing)', () => {
       // Intentionally alter case of prefix characters
-      expect(matchQualifierByPrefix('Author:foo')).toBeNull();
-      expect(matchQualifierByPrefix('ORG:bar')).toBeNull();
-      expect(matchQualifierByPrefix('Repo:baz')).toBeNull();
+      expect(parseSearchToken('Author:foo')).toBeNull();
+      expect(parseSearchToken('ORG:bar')).toBeNull();
+      expect(parseSearchToken('Repo:baz')).toBeNull();
     });
 
     it('does not match when prefix appears later in the token', () => {
-      expect(matchQualifierByPrefix('xauthor:foo')).toBeNull();
-      expect(matchQualifierByPrefix('xxorg:bar')).toBeNull();
+      expect(parseSearchToken('xauthor:foo')).toBeNull();
+      expect(parseSearchToken('xxorg:bar')).toBeNull();
     });
   });
 

src/renderer/utils/notifications/filters/search.ts

@@ -29,37 +29,20 @@ export type SearchQualifierKey = keyof typeof SEARCH_QUALIFIERS;
 export type SearchQualifier = (typeof SEARCH_QUALIFIERS)[SearchQualifierKey];
 export type SearchPrefix = SearchQualifier['prefix'];
 
-export const QUALIFIERS: readonly SearchQualifier[] = Object.values(
+export const ALL_SEARCH_QUALIFIERS: readonly SearchQualifier[] = Object.values(
   SEARCH_QUALIFIERS,
 ) as readonly SearchQualifier[];
 
 
-export const BASE_QUALIFIERS: readonly SearchQualifier[] = QUALIFIERS.filter(
+export const BASE_SEARCH_QUALIFIERS: readonly SearchQualifier[] = ALL_SEARCH_QUALIFIERS.filter(
   (q) => !q.requiresDetailsNotifications,
 );
 
-export const DETAILED_ONLY_QUALIFIERS: readonly SearchQualifier[] = QUALIFIERS.filter(
+export const DETAILED_ONLY_SEARCH_QUALIFIERS: readonly SearchQualifier[] = ALL_SEARCH_QUALIFIERS.filter(
   (q) => q.requiresDetailsNotifications,
 );
 
 
-// Qualifier selection helpers (centralized to avoid duplicating logic in UI components)
-export function getAvailableSearchQualifiers(
-  detailedNotificationsEnabled: boolean,
-): readonly SearchQualifier[] {
-  const all = Object.values(SEARCH_QUALIFIERS) as readonly SearchQualifier[];
-  if (detailedNotificationsEnabled) {
-    return all;
-  }
-
-  return all.filter((q) => !q.requiresDetailsNotifications);
-}
-
-export const BASE_SEARCH_QUALIFIERS: readonly SearchQualifier[] =
-  getAvailableSearchQualifiers(false);
-export const ALL_SEARCH_QUALIFIERS: readonly SearchQualifier[] =
-  getAvailableSearchQualifiers(true);
-
 export function hasIncludeSearchFilters(settings: SettingsState) {
   return settings.filterIncludeSearchTokens.length > 0;
 }
@@ -68,15 +51,6 @@ export function hasExcludeSearchFilters(settings: SettingsState) {
   return settings.filterExcludeSearchTokens.length > 0;
 }
 
-export function matchQualifierByPrefix(token: string) {
-  for (const qualifier of QUALIFIERS) {
-    if (token.startsWith(qualifier.prefix)) {
-      return qualifier;
-    }
-  }
-  return null;
-}
-
 function stripPrefix(token: string, qualifier: SearchQualifier) {
   return token.slice(qualifier.prefix.length).trim();
 }
@@ -88,17 +62,22 @@ export interface ParsedSearchToken {
 }
 
 export function parseSearchToken(token: string): ParsedSearchToken | null {
-  const qualifier = matchQualifierByPrefix(token);
-  if (!qualifier) {
+  if (!token) {
     return null;
   }
 
-  const value = stripPrefix(token, qualifier);
-  if (!value) {
-    return null;
+  for (const qualifier of ALL_SEARCH_QUALIFIERS) {
+    if (token.startsWith(qualifier.prefix)) {
+      const value = stripPrefix(token, qualifier);
+  
+      if (!value) {
+        return null; // prefix only
+      }
+      
+      return { qualifier, value, valueLower: value.toLowerCase() };
+    }
   }
-
-  return { qualifier, value, valueLower: value.toLowerCase() };
+  return null;
 }
 
 // Normalize raw user input from the token text field into a SearchToken (string)
@@ -110,7 +89,7 @@ export function normalizeSearchInputToToken(raw: string): string | null {
   }
 
   const lower = value.toLowerCase();
-  const matchedQualifier = QUALIFIERS.find((q) => lower.startsWith(q.prefix));
+  const matchedQualifier = ALL_SEARCH_QUALIFIERS.find((q) => lower.startsWith(q.prefix));
 
   if (!matchedQualifier) {
     return null;