feat(url): improve fallback url handling

Signed-off-by: Adam Setch <[email protected]>

Author: setchy

src/renderer/utils/api/__mocks__/response-mocks.ts

@@ -418,27 +418,26 @@ export const mockDiscussionLabels: DiscussionLabels = {
   ],
 };
 
+export const mockDiscussion: Discussion = {
+  number: 123,
+  title: '1.16.0',
+  isAnswered: false,
+  stateReason: 'OPEN',
+  url: 'https://github.com/gitify-app/notifications-test/discussions/612' as Link,
+  author: {
+    login: 'discussion-creator',
+    url: 'https://github.com/discussion-creator' as Link,
+    avatar_url: 'https://avatars.githubusercontent.com/u/123456789?v=4' as Link,
+    type: 'User',
+  },
+  comments: mockDiscussionComments,
+  labels: mockDiscussionLabels,
+};
+
 export const mockSearchDiscussionsGraphQLResponse: GraphQLSearch<Discussion> = {
   data: {
     search: {
-      nodes: [
-        {
-          number: 123,
-          title: '1.16.0',
-          isAnswered: false,
-          stateReason: 'OPEN',
-          url: 'https://github.com/gitify-app/notifications-test/discussions/612' as Link,
-          author: {
-            login: 'discussion-creator',
-            url: 'https://github.com/discussion-creator' as Link,
-            avatar_url:
-              'https://avatars.githubusercontent.com/u/123456789?v=4' as Link,
-            type: 'User',
-          },
-          comments: mockDiscussionComments,
-          labels: mockDiscussionLabels,
-        },
-      ],
+      nodes: [mockDiscussion],
     },
   },
 };

src/renderer/utils/api/client.ts

@@ -284,4 +284,6 @@ export async function getLatestDiscussion(
       notification,
     );
   }
+
+  return null;
 }

src/renderer/utils/helpers.test.ts

@@ -8,7 +8,7 @@ import type { Hostname, Link } from '../types';
 import type { SubjectType } from '../typesGitHub';
 import * as logger from '../utils/logger';
 import {
-  mockSearchDiscussionsGraphQLResponse,
+  mockDiscussion,
   mockSingleNotification,
 } from './api/__mocks__/response-mocks';
 import * as apiClient from './api/client';
@@ -283,9 +283,7 @@ describe('renderer/utils/helpers.ts', () => {
           type: 'Discussion' as SubjectType,
         };
 
-        getLatestDiscussionSpy.mockResolvedValue(
-          mockSearchDiscussionsGraphQLResponse[0],
-        );
+        getLatestDiscussionSpy.mockResolvedValue(mockDiscussion);
 
         const result = await generateGitHubWebUrl({
           ...mockSingleNotification,
@@ -475,7 +473,7 @@ describe('renderer/utils/helpers.ts', () => {
           subject: subject,
         });
 
-        expect(getHtmlUrlSpy).toHaveBeenCalledTimes(0);
+        expect(getHtmlUrlSpy).toHaveBeenCalledTimes(1);
         expect(result).toBe(
           `https://github.com/gitify-app/notifications-test/issues?${mockNotificationReferrer}`,
         );