fix: notification read state for delayNotificationState

Signed-off-by: Adam Setch <[email protected]>

Author: setchy

src/renderer/hooks/useNotifications.ts

@@ -23,15 +23,13 @@ import {
 } from '../utils/notifications/notifications';
 import { removeNotifications } from '../utils/notifications/remove';
 
-// Apply optimistic local updates for read state when delayNotificationState is enabled
-function applyLocalOptimisticRead(
-  state: GitifyState,
-  targetNotifications: Notification[],
-) {
-  if (state.settings.delayNotificationState) {
-    for (const n of targetNotifications) {
-      n.unread = false;
-    }
+/**
+ * Apply optimistic local updates for read state.  This helps with some
+ * rendering edge cases between fetch notification intervals.
+ */
+function markNotificationsAsReadLocally(targetNotifications: Notification[]) {
+  for (const n of targetNotifications) {
+    n.unread = false;
   }
 }
 
@@ -137,7 +135,7 @@ export const useNotifications = (): NotificationsState => {
           notifications,
         );
 
-        applyLocalOptimisticRead(state, readNotifications);
+        markNotificationsAsReadLocally(readNotifications);
 
         setNotifications(updatedNotifications);
         setTrayIconColor(updatedNotifications);
@@ -179,7 +177,7 @@ export const useNotifications = (): NotificationsState => {
           notifications,
         );
 
-        applyLocalOptimisticRead(state, doneNotifications);
+        markNotificationsAsReadLocally(doneNotifications);
 
         setNotifications(updatedNotifications);
         setTrayIconColor(updatedNotifications);