feat: axios-cache-interceptor

Signed-off-by: Adam Setch <[email protected]>

Author: setchy

src/renderer/components/Sidebar.tsx

@@ -16,7 +16,6 @@ import { APPLICATION } from '../../shared/constants';
 
 import { Constants } from '../constants';
 import { AppContext } from '../context/App';
-import { clearFullApiCache } from '../utils/api/request';
 import { quitApp } from '../utils/comms';
 import {
   openGitHubIssues,
@@ -64,8 +63,6 @@ export const Sidebar: FC = () => {
   const refreshNotifications = () => {
     navigate('/', { replace: true });
 
-    // Clear client cache so we fetch fresh data when user manually refreshes
-    clearFullApiCache();
     fetchNotifications();
   };
 

src/renderer/constants.ts

@@ -20,8 +20,8 @@ export const Constants = {
 
   ALL_READ_EMOJIS: ['🎉', '🎊', '🥳', '👏', '🙌', '😎', '🏖️', '🚀', '✨', '🏆'],
 
-  DEFAULT_FETCH_NOTIFICATIONS_INTERVAL_MS: 60 * 1000, // 1 minute
-  MIN_FETCH_NOTIFICATIONS_INTERVAL_MS: 60 * 1000, // 1 minute
+  DEFAULT_FETCH_NOTIFICATIONS_INTERVAL_MS: 5 * 1000, // 1 minute
+  MIN_FETCH_NOTIFICATIONS_INTERVAL_MS: 5 * 1000, // 1 minute
   MAX_FETCH_NOTIFICATIONS_INTERVAL_MS: 60 * 60 * 1000, // 1 hour
   FETCH_NOTIFICATIONS_INTERVAL_STEP_MS: 60 * 1000, // 1 minute
 

src/renderer/context/App.tsx

@@ -28,7 +28,6 @@ import type {
 import { FetchType } from '../types';
 import type { Notification } from '../typesGitHub';
 import { headNotifications } from '../utils/api/client';
-import { clearFullApiCache } from '../utils/api/request';
 import type {
   LoginOAuthAppOptions,
   LoginPersonalAccessTokenOptions,
@@ -136,7 +135,6 @@ export const AppProvider = ({ children }: { children: ReactNode }) => {
 
   // biome-ignore lint/correctness/useExhaustiveDependencies: We only want fetchNotifications to be called for particular state changes
   useEffect(() => {
-    clearFullApiCache();
     fetchNotifications({ auth, settings });
   }, [
     auth.accounts,

src/renderer/utils/api/request.ts

@@ -13,25 +13,19 @@ import { getNextURLFromLinkHeader } from './utils';
 
 type AxiosRequestConfigWithAccount = AxiosRequestConfig & { account: Account };
 
-const MUTATION_HTTP_METHODS: Set<Method> = new Set(['PATCH', 'PUT', 'DELETE']);
-
 const instance = Axios.create();
 const axios = setupCache(instance, {
   location: 'client',
 
-  // Respect ETags and cache headers from GitHub API
   interpretHeader: true,
 
-  // Set a reasonable TTL to ensure cache freshness (60 seconds)
-  // This ensures external changes (GitHub web/mobile) are picked up periodically
-  // ttl: 1000 * 60, // 60 seconds
+  methods: ['get'],
 
   cachePredicate: {
-    ignoreUrls: ['/login/oauth/access_token'],
+    ignoreUrls: ['login/oauth/access_token', 'notifications'],
   },
 
-  methods: ['get'],
-
+  // Generate unique cache keys per account to prevent cross-account pollution
   generateKey: buildKeyGenerator((request: AxiosRequestConfigWithAccount) => {
     return {
       method: request.method,
@@ -41,24 +35,6 @@ const axios = setupCache(instance, {
   }),
 });
 
-// Invalidate cache on mutating requests (PATCH, PUT, DELETE)
-// Only clears cache entries for the same account that made the mutation
-axios.interceptors.response.use(
-  async (response) => {
-    const method = response.config.method?.toUpperCase() as Method;
-    const config = response.config as AxiosRequestConfigWithAccount;
-
-    if (MUTATION_HTTP_METHODS.has(method) && config.account) {
-      await clearFullApiCache();
-    }
-    return response;
-  },
-  (error: Error) => {
-    // Pass through errors without clearing cache
-    return Promise.reject(error);
-  },
-);
-
 /**
  * Perform an unauthenticated API request
  *
@@ -145,14 +121,15 @@ export async function apiRequestAuth(
 /**
  * Construct headers for API requests
  *
- * @param username
  * @param token
+ * @param skipCache - If true, adds cache-control: no-cache to force fresh data
  * @returns
  */
 async function getHeaders(token?: Token) {
   const headers: Record<string, string> = {
     Accept: 'application/json',
     'Content-Type': 'application/json',
+    'Cache-Control': 'no-cache',
   };
 
   if (token) {
@@ -163,11 +140,3 @@ async function getHeaders(token?: Token) {
 
   return headers;
 }
-
-export async function clearFullApiCache(): Promise<void> {
-  try {
-    axios.storage.clear();
-  } catch (err) {
-    rendererLogError('clearFullApiCache', 'Failed to clear API cache', err);
-  }
-}