refactor: filter triggers

Signed-off-by: Adam Setch <[email protected]>

Author: setchy

src/renderer/context/App.tsx

@@ -158,10 +158,10 @@ export const AppProvider = ({ children }: { children: ReactNode }) => {
     setNightScheme(colorScheme ?? DEFAULT_NIGHT_COLOR_SCHEME);
   }, [settings.theme, setColorMode, setDayScheme, setNightScheme]);
 
-  // biome-ignore lint/correctness/useExhaustiveDependencies: We only want fetchNotifications to be called for account changes
+  // biome-ignore lint/correctness/useExhaustiveDependencies: We only want fetchNotifications to be called for particular state changes
   useEffect(() => {
     fetchNotifications({ auth, settings });
-  }, [auth.accounts]);
+  }, [auth.accounts, settings.filterReasons, settings.hideBots]);
 
   useInterval(() => {
     fetchNotifications({ auth, settings });

src/renderer/routes/Filters.tsx

@@ -35,7 +35,7 @@ export const FiltersRoute: FC = () => {
     updateSetting('filterReasons', reasons);
   };
 
-  const shouldShowReason = (reason: Reason) => {
+  const isReasonFilterSet = (reason: Reason) => {
     return settings.filterReasons.includes(reason);
   };
 
@@ -86,7 +86,7 @@ export const FiltersRoute: FC = () => {
           <Stack direction="vertical" gap="condensed">
             {Object.keys(FORMATTED_REASONS).map((reason: Reason) => {
               const reasonTitle = formatReason(reason).title;
-              const reasonChecked = shouldShowReason(reason);
+              const isReasonChecked = isReasonFilterSet(reason);
               const reasonDescription = formatReason(reason).description;
               const reasonCount = getReasonFilterCount(notifications, reason);
 
@@ -95,7 +95,7 @@ export const FiltersRoute: FC = () => {
                   key={reason}
                   name={reason}
                   label={reasonTitle}
-                  checked={reasonChecked}
+                  checked={isReasonChecked}
                   onChange={(evt) =>
                     updateReasonFilter(reason, evt.target.checked)
                   }