feat: filter by notification type

Signed-off-by: Adam Setch <[email protected]>

Author: setchy

src/renderer/components/filters/SubjectTypeFilter.tsx

@@ -19,11 +19,11 @@ export const SubjectTypeFilter: FC = () => {
   const { updateFilter, settings, notifications } = useContext(AppContext);
 
   return (
-    <fieldset id="filter-type" className="mb-3">
+    <fieldset id="filter-subject-type" className="mb-3">
       <Stack direction="horizontal" gap="condensed" align="baseline">
         <Title icon={BellIcon}>Type</Title>
         <Tooltip
-          name="tooltip-filter-type"
+          name="tooltip-filter-subject-type"
           tooltip={
             <Stack direction="vertical" gap="condensed">
               <Text>Filter notifications by type.</Text>

src/renderer/types.ts

@@ -163,7 +163,7 @@ export type ErrorType =
 
 export interface TypeDetails {
   title: string;
-  description: string;
+  description?: string;
 }
 
 export enum IconColor {

src/renderer/utils/notifications/filters/state.ts

@@ -25,10 +25,7 @@ export const FILTERS_STATE_TYPES: Record<FilterStateType, TypeDetails> = {
     title: 'Other',
     description: 'Catch all for any other notification states',
   },
-} as Partial<Record<FilterStateType, TypeDetails>> as Record<
-  FilterStateType,
-  TypeDetails
->;
+};
 
 export function getStateDetails(stateType: FilterStateType): TypeDetails {
   return FILTERS_STATE_TYPES[stateType];

src/renderer/utils/notifications/filters/subjectType.ts

@@ -36,10 +36,7 @@ export const FILTERS_SUBJECT_TYPES: Record<SubjectType, TypeDetails> = {
   WorkflowRun: {
     title: 'Workflow Run',
   },
-} as Partial<Record<SubjectType, TypeDetails>> as Record<
-  SubjectType,
-  TypeDetails
->;
+};
 
 export function getSubjectTypeDetails(subjectType: SubjectType): TypeDetails {
   return FILTERS_SUBJECT_TYPES[subjectType];