refactor: remove unused code

Signed-off-by: Adam Setch <[email protected]>

Author: setchy

src/renderer/utils/notifications/handlers/discussion.ts

@@ -49,10 +49,6 @@ class DiscussionHandler extends DefaultHandler {
     const response = await fetchDiscussionByNumber(notification);
     const discussion = response.data.repository?.discussion;
 
-    if (!discussion) {
-      return null;
-    }
-
     let discussionState: GitifyDiscussionState = 'OPEN';
 
     if (discussion.isAnswered) {

src/renderer/utils/notifications/handlers/issue.ts

@@ -30,10 +30,6 @@ class IssueHandler extends DefaultHandler {
     const response = await fetchIssueByNumber(notification);
     const issue = response.data.repository?.issue;
 
-    if (!issue) {
-      return null;
-    }
-
     const issueState = issue.stateReason ?? issue.state;
 
     const issueComment = issue.comments.nodes[0];
@@ -48,7 +44,7 @@ class IssueHandler extends DefaultHandler {
       state: issueState,
       user: issueUser,
       comments: issue.comments.totalCount,
-      labels: issue.labels?.nodes.map((label) => label.name) ?? [],
+      labels: issue.labels?.nodes.map((label) => label.name),
       milestone: issue.milestone,
       htmlUrl: issueComment?.url ?? issue.url,
     };

src/renderer/utils/notifications/handlers/pullRequest.ts

@@ -41,20 +41,18 @@ class PullRequestHandler extends DefaultHandler {
 
     const prUser = getNotificationAuthor([prComment?.author, pr.author]);
 
-    const reviews = pr.reviews
-      ? getLatestReviewForReviewers(pr.reviews.nodes)
-      : null;
+    const reviews = getLatestReviewForReviewers(pr.reviews.nodes);
 
     return {
       number: pr.number,
       state: prState,
       user: prUser,
       reviews: reviews,
       comments: pr.comments.totalCount,
-      labels: pr.labels?.nodes.map((label) => label.name) ?? [],
-      linkedIssues:
-        pr.closingIssuesReferences?.nodes.map((issue) => `#${issue.number}`) ??
-        [],
+      labels: pr.labels?.nodes.map((label) => label.name),
+      linkedIssues: pr.closingIssuesReferences?.nodes.map(
+        (issue) => `#${issue.number}`,
+      ),
       milestone: pr.milestone,
       htmlUrl: prComment?.url ?? pr.url,
     };