Skip to content

Commit f6f60d2

Browse files
committed
feat: search notifications
Signed-off-by: Adam Setch <[email protected]>
1 parent fbf94ca commit f6f60d2

File tree

4 files changed

+13
-13
lines changed

4 files changed

+13
-13
lines changed

src/renderer/components/filters/SearchFilter.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -128,23 +128,23 @@ export const SearchFilter: FC = () => {
128128
<TokenSearchInput
129129
icon={CheckCircleFillIcon}
130130
iconColorClass={IconColor.GREEN}
131+
isDetailedNotificationsEnabled={settings.detailedNotifications}
131132
label="Include"
132133
onAdd={addIncludeSearchToken}
133134
onRemove={removeIncludeSearchToken}
134135
showSuggestionsOnFocusIfEmpty={!hasIncludeSearchFilters(settings)}
135136
tokens={includeSearchTokens}
136-
isDetailedNotificationsEnabled={settings.detailedNotifications}
137137
/>
138138

139139
<TokenSearchInput
140140
icon={NoEntryFillIcon}
141141
iconColorClass={IconColor.RED}
142+
isDetailedNotificationsEnabled={settings.detailedNotifications}
142143
label="Exclude"
143144
onAdd={addExcludeSearchToken}
144145
onRemove={removeExcludeSearchToken}
145146
showSuggestionsOnFocusIfEmpty={!hasExcludeSearchFilters(settings)}
146147
tokens={excludeSearchTokens}
147-
isDetailedNotificationsEnabled={settings.detailedNotifications}
148148
/>
149149
</Stack>
150150
</fieldset>

src/renderer/components/filters/SearchFilterSuggestions.tsx

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@ import { Box, Popover, Stack, Text } from '@primer/react';
55
import { Opacity } from '../../types';
66
import { cn } from '../../utils/cn';
77
import {
8-
SEARCH_DELIMITER,
98
getAvailableSearchQualifiers,
9+
SEARCH_DELIMITER,
1010
} from '../../utils/notifications/filters/search';
1111

1212
interface SearchFilterSuggestionsProps {
@@ -31,9 +31,7 @@ export const SearchFilterSuggestions: FC<SearchFilterSuggestionsProps> = ({
3131
const suggestions = base.filter(
3232
(q) => q.prefix.startsWith(lower) || inputValue === '',
3333
);
34-
const beginsWithKnownQualifier = base.some((q) =>
35-
lower.startsWith(q.prefix),
36-
);
34+
const beginsWithKnownQualifier = base.some((q) => lower.startsWith(q.prefix));
3735

3836
return (
3937
<Popover caret={false} onOpenChange={onClose} open>
@@ -56,9 +54,9 @@ export const SearchFilterSuggestions: FC<SearchFilterSuggestionsProps> = ({
5654
<Box>
5755
<Text className={cn('text-xs', Opacity.HIGH)}>
5856
Please use one of the supported filters [
59-
{base.map((q) =>
60-
q.prefix.replace(SEARCH_DELIMITER, ''),
61-
).join(', ')}
57+
{base
58+
.map((q) => q.prefix.replace(SEARCH_DELIMITER, ''))
59+
.join(', ')}
6260
]
6361
</Text>
6462
</Box>

src/renderer/components/filters/TokenSearchInput.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ interface TokenSearchInputProps {
1919
icon: FC<{ className?: string }>;
2020
iconColorClass: string;
2121
tokens: TokenInputItem[];
22-
showSuggestionsOnFocusIfEmpty: boolean;
22+
showSuggestionsOnFocusIfEmpty: boolean;
2323
isDetailedNotificationsEnabled: boolean;
2424
onAdd: (token: string) => void;
2525
onRemove: (tokenId: string | number) => void;
@@ -111,8 +111,8 @@ export const TokenSearchInput: FC<TokenSearchInputProps> = ({
111111
/>
112112
<SearchFilterSuggestions
113113
inputValue={inputValue}
114-
onClose={() => setShowSuggestions(false)}
115114
isDetailedNotificationsEnabled={isDetailedNotificationsEnabled}
115+
onClose={() => setShowSuggestions(false)}
116116
open={showSuggestions}
117117
/>
118118
</Box>

src/renderer/utils/notifications/filters/search.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,8 +56,10 @@ export function getAvailableSearchQualifiers(
5656
return all.filter((q) => !q.requiresDetailsNotifications);
5757
}
5858

59-
export const BASE_SEARCH_QUALIFIERS: readonly SearchQualifier[] = getAvailableSearchQualifiers(false);
60-
export const ALL_SEARCH_QUALIFIERS: readonly SearchQualifier[] = getAvailableSearchQualifiers(true);
59+
export const BASE_SEARCH_QUALIFIERS: readonly SearchQualifier[] =
60+
getAvailableSearchQualifiers(false);
61+
export const ALL_SEARCH_QUALIFIERS: readonly SearchQualifier[] =
62+
getAvailableSearchQualifiers(true);
6163

6264
export function hasIncludeSearchFilters(settings: SettingsState) {
6365
return settings.filterIncludeSearchTokens.length > 0;

0 commit comments

Comments
 (0)