Skip to content

Commit b4875da

Browse files
Code Suggestions in Gitkraken Desktop
1 parent 6e03dfb commit b4875da

File tree

5 files changed

+19
-4
lines changed

5 files changed

+19
-4
lines changed

_images/gkc-github-pr-view.png

156 KB
Loading

_images/gkc-launchpad-pr-actions.png

93.7 KB
Loading

_images/gkc-pr-code-suggestions.png

47.4 KB
Loading
1.98 MB
Loading

gitkraken-client/pull-requests.md

Lines changed: 19 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -74,9 +74,14 @@ As the name implies, this will create a "draft" pull request in GitHub. However
7474

7575
GitHub.com users may utilize the pull request view for GitHub pull requests.
7676

77-
To enable this feature, first set up the [GitHub integration](/gitkraken-client/github-gitkraken-client/). Then with a GitHub repo open inside of GitKraken Client, select a pull request in the left panel to bring up the pull request view.
77+
To enable this feature, first set up the [GitHub integration](/gitkraken-client/github-gitkraken-client/). Then with a GitHub repo open inside of GitKraken Desktop, select a pull request in the left panel (or checkout the source branch and a PR icon with the number shows up next to the branch) to bring up the pull request view. Or from the Launchpad, click on the icon at the right side of the Pull Request.
7878

79-
<img src='/wp-content/uploads//github-pr-view.png' srcset='/wp-content/uploads//[email protected]' class='img-bordered img-responsive center'>
79+
Repository tab:
80+
<img src='/wp-content/uploads/gkc-github-pr-view.png' class='img-bordered img-responsive center'>
81+
82+
Launchpad:
83+
84+
<img src='/wp-content/uploads/gkc-launchpad-pr-actions.png' class='img-bordered img-responsive center'>
8085

8186
From this view, GitHub users may edit the pull request:
8287

@@ -87,9 +92,19 @@ From this view, GitHub users may edit the pull request:
8792
- Milestones
8893
- Labels
8994

90-
From the upper right of the Pull Request view, you may click the <button class='button button--primary button--ui button--nolink'><span style='color:#141422;'>View file changes</span></button> button to review the affected files for this pull request. Note, code review and code comment are not currently available from within GitKraken Client.
9195

92-
<img src='/wp-content/uploads//view-changes.png' srcset='/wp-content/uploads//[email protected]' class='img-bordered img-responsive center'>
96+
From the upper right of the Pull Request view, you may click the <button class='button button--primary button--ui button--nolink'><span style='color:#141422;'>Review Code and Suggest Changes</span></button> button to review the affected files for this pull request. Note, code review and code comment are not currently available from within GitKraken Desktop.
97+
98+
<img src='/wp-content/uploads/gkc-pr-code-suggestions.png' class='img-bordered img-responsive center'>
99+
100+
101+
### Review Code and Suggest Changes
102+
103+
In Gitkraken Desktop, Review Code and Suggest Changes simplifies code review by allowing you to make suggestions and edits across the entire project, not just on the lines that were changed, GitKraken Desktop, and gitkraken.dev. When a Pull Request is open, you can make suggestions to the pull request that others can then review and accept to include in the pull request.
104+
105+
Open the Pull Request and click on <button class='button button--primary button--ui button--nolink'><span style='color:#141422;'>Edit to Suggest Changes to PR #XX</span></button>, edit the file, save changes and click on <button class='button button--success button--ui button--nolink'>Suggest X file change to PR #XX </button>
106+
107+
<img src='/wp-content/uploads/gkc-pr-suggest-code-changes.png' class='img-bordered img-responsive center'>
93108

94109
### Comment on GitHub pull requests
95110
Users may comment on a pull request -- which is great for submitting reviews, approving pull requests, or requesting changes. You may also use the refresh icon in the top right to quickly refresh the comments feed.

0 commit comments

Comments
 (0)