Connects integrations if they are not connected

(#3621)

Author: sergeibbb

docs/telemetry-events.md

@@ -1320,7 +1320,7 @@ void
   'repository.visibility': 'private' | 'public' | 'local',
   'repoPrivacy': 'private' | 'public' | 'local',
   'filesChanged': number,
-  'source': 'graph' | 'patchDetails' | 'settings' | 'timeline' | 'welcome' | 'home' | 'code-suggest' | 'account' | 'cloud-patches' | 'commandPalette' | 'deeplink' | 'inspect' | 'inspect-overview' | 'integrations' | 'launchpad' | 'launchpad-indicator' | 'launchpad-view' | 'notification' | 'prompt' | 'quick-wizard' | 'remoteProvider' | 'trial-indicator' | 'scm-input' | 'subscription' | 'walkthrough' | 'worktrees'
+  'source': 'graph' | 'patchDetails' | 'settings' | 'timeline' | 'welcome' | 'home' | 'code-suggest' | 'account' | 'cloud-patches' | 'commandPalette' | 'deeplink' | 'inspect' | 'inspect-overview' | 'integrations' | 'launchpad' | 'launchpad-indicator' | 'launchpad-view' | 'notification' | 'prompt' | 'quick-wizard' | 'remoteProvider' | 'startWork' | 'trial-indicator' | 'scm-input' | 'subscription' | 'walkthrough' | 'worktrees'
 }
 ```
 

src/constants.telemetry.ts

@@ -606,6 +606,7 @@ export type Sources =
 	| 'quick-wizard'
 	| 'remoteProvider'
 	| 'settings'
+	| 'startWork'
 	| 'timeline'
 	| 'trial-indicator'
 	| 'scm-input'

src/plus/startWork/startWork.ts

@@ -1,6 +1,7 @@
-import type { QuickInputButton } from 'vscode';
+import type { QuickInputButton, QuickPick } from 'vscode';
 import { ThemeIcon, Uri } from 'vscode';
 import type {
+	AsyncStepResultGenerator,
 	PartialStepState,
 	StepGenerator,
 	StepResultGenerator,
@@ -11,10 +12,12 @@ import {
 	canPickStepContinue,
 	createPickStep,
 	endSteps,
+	freezeStep,
 	QuickCommand,
 	StepResultBreak,
 } from '../../commands/quickCommand';
 import { proBadge } from '../../constants';
+import type { IntegrationId } from '../../constants.integrations';
 import { HostingIntegrationId } from '../../constants.integrations';
 import type { Container } from '../../container';
 import type { SearchedIssue } from '../../git/models/issue';
@@ -23,6 +26,7 @@ import { createQuickPickItemOfT, createQuickPickSeparator } from '../../quickpic
 import type { DirectiveQuickPickItem } from '../../quickpicks/items/directive';
 import { createDirectiveQuickPickItem, Directive } from '../../quickpicks/items/directive';
 import { fromNow } from '../../system/date';
+import { some } from '../../system/iterable';
 
 export type StartWorkItem = {
 	item: SearchedIssue;
@@ -38,6 +42,7 @@ export type StartWorkResult = { items: StartWorkItem[] };
 interface Context {
 	result: StartWorkResult;
 	title: string;
+	connectedIntegrations: Map<IntegrationId, boolean>;
 }
 
 interface State {
@@ -60,6 +65,8 @@ function assertsStartWorkStepState(state: StepState<State>): asserts state is St
 	throw new Error('Missing item');
 }
 
+export const supportedStartWorkIntegrations = [HostingIntegrationId.GitHub];
+
 export class StartWorkCommand extends QuickCommand<State> {
 	constructor(container: Container) {
 		super(container, 'startWork', 'startWork', `Start Work\u00a0\u00a0${proBadge}`, {
@@ -79,11 +86,20 @@ export class StartWorkCommand extends QuickCommand<State> {
 		const context: Context = {
 			result: { items: [] },
 			title: this.title,
+			connectedIntegrations: await this.getConnectedIntegrations(),
 		};
 
 		while (this.canStepsContinue(state)) {
 			context.title = this.title;
 
+			const hasConnectedIntegrations = [...context.connectedIntegrations.values()].some(c => c);
+			if (!hasConnectedIntegrations) {
+				const result = yield* this.confirmCloudIntegrationsConnectStep(state, context);
+				if (result === StepResultBreak) {
+					return result;
+				}
+			}
+
 			await updateContextItems(this.container, context);
 
 			if (state.counter < 1 || state.item == null) {
@@ -115,6 +131,65 @@ export class StartWorkCommand extends QuickCommand<State> {
 		return state.counter < 0 ? StepResultBreak : undefined;
 	}
 
+	private async *confirmCloudIntegrationsConnectStep(
+		state: StepState<State>,
+		context: Context,
+	): AsyncStepResultGenerator<{ connected: boolean | IntegrationId; resume: () => void }> {
+		// TODO: This step is almost an exact copy of the similar one from launchpad.ts. Do we want to do anything about it? Maybe to move it to an util function with ability to parameterize labels?
+		const hasConnectedIntegration = some(context.connectedIntegrations.values(), c => c);
+		const step = this.createConfirmStep(
+			`${this.title} \u00a0\u2022\u00a0 Connect an ${hasConnectedIntegration ? 'Additional ' : ''}Integration`,
+			[
+				createQuickPickItemOfT(
+					{
+						label: `Connect an ${hasConnectedIntegration ? 'Additional ' : ''}Integration...`,
+						detail: hasConnectedIntegration
+							? 'Connect additional integrations to view their issues in Start Work'
+							: 'Connect an integration to accelerate your work',
+						picked: true,
+					},
+					true,
+				),
+			],
+			createDirectiveQuickPickItem(Directive.Cancel, false, { label: 'Cancel' }),
+			{
+				placeholder: hasConnectedIntegration
+					? 'Connect additional integrations to Start Work'
+					: 'Connect an integration to get started with Start Work',
+				buttons: [],
+				ignoreFocusOut: true,
+			},
+		);
+
+		// Note: This is a hack to allow the quickpick to stay alive after the user finishes connecting the integration.
+		// Otherwise it disappears.
+		let freeze!: () => Disposable;
+		let quickpick!: QuickPick<any>;
+		step.onDidActivate = qp => {
+			quickpick = qp;
+			freeze = () => freezeStep(step, qp);
+		};
+
+		const selection: StepSelection<typeof step> = yield step;
+
+		if (canPickStepContinue(step, state, selection)) {
+			const previousPlaceholder = quickpick.placeholder;
+			quickpick.placeholder = 'Connecting integrations...';
+			quickpick.ignoreFocusOut = true;
+			const resume = freeze();
+			const connected = await this.container.integrations.connectCloudIntegrations(
+				{ integrationIds: supportedStartWorkIntegrations },
+				{
+					source: 'startWork',
+				},
+			);
+			quickpick.placeholder = previousPlaceholder;
+			return { connected: connected, resume: () => resume[Symbol.dispose]() };
+		}
+
+		return StepResultBreak;
+	}
+
 	private *pickIssueStep(state: StepState<State>, context: Context): StepResultGenerator<StartWorkItem> {
 		const buildIssueItem = (i: StartWorkItem) => {
 			const buttons = [StartWorkQuickInputButton];
@@ -229,6 +304,18 @@ export class StartWorkCommand extends QuickCommand<State> {
 		const selection: StepSelection<typeof step> = yield step;
 		return canPickStepContinue(step, state, selection) ? selection[0].item : StepResultBreak;
 	}
+
+	private async getConnectedIntegrations(): Promise<Map<IntegrationId, boolean>> {
+		const connected = new Map<IntegrationId, boolean>();
+		await Promise.allSettled(
+			supportedStartWorkIntegrations.map(async integrationId => {
+				const integration = await this.container.integrations.get(integrationId);
+				connected.set(integrationId, integration.maybeConnected ?? (await integration.isConnected()));
+			}),
+		);
+
+		return connected;
+	}
 }
 
 async function updateContextItems(container: Container, context: Context) {