Refactors pull request searching in Launchpad

Separates search in 3 modes: filtering, url search, & search mode
- Introduces dedicated search mode UI with clearer user feedback
- Consolidates GitHub/GitLab PR URL parsing into a single utility
- Reduces UI flicker during searches with optimistic updates

Author: eamodio

src/git/models/pullRequest.ts

@@ -7,10 +7,10 @@ import { formatDate, fromNow } from '../../system/date';
 import { memoize } from '../../system/decorators/memoize';
 import type { LeftRightCommitCountResult } from '../gitProvider';
 import type { IssueOrPullRequest, IssueRepository, IssueOrPullRequestState as PullRequestState } from './issue';
-import type { PullRequestURLIdentity } from './pullRequest.utils';
+import type { PullRequestUrlIdentity } from './pullRequest.utils';
 import type { ProviderReference } from './remoteProvider';
 import type { Repository } from './repository';
-import { createRevisionRange , shortenRevision } from './revision.utils';
+import { createRevisionRange, shortenRevision } from './revision.utils';
 
 export type { PullRequestState };
 
@@ -420,7 +420,7 @@ export async function getOpenedPullRequestRepo(
 
 export function doesPullRequestSatisfyRepositoryURLIdentity(
 	pr: EnrichablePullRequest | undefined,
-	{ ownerAndRepo, prNumber }: PullRequestURLIdentity,
+	{ ownerAndRepo, prNumber }: PullRequestUrlIdentity,
 ): boolean {
 	if (pr == null) {
 		return false;

src/git/models/pullRequest.utils.ts

@@ -2,12 +2,16 @@
 // To avoid this file has been created that can collect more simple functions which
 // don't require Container and can be tested.
 
-export type PullRequestURLIdentity = {
+import type { HostingIntegrationId } from '../../constants.integrations';
+
+export interface PullRequestUrlIdentity {
+	provider?: HostingIntegrationId;
+
 	ownerAndRepo?: string;
 	prNumber?: string;
-};
+}
 
-export function getPullRequestIdentityValuesFromSearch(search: string): PullRequestURLIdentity {
+export function getPullRequestIdentityValuesFromSearch(search: string): PullRequestUrlIdentity {
 	let ownerAndRepo: string | undefined = undefined;
 	let prNumber: string | undefined = undefined;
 

src/plus/integrations/providers/github/models.ts

@@ -1,4 +1,5 @@
 import type { Endpoints } from '@octokit/types';
+import { HostingIntegrationId } from '../../../../constants.integrations';
 import { GitFileIndexStatus } from '../../../../git/models/file';
 import type { IssueLabel } from '../../../../git/models/issue';
 import { Issue, RepositoryAccessLevel } from '../../../../git/models/issue';
@@ -10,6 +11,7 @@ import {
 	PullRequestReviewState,
 	PullRequestStatusCheckRollupState,
 } from '../../../../git/models/pullRequest';
+import type { PullRequestUrlIdentity } from '../../../../git/models/pullRequest.utils';
 import type { Provider } from '../../../../git/models/remoteProvider';
 
 export interface GitHubBlame {
@@ -509,11 +511,19 @@ export function fromCommitFileStatus(
 	return undefined;
 }
 
-export function isGitHubPullRequestUrl(search: string): boolean {
-	try {
-		const url = new URL(search);
-		return url.host === 'github.com' && url.pathname.includes('/pull/');
-	} catch {
-		return false;
-	}
+const prUrlRegex = /^(?:https?:\/\/)?(?:github\.com\/)?([^/]+\/[^/]+)\/pull\/(\d+)/i;
+
+export function isMaybeGitHubPullRequestUrl(url: string): boolean {
+	if (url == null) return false;
+
+	return prUrlRegex.test(url);
+}
+
+export function getGitHubPullRequestIdentityFromMaybeUrl(url: string): RequireSome<PullRequestUrlIdentity, 'provider'> {
+	if (url == null) return { prNumber: undefined, ownerAndRepo: undefined, provider: HostingIntegrationId.GitHub };
+
+	const match = prUrlRegex.exec(url);
+	if (match == null) return { prNumber: undefined, ownerAndRepo: undefined, provider: HostingIntegrationId.GitHub };
+
+	return { prNumber: match[2], ownerAndRepo: match[1], provider: HostingIntegrationId.GitHub };
 }

src/plus/integrations/providers/gitlab/models.ts

@@ -1,5 +1,7 @@
+import { HostingIntegrationId } from '../../../../constants.integrations';
 import type { PullRequestState } from '../../../../git/models/pullRequest';
 import { PullRequest } from '../../../../git/models/pullRequest';
+import type { PullRequestUrlIdentity } from '../../../../git/models/pullRequest.utils';
 import type { Provider } from '../../../../git/models/remoteProvider';
 import type { Integration } from '../../integration';
 import type { ProviderPullRequest } from '../models';
@@ -151,11 +153,17 @@ export function fromGitLabMergeRequestProvidersApi(pr: ProviderPullRequest, prov
 	return fromProviderPullRequest(wrappedPr, provider);
 }
 
-export function isGitLabPullRequestUrl(search: string): boolean {
-	try {
-		const url = new URL(search);
-		return url.host === 'gitlab.com' && url.pathname.includes('/merge_requests/');
-	} catch {
-		return false;
-	}
+const prUrlRegex = /^(?:https?:\/\/)?(?:gitlab\.com\/)?(.+?)\/-\/merge_requests\/(\d+)/i;
+
+export function isMaybeGitLabPullRequestUrl(url: string): boolean {
+	return prUrlRegex.test(url);
+}
+
+export function getGitLabPullRequestIdentityFromMaybeUrl(url: string): RequireSome<PullRequestUrlIdentity, 'provider'> {
+	if (url == null) return { prNumber: undefined, ownerAndRepo: undefined, provider: HostingIntegrationId.GitLab };
+
+	const match = prUrlRegex.exec(url);
+	if (match == null) return { prNumber: undefined, ownerAndRepo: undefined, provider: HostingIntegrationId.GitLab };
+
+	return { prNumber: match[2], ownerAndRepo: match[1], provider: HostingIntegrationId.GitLab };
 }