Allows partially successful results for the Launchpad.

Shows the error on Launchpad anong with PRs.
(#4748, #4492)

Author: sergeibbb

src/plus/integrations/integrationService.ts

@@ -14,6 +14,7 @@ import {
 import type { Source } from '../../constants.telemetry';
 import { detailToContext, sourceToContext } from '../../constants.telemetry';
 import type { Container } from '../../container';
+import { AuthenticationError } from '../../errors';
 import type { Account } from '../../git/models/author';
 import type { IssueShape } from '../../git/models/issue';
 import type { PullRequest } from '../../git/models/pullRequest';
@@ -795,7 +796,7 @@ export class IntegrationService implements Disposable {
 		const successfulResults = [
 			...flatten(
 				filterMap(results, r =>
-					r.status === 'fulfilled' && r.value != null && r.value?.error == null ? r.value.value : undefined,
+					r.status === 'fulfilled' && r.value?.value != null ? r.value.value : undefined,
 				),
 			),
 		];
@@ -804,15 +805,13 @@ export class IntegrationService implements Disposable {
 				r.status === 'fulfilled' && r.value?.error != null ? r.value.error : undefined,
 			),
 		];
-		if (errors.length > 0 && successfulResults.length === 0) {
-			return {
-				error: errors.length === 1 ? errors[0] : new AggregateError(errors),
-				duration: Date.now() - start,
-			};
-		}
+
+		const firstAuthError = errors.find(ex => ex instanceof AuthenticationError);
+		const error = firstAuthError ?? errors[0];
 
 		return {
 			value: successfulResults,
+			error: error,
 			duration: Date.now() - start,
 		};
 	}

src/plus/integrations/models/integration.ts

@@ -46,7 +46,7 @@ export type IntegrationKey<T extends IntegrationIds = IntegrationIds> = T extend
 export type IntegrationConnectedKey<T extends IntegrationIds = IntegrationIds> = `connected:${IntegrationKey<T>}`;
 
 export type IntegrationResult<T> =
-	| { value: T; duration?: number; error?: never }
+	| { value: T; duration?: number; error?: Error }
 	| { error: Error; duration?: number; value?: never }
 	| undefined;
 

src/plus/launchpad/launchpad.ts

@@ -568,7 +568,7 @@ export class LaunchpadCommand extends QuickCommand<State> {
 		function getItemsAndQuickpickProps(isFiltering?: boolean) {
 			const result = context.inSearch ? context.searchResult : context.result;
 
-			if (result?.error != null) {
+			if (result?.error != null && !result?.items?.length) {
 				return {
 					title: `${context.title} \u00a0\u2022\u00a0 Unable to Load Items`,
 					placeholder: `Unable to load items (${
@@ -582,7 +582,7 @@ export class LaunchpadCommand extends QuickCommand<State> {
 				};
 			}
 
-			if (!result?.items.length) {
+			if (!result?.items?.length) {
 				if (context.inSearch === 'mode') {
 					return {
 						title: `Search For Pull Request \u00a0\u2022\u00a0 ${context.title}`,
@@ -616,6 +616,21 @@ export class LaunchpadCommand extends QuickCommand<State> {
 			}
 
 			const items = getLaunchpadQuickPickItems(result.items, isFiltering);
+
+			// Add error information item if there's an error but items were still loaded
+			const errorItem: DirectiveQuickPickItem | undefined =
+				result?.error != null
+					? createDirectiveQuickPickItem(Directive.Noop, false, {
+							label: '$(warning) Unable to fully load items',
+							detail:
+								result.error.name === 'HttpError' &&
+								'status' in result.error &&
+								typeof result.error.status === 'number'
+									? `${result.error.status}: ${String(result.error)}`
+									: String(result.error),
+						})
+					: undefined;
+
 			const hasPicked = items.some(i => i.picked);
 			if (context.inSearch === 'mode') {
 				const offItem: ToggleSearchModeQuickPickItem = {
@@ -630,7 +645,9 @@ export class LaunchpadCommand extends QuickCommand<State> {
 				return {
 					title: `Search For Pull Request \u00a0\u2022\u00a0 ${context.title}`,
 					placeholder: 'Enter a term to search for a pull request to act on',
-					items: isFiltering ? [...items, offItem] : [offItem, ...items],
+					items: isFiltering
+						? [...(errorItem != null ? [errorItem] : []), ...items, offItem]
+						: [offItem, ...(errorItem != null ? [errorItem] : []), ...items],
 				};
 			}
 
@@ -646,8 +663,12 @@ export class LaunchpadCommand extends QuickCommand<State> {
 				title: context.title,
 				placeholder: 'Choose a pull request or paste a pull request URL to act on',
 				items: isFiltering
-					? [...items, onItem]
-					: [onItem, ...getLaunchpadQuickPickItems(result.items, isFiltering)],
+					? [...(errorItem != null ? [errorItem] : []), ...items, onItem]
+					: [
+							onItem,
+							...(errorItem != null ? [errorItem] : []),
+							...getLaunchpadQuickPickItems(result.items, isFiltering),
+						],
 			};
 		}
 
@@ -1657,10 +1678,10 @@ function updateTelemetryContext(context: Context) {
 	if (context.telemetryContext == null) return;
 
 	let updatedContext: NonNullable<(typeof context)['telemetryContext']>;
-	if (context.result.error != null) {
+	if (context.result.error != null || !context.result.items) {
 		updatedContext = {
 			...context.telemetryContext,
-			'items.error': String(context.result.error),
+			'items.error': String(context.result.error ?? 'items not loaded'),
 		};
 	} else {
 		const grouped = countLaunchpadItemGroups(context.result.items);

src/plus/launchpad/launchpadProvider.ts

@@ -149,7 +149,7 @@ export type LaunchpadCategorizedResult =
 	| {
 			items: LaunchpadItem[];
 			timings?: LaunchpadCategorizedTimings;
-			error?: never;
+			error?: Error;
 	  }
 	| {
 			error: Error;
@@ -221,11 +221,6 @@ export class LaunchpadProvider implements Disposable {
 		}
 
 		const prs = getSettledValue(prsResult)?.value;
-		if (prs?.error != null) {
-			Logger.error(prs.error, scope, 'Failed to get pull requests');
-			throw prs.error;
-		}
-
 		const subscription = getSettledValue(subscriptionResult);
 
 		let suggestionCounts;
@@ -252,7 +247,7 @@ export class LaunchpadProvider implements Disposable {
 			search,
 			connectedIntegrations,
 		);
-		const result: { readonly value: PullRequest[]; duration: number } = {
+		const result: { readonly value: PullRequest[]; duration: number; error?: Error } = {
 			value: [],
 			duration: 0,
 		};
@@ -690,7 +685,7 @@ export class LaunchpadProvider implements Disposable {
 				isSearching
 					? typeof options.search === 'string'
 						? this.getSearchedPullRequests(options.search, cancellation)
-						: { prs: { value: options.search, duration: 0 }, suggestionCounts: undefined }
+						: { prs: { value: options.search, duration: 0, error: undefined }, suggestionCounts: undefined }
 					: this.getPullRequestsWithSuggestionCounts({ force: options?.force, cancellation: cancellation }),
 			]);
 
@@ -719,6 +714,7 @@ export class LaunchpadProvider implements Disposable {
 						codeSuggestionCounts: prsWithSuggestionCounts?.suggestionCounts?.duration,
 						enrichedItems: enrichedItems?.duration,
 					},
+					error: prsWithSuggestionCounts?.prs?.error,
 				};
 				return result;
 			}
@@ -848,6 +844,7 @@ export class LaunchpadProvider implements Disposable {
 					codeSuggestionCounts: prsWithSuggestionCounts?.suggestionCounts?.duration,
 					enrichedItems: enrichedItems?.duration,
 				},
+				error: prsWithSuggestionCounts?.prs?.error,
 			};
 			return result;
 		} finally {

src/webviews/home/homeWebview.ts

@@ -1927,13 +1927,13 @@ async function getLaunchpadItemInfo(
 ): Promise<LaunchpadItemInfo> {
 	launchpadPromise ??= container.launchpad.getCategorizedItems();
 	let result = await launchpadPromise;
-	if (result.error != null) return undefined;
+	if (result.error != null || !result.items) return undefined;
 
 	let lpi = result.items.find(i => i.url === pr.url);
 	if (lpi == null) {
 		// result = await container.launchpad.getCategorizedItems({ search: pr.url });
 		result = await container.launchpad.getCategorizedItems({ search: [pr] });
-		if (result.error != null) return undefined;
+		if (result.error != null || !result.items) return undefined;
 
 		lpi = result.items.find(i => i.url === pr.url);
 	}