File tree Expand file tree Collapse file tree 2 files changed +10
-0
lines changed Expand file tree Collapse file tree 2 files changed +10
-0
lines changed Original file line number Diff line number Diff line change @@ -150,6 +150,7 @@ const instanceCounter = getScopedCounter();
150150const defaultCollapsedGroups : LaunchpadGroup [ ] = [ 'draft' , 'other' , 'snoozed' ] ;
151151
152152export class LaunchpadCommand extends QuickCommand < State > {
153+ // TODO: The debouncer needs to be cancelled when the step is changed when the quickpick is closed
153154 private readonly updateItemsDebouncer = createAsyncDebouncer ( 500 ) ;
154155 private readonly source : Source ;
155156 private readonly telemetryContext : LaunchpadTelemetryContext | undefined ;
@@ -588,6 +589,11 @@ export class LaunchpadCommand extends QuickCommand<State> {
588589 return true ;
589590 }
590591
592+ // TODO: This needs to be generalized to work outside of GitHub,
593+ // The current idea is that we should iterate the connected integrations and apply their parsing.
594+ // Probably we even want to build a map like this: { integrationId: identity }
595+ // Then when we iterate local items we can check them to corresponding identitie according to the item's repo type.
596+ // Same with API: we iterate connected integrations and search in each of them with the corresponding identity.
591597 const prUrlIdentity = getPullRequestIdentityValuesFromSearch ( value ) ;
592598 if ( prUrlIdentity . prNumber == null ) {
593599 // Not a valid PR URL
Original file line number Diff line number Diff line change @@ -322,6 +322,10 @@ export class LaunchpadProvider implements Disposable {
322322 }
323323
324324 private async getSearchedPullRequests ( search : string ) {
325+ // TODO: This needs to be generalized to work outside of GitHub,
326+ // The current idea is that we should iterate the connected integrations and apply their parsing.
327+ // Probably we even want to build a map like this: { integrationId: identity }
328+ // Then we iterate connected integrations and search in each of them with the corresponding identity.
325329 const { ownerAndRepo, prNumber } = getPullRequestIdentityValuesFromSearch ( search ) ;
326330 let result : TimedResult < SearchedPullRequest [ ] | undefined > | undefined ;
327331
You can’t perform that action at this time.
0 commit comments