Fixes showing associated branch Linear issues on Home View

(#4543, #4579)

Author: sergeibbb

src/git/models/issue.ts

@@ -37,6 +37,7 @@ export class Issue implements IssueShape {
 		public readonly thumbsUpCount?: number,
 		public readonly body?: string,
 		public readonly project?: IssueProject,
+		public readonly number?: string,
 	) {}
 }
 

src/plus/integrations/providers/linear.ts

@@ -4,12 +4,13 @@ import type { Account } from '../../../git/models/author';
 import type { Issue, IssueShape } from '../../../git/models/issue';
 import type { IssueOrPullRequest, IssueOrPullRequestType } from '../../../git/models/issueOrPullRequest';
 import type { IssueResourceDescriptor, ResourceDescriptor } from '../../../git/models/resourceDescriptor';
+import { isIssueResourceDescriptor } from '../../../git/utils/resourceDescriptor.utils';
 import { Logger } from '../../../system/logger';
 import type { IntegrationAuthenticationProviderDescriptor } from '../authentication/integrationAuthenticationProvider';
 import type { ProviderAuthenticationSession } from '../authentication/models';
 import { IssuesIntegration } from '../models/issuesIntegration';
 import type { IssueFilter } from './models';
-import { providersMetadata, toIssueShape } from './models';
+import { fromProviderIssue, providersMetadata, toIssueShape } from './models';
 
 const metadata = providersMetadata[IssuesCloudHostIntegrationId.Linear];
 const authProvider = Object.freeze({ id: metadata.id, scopes: metadata.scopes });
@@ -110,11 +111,35 @@ export class LinearIntegration extends IssuesIntegration<IssuesCloudHostIntegrat
 	): Promise<IssueOrPullRequest | undefined> {
 		throw new Error('Method not implemented.');
 	}
-	protected override getProviderIssue(
-		_session: ProviderAuthenticationSession,
-		_resource: ResourceDescriptor,
-		_id: string,
+	protected override async getProviderIssue(
+		session: ProviderAuthenticationSession,
+		resource: ResourceDescriptor,
+		id: string,
 	): Promise<Issue | undefined> {
-		throw new Error('Method not implemented.');
+		const api = await this.getProvidersApi();
+		try {
+			if (!isIssueResourceDescriptor(resource)) {
+				Logger.error(undefined, 'getProviderIssue: resource is not an IssueResourceDescriptor');
+				return undefined;
+			}
+
+			const result = await api.getIssue(
+				this.id,
+				{
+					resourceId: resource.id,
+					number: id,
+				},
+				{
+					accessToken: session.accessToken,
+				},
+			);
+
+			if (result == null) return undefined;
+
+			return fromProviderIssue(result, this);
+		} catch (ex) {
+			Logger.error(ex, 'getProviderIssue');
+			return undefined;
+		}
 	}
 }

src/plus/integrations/providers/models.ts

@@ -1055,6 +1055,7 @@ export function fromProviderIssue(
 						resourceName: issue.project.namespace,
 					}
 				: undefined,
+		issue.number,
 	);
 }
 

src/plus/integrations/providers/providersApi.ts

@@ -326,6 +326,7 @@ export class ProvidersApi {
 			[IssuesCloudHostIntegrationId.Linear]: {
 				...providersMetadata[IssuesCloudHostIntegrationId.Linear],
 				provider: providerApis.linear,
+				getIssueFn: providerApis.linear.getIssue.bind(providerApis.linear) as GetIssueFn,
 				getIssuesForCurrentUserFn: providerApis.linear.getIssuesForCurrentUser.bind(providerApis.linear),
 			},
 			[IssuesCloudHostIntegrationId.Trello]: {

src/webviews/apps/plus/home/components/branch-card.ts

@@ -567,7 +567,7 @@ export abstract class GlBranchCardBase extends GlElement {
 							<issue-icon state=${issue.state} issue-id=${issue.id}></issue-icon>
 						</span>
 						<a href=${issue.url} class="branch-item__name branch-item__name--secondary">${issue.title}</a>
-						<span class="branch-item__identifier">#${issue.id}</span>
+						<span class="branch-item__identifier">${isNaN(parseInt(issue.id)) ? '' : '#'}${issue.id}</span>
 					</p>
 				`;
 			})}

src/webviews/home/homeWebview.ts

@@ -1779,7 +1779,12 @@ function enrichOverviewBranchesCore(
 			issues =>
 				issues?.map(
 					i =>
-						({ id: i.id, title: i.title, state: i.state, url: i.url }) satisfies NonNullable<IssuesInfo>[0],
+						({
+							id: i.number || i.id,
+							title: i.title,
+							state: i.state,
+							url: i.url,
+						}) satisfies NonNullable<IssuesInfo>[0],
 				) ?? [],
 		);