Reproduces the "Field 'statusCheckRollup' doesn't exist on type 'PullRequest'" problem

(#3923)

Author: sergeibbb

src/git/remotes/remoteProvider.ts

@@ -20,6 +20,7 @@ export type RemoteProviderId =
 	| 'gerrit'
 	| 'gitea'
 	| 'github'
+	| 'cloud-github-enterprise'
 	| 'gitlab'
 	| 'google-source';
 

src/plus/integrations/integrationService.ts

@@ -451,7 +451,9 @@ export class IntegrationService implements Disposable {
 		return key == null ? this._connectedCache.size !== 0 : this._connectedCache.has(key);
 	}
 
-	get(id: SupportedHostingIntegrationIds): Promise<HostingIntegration>;
+	get(
+		id: SupportedHostingIntegrationIds | SelfHostedIntegrationId.CloudGitHubEnterprise,
+	): Promise<HostingIntegration>;
 	get(id: SupportedIssueIntegrationIds): Promise<IssueIntegration>;
 	get(id: SupportedSelfHostedIntegrationIds, domain: string): Promise<HostingIntegration>;
 	get(id: SupportedIntegrationIds, domain?: string): Promise<Integration>;
@@ -758,8 +760,10 @@ export class IntegrationService implements Disposable {
 	@log<IntegrationService['getMyCurrentAccounts']>({
 		args: { 0: integrationIds => (integrationIds?.length ? integrationIds.join(',') : '<undefined>') },
 	})
-	async getMyCurrentAccounts(integrationIds: HostingIntegrationId[]): Promise<Map<HostingIntegrationId, Account>> {
-		const accounts = new Map<HostingIntegrationId, Account>();
+	async getMyCurrentAccounts(
+		integrationIds: (HostingIntegrationId | SelfHostedIntegrationId.CloudGitHubEnterprise)[],
+	): Promise<Map<HostingIntegrationId | SelfHostedIntegrationId.CloudGitHubEnterprise, Account>> {
+		const accounts = new Map<HostingIntegrationId | SelfHostedIntegrationId.CloudGitHubEnterprise, Account>();
 		await Promise.allSettled(
 			integrationIds.map(async integrationId => {
 				const integration = await this.get(integrationId);
@@ -778,7 +782,7 @@ export class IntegrationService implements Disposable {
 		args: { 0: integrationIds => (integrationIds?.length ? integrationIds.join(',') : '<undefined>'), 1: false },
 	})
 	async getMyPullRequests(
-		integrationIds?: HostingIntegrationId[],
+		integrationIds?: (HostingIntegrationId | SelfHostedIntegrationId.CloudGitHubEnterprise)[],
 		cancellation?: CancellationToken,
 		silent?: boolean,
 	): Promise<IntegrationResult<SearchedPullRequest[] | undefined>> {

src/plus/integrations/providers/github/github.ts

@@ -116,6 +116,7 @@ repository {
 	viewerPermission
 }
 `;
+// Removing statusCheckRollup from this fragment fixes the request, but vanishes the categorized result
 const gqlPullRequestFragment = `
 ${gqlPullRequestLiteFragment}
 additions

src/plus/integrations/providers/utils.ts

@@ -92,6 +92,8 @@ function fromStringToEntityIdentifierProviderType(str: string): EntityIdentifier
 	switch (str) {
 		case 'github':
 			return EntityIdentifierProviderType.Github;
+		case 'cloud-github-enterprise':
+			return EntityIdentifierProviderType.GithubEnterprise;
 		case 'gitlab':
 			return EntityIdentifierProviderType.Gitlab;
 		case 'jira':

src/plus/launchpad/enrichmentService.ts

@@ -217,6 +217,7 @@ const supportedRemoteProvidersToEnrich: Record<RemoteProvider['id'], EnrichedIte
 	gerrit: undefined,
 	gitea: undefined,
 	github: 'github',
+	'cloud-github-enterprise': 'github',
 	gitlab: 'gitlab',
 	'google-source': undefined,
 };

src/plus/launchpad/launchpadProvider.ts

@@ -8,7 +8,7 @@ import { Disposable, env, EventEmitter, Uri, window } from 'vscode';
 import { md5 } from '@env/crypto';
 import { GlCommand } from '../../constants.commands';
 import type { IntegrationId } from '../../constants.integrations';
-import { HostingIntegrationId } from '../../constants.integrations';
+import { HostingIntegrationId, SelfHostedIntegrationId } from '../../constants.integrations';
 import type { Container } from '../../container';
 import { CancellationError } from '../../errors';
 import { openComparisonChanges } from '../../git/actions/commit';
@@ -109,7 +109,8 @@ type PullRequestsWithSuggestionCounts = {
 
 export type LaunchpadRefreshEvent = LaunchpadCategorizedResult;
 
-export const supportedLaunchpadIntegrations = [HostingIntegrationId.GitHub, HostingIntegrationId.GitLab];
+export const supportedLaunchpadIntegrations: (HostingIntegrationId | SelfHostedIntegrationId.CloudGitHubEnterprise)[] =
+	[HostingIntegrationId.GitHub, SelfHostedIntegrationId.CloudGitHubEnterprise, HostingIntegrationId.GitLab];
 type SupportedLaunchpadIntegrationIds = (typeof supportedLaunchpadIntegrations)[number];
 function isSupportedLaunchpadIntegrationId(id: string): id is SupportedLaunchpadIntegrationIds {
 	return supportedLaunchpadIntegrations.includes(id as SupportedLaunchpadIntegrationIds);