Adds search by URL for GitLab Self Managed to the Launchpad

(#3942)

Author: sergeibbb

src/plus/integrations/providers/gitlab.ts

@@ -17,6 +17,7 @@ import type { IntegrationAuthenticationProviderDescriptor } from '../authenticat
 import type { IntegrationAuthenticationService } from '../authentication/integrationAuthenticationService';
 import type { RepositoryDescriptor } from '../integration';
 import { HostingIntegration } from '../integration';
+import type { GitLabRelatedIntegrationIds } from './gitlab/gitlab.utils';
 import { getGitLabPullRequestIdentityFromMaybeUrl } from './gitlab/gitlab.utils';
 import { fromGitLabMergeRequestProvidersApi } from './gitlab/models';
 import type { ProviderRepository } from './models';
@@ -42,12 +43,10 @@ const cloudEnterpriseAuthProvider: IntegrationAuthenticationProviderDescriptor =
 
 export type GitLabRepositoryDescriptor = RepositoryDescriptor;
 
-abstract class GitLabIntegrationBase<
-	ID extends
-		| HostingIntegrationId.GitLab
-		| SelfHostedIntegrationId.GitLabSelfHosted
-		| SelfHostedIntegrationId.CloudGitLabSelfHosted,
-> extends HostingIntegration<ID, GitLabRepositoryDescriptor> {
+abstract class GitLabIntegrationBase<ID extends GitLabRelatedIntegrationIds> extends HostingIntegration<
+	ID,
+	GitLabRepositoryDescriptor
+> {
 	protected abstract get apiBaseUrl(): string;
 
 	protected override async getProviderAccountForCommit(
@@ -409,7 +408,7 @@ abstract class GitLabIntegrationBase<
 	}
 
 	protected override getProviderPullRequestIdentityFromMaybeUrl(search: string): PullRequestUrlIdentity | undefined {
-		return getGitLabPullRequestIdentityFromMaybeUrl(search);
+		return getGitLabPullRequestIdentityFromMaybeUrl(search, this.id);
 	}
 }
 

src/plus/integrations/providers/gitlab/__tests__/gitlab.utils.test.ts

@@ -10,7 +10,7 @@ suite('Test GitLab PR URL parsing to identity: getPullRequestIdentityFromMaybeUr
 				: {
 						ownerAndRepo: ownerAndRepo,
 						prNumber: prNumber,
-						provider: 'gitlab',
+						provider: undefined,
 				  },
 			`Parse: ${message} (${JSON.stringify(query)})`,
 		);

src/plus/integrations/providers/gitlab/gitlab.utils.ts

@@ -2,16 +2,29 @@
 // That's why this file has been created that can collect more simple functions which
 // don't require Container and can be tested.
 
-import { HostingIntegrationId } from '../../../../constants.integrations';
+import type { HostingIntegrationId, SelfHostedIntegrationId } from '../../../../constants.integrations';
 import type { PullRequestUrlIdentity } from '../../../../git/utils/pullRequest.utils';
 
+export type GitLabRelatedIntegrationIds =
+	| HostingIntegrationId.GitLab
+	| SelfHostedIntegrationId.GitLabSelfHosted
+	| SelfHostedIntegrationId.CloudGitLabSelfHosted;
+
 export function isMaybeGitLabPullRequestUrl(url: string): boolean {
 	return getGitLabPullRequestIdentityFromMaybeUrl(url) != null;
 }
 
 export function getGitLabPullRequestIdentityFromMaybeUrl(
 	search: string,
-): (PullRequestUrlIdentity & { provider: HostingIntegrationId.GitLab }) | undefined {
+): (PullRequestUrlIdentity & { provider: undefined }) | undefined;
+export function getGitLabPullRequestIdentityFromMaybeUrl(
+	search: string,
+	id: GitLabRelatedIntegrationIds,
+): (PullRequestUrlIdentity & { provider: GitLabRelatedIntegrationIds }) | undefined;
+export function getGitLabPullRequestIdentityFromMaybeUrl(
+	search: string,
+	id?: GitLabRelatedIntegrationIds,
+): (PullRequestUrlIdentity & { provider: GitLabRelatedIntegrationIds | undefined }) | undefined {
 	let ownerAndRepo: string | undefined = undefined;
 	let prNumber: string | undefined = undefined;
 
@@ -28,7 +41,5 @@ export function getGitLabPullRequestIdentityFromMaybeUrl(
 		}
 	}
 
-	return prNumber != null
-		? { ownerAndRepo: ownerAndRepo, prNumber: prNumber, provider: HostingIntegrationId.GitLab }
-		: undefined;
+	return prNumber != null ? { ownerAndRepo: ownerAndRepo, prNumber: prNumber, provider: id } : undefined;
 }