Skip to content

Commit 2f3f561

Browse files
Fixes deep link failing to cancel at add remote stage
1 parent 2bc90a1 commit 2f3f561

File tree

1 file changed

+9
-1
lines changed

1 file changed

+9
-1
lines changed

src/uris/deepLinks/deepLinkService.ts

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -417,7 +417,7 @@ export class DeepLinkService implements Disposable {
417417
const cancel: QuickPickItem = { label: 'Cancel' };
418418
const result = await window.showQuickPick([add, cancel], {
419419
title: `Locating Remote`,
420-
placeHolder: `Unable to find remote for '${remoteUrl}', would you like to a new remote?`,
420+
placeHolder: `Unable to find remote for '${remoteUrl}', would you like to add a new remote?`,
421421
});
422422
if (result !== add) return undefined;
423423

@@ -885,6 +885,9 @@ export class DeepLinkService implements Disposable {
885885
message = 'Failed to add remote.';
886886
break;
887887
}
888+
} else {
889+
action = DeepLinkServiceAction.DeepLinkCancelled;
890+
break;
888891
}
889892
}
890893

@@ -911,6 +914,9 @@ export class DeepLinkService implements Disposable {
911914
message = 'Failed to add remote.';
912915
break;
913916
}
917+
} else {
918+
action = DeepLinkServiceAction.DeepLinkCancelled;
919+
break;
914920
}
915921
}
916922

@@ -920,9 +926,11 @@ export class DeepLinkService implements Disposable {
920926

921927
if (!remoteName && !secondaryRemoteName) {
922928
action = DeepLinkServiceAction.DeepLinkCancelled;
929+
break;
923930
} else if (!this._context.remote) {
924931
action = DeepLinkServiceAction.DeepLinkErrored;
925932
message = 'Failed to add remote.';
933+
break;
926934
}
927935

928936
action = DeepLinkServiceAction.RemoteAdded;

0 commit comments

Comments
 (0)