Skip to content

Commit 305d406

Browse files
Reverts GitHub to use built-in vscode auth provider
1 parent 76a3849 commit 305d406

File tree

3 files changed

+4
-8
lines changed

3 files changed

+4
-8
lines changed

src/plus/focus/focusIndicator.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -567,7 +567,8 @@ export class FocusIndicator implements Disposable {
567567
const github = await this.container.integrations?.get(HostingIntegrationId.GitHub);
568568
if (github == null) break;
569569
if (!(github.maybeConnected ?? (await github.isConnected()))) {
570-
await this.container.integrations.manageCloudIntegrations(
570+
// TODO: Add back in once we switch GitHub to use the cloud
571+
/* await this.container.integrations.manageCloudIntegrations(
571572
{ integrationId: HostingIntegrationId.GitHub },
572573
{
573574
source: 'launchpad-indicator',
@@ -576,7 +577,7 @@ export class FocusIndicator implements Disposable {
576577
integration: HostingIntegrationId.GitHub,
577578
},
578579
},
579-
);
580+
); */
580581
void github.connect();
581582
}
582583
break;

src/plus/integrations/authentication/integrationAuthentication.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -436,11 +436,6 @@ export class IntegrationAuthenticationService implements Disposable {
436436
await import(/* webpackChunkName: "integrations" */ './bitbucket')
437437
).BitbucketAuthenticationProvider(this.container);
438438
break;
439-
case HostingIntegrationId.GitHub:
440-
provider = new (
441-
await import(/* webpackChunkName: "integrations" */ './github')
442-
).GitHubAuthenticationProvider(this.container);
443-
break;
444439
case SelfHostedIntegrationId.GitHubEnterprise:
445440
provider = new (
446441
await import(/* webpackChunkName: "integrations" */ './github')

src/plus/integrations/authentication/models.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ export type CloudIntegrationAuthType = 'oauth' | 'pat';
3030

3131
export const CloudIntegrationAuthenticationUriPathPrefix = 'did-authenticate-cloud-integration';
3232

33-
export const supportedCloudIntegrationIds = [IssueIntegrationId.Jira, HostingIntegrationId.GitHub];
33+
export const supportedCloudIntegrationIds = [IssueIntegrationId.Jira];
3434
export type SupportedCloudIntegrationIds = (typeof supportedCloudIntegrationIds)[number];
3535

3636
export function isSupportedCloudIntegrationId(id: string): id is SupportedCloudIntegrationIds {

0 commit comments

Comments
 (0)