fix E2E tests (#3610)

* fix error

* set max timeout to 10s

* minor additions to e2e test config

Author: sergiolms

tests/e2e/playwright.config.ts

@@ -22,4 +22,5 @@ export default defineConfig({
 			},
 		},
 	],
+	testMatch: 'specs/*.test.ts',
 });

tests/e2e/specs/baseTest.ts

@@ -16,6 +16,8 @@ type TestFixtures = TestOptions & {
 	createTmpDir: () => Promise<string>;
 };
 
+export const MaxTimeout = 10000;
+
 let testProjectPath: string;
 export const test = base.extend<TestFixtures>({
 	vscodeVersion: ['insiders', { option: true }],
@@ -61,7 +63,12 @@ export const test = base.extend<TestFixtures>({
 			await fs.promises.cp(logPath, logOutputPath, { recursive: true });
 		}
 	},
-	createTmpDir: async (_, use) => {
+	// Next line is necessary because of how Playwright works. It expect a destructured pattern here:
+	// https://github.com/microsoft/playwright/issues/14590#issuecomment-1911734641
+	// https://github.com/microsoft/playwright/issues/21566#issuecomment-1464858235
+
+	// eslint-disable-next-line no-empty-pattern
+	createTmpDir: async ({}, use) => {
 		const tempDirs: string[] = [];
 		await use(async () => {
 			const tempDir = await fs.promises.realpath(await fs.promises.mkdtemp(path.join(os.tmpdir(), 'gltest-')));

tests/e2e/specs/command_palette.test.ts

@@ -1,10 +1,10 @@
-import { expect, test } from './baseTest';
+import { expect, MaxTimeout, test } from './baseTest';
 
 test.describe('Test GitLens Command Palette commands', () => {
 	test('should open commit graph with the command', async ({ page }) => {
 		// Close any open tabs to ensure a clean state
 		const welcomePageTab = page.locator('div[role="tab"][aria-label="Welcome to GitLens"]');
-		await welcomePageTab.waitFor({ state: 'visible', timeout: 5000 });
+		await welcomePageTab.waitFor({ state: 'visible', timeout: MaxTimeout });
 		void welcomePageTab.locator('div.tab-actions .action-item a.codicon-close').click();
 
 		// Open the command palette by clicking on the View menu and selecting Command Palette
@@ -13,15 +13,15 @@ test.describe('Test GitLens Command Palette commands', () => {
 
 		// Wait for the command palette input to be visible and fill it
 		const commandPaletteInput = page.locator('.quick-input-box input');
-		await commandPaletteInput.waitFor({ state: 'visible', timeout: 5000 });
+		await commandPaletteInput.waitFor({ state: 'visible', timeout: MaxTimeout });
 		await commandPaletteInput.fill('> GitLens: Show Commit graph');
 		await page.waitForTimeout(1000);
 		void page.keyboard.press('Enter');
 
 		// Click on the first element (GitLens: Show Commit graph)
 		/*
 		const commandPaletteFirstLine = page.locator('.quick-input-widget .monaco-list .monaco-list-row.focused');
-		await commandPaletteFirstLine.waitFor({ state: 'visible', timeout: 5000 });
+		await commandPaletteFirstLine.waitFor({ state: 'visible', timeout: MaxTimeout });
 		await commandPaletteFirstLine.click();
 		*/
 		// Graph should be opened