Fixes overview repo selection

Author: d13

src/webviews/apps/plus/home/components/active-work.ts

@@ -189,7 +189,7 @@ export class GlActiveWork extends SignalWatcher(LitElement) {
 	}
 
 	private onChange(_e: MouseEvent) {
-		void this._activeOverviewState.changeRepository();
+		this._activeOverviewState.changeRepository();
 	}
 }
 

src/webviews/apps/plus/home/components/overviewState.ts

@@ -6,8 +6,9 @@ import type {
 	OverviewFilters,
 } from '../../../../home/protocol';
 import {
-	ChangeOverviewRepository,
+	ChangeOverviewRepositoryCommand,
 	DidChangeOverviewFilter,
+	DidChangeOverviewRepository,
 	DidChangeRepositories,
 	DidChangeRepositoryWip,
 	GetActiveOverview,
@@ -44,6 +45,9 @@ export class ActiveOverviewState extends AsyncComputedState<ActiveOverview> {
 				case DidChangeRepositoryWip.is(msg):
 					this.run(true);
 					break;
+				case DidChangeOverviewRepository.is(msg):
+					this.run(true);
+					break;
 			}
 		});
 	}
@@ -52,9 +56,8 @@ export class ActiveOverviewState extends AsyncComputedState<ActiveOverview> {
 		this._disposable?.dispose();
 	}
 
-	async changeRepository(): Promise<void> {
-		await this._ipc.sendRequest(ChangeOverviewRepository, undefined);
-		this.run(true);
+	changeRepository(): void {
+		this._ipc.sendCommand(ChangeOverviewRepositoryCommand, undefined);
 	}
 }
 
@@ -84,6 +87,9 @@ export class InactiveOverviewState extends AsyncComputedState<InactiveOverview>
 					this.filter.stale = msg.params.filter.stale;
 					this.run(true);
 					break;
+				case DidChangeOverviewRepository.is(msg):
+					this.run(true);
+					break;
 			}
 		});
 		void this._ipc.sendRequest(GetOverviewFilterState, undefined).then(rsp => {

src/webviews/home/homeWebview.ts

@@ -81,12 +81,13 @@ import type {
 	State,
 } from './protocol';
 import {
-	ChangeOverviewRepository,
+	ChangeOverviewRepositoryCommand,
 	CollapseSectionCommand,
 	DidChangeIntegrationsConnections,
 	DidChangeLaunchpad,
 	DidChangeOrgSettings,
 	DidChangeOverviewFilter,
+	DidChangeOverviewRepository,
 	DidChangePreviewEnabled,
 	DidChangeRepositories,
 	DidChangeRepositoryWip,
@@ -235,7 +236,7 @@ export class HomeWebviewProvider implements WebviewProvider<State, State, HomeWe
 
 		if (pick == null || pick === currentRepo) return;
 
-		this.selectRepository(pick.path);
+		return this.selectRepository(pick.path);
 	}
 
 	private onRepositoriesChanged() {
@@ -353,9 +354,9 @@ export class HomeWebviewProvider implements WebviewProvider<State, State, HomeWe
 			case GetOverviewFilterState.is(e):
 				void this.host.respond(GetOverviewFilterState, e, this._overviewBranchFilter);
 				break;
-			case ChangeOverviewRepository.is(e):
-				await this.onChooseRepository();
-				void this.host.respond(ChangeOverviewRepository, e, undefined);
+			case ChangeOverviewRepositoryCommand.is(e):
+				if ((await this.onChooseRepository()) == null) return;
+				void this.host.notify(DidChangeOverviewRepository, undefined);
 				break;
 			case TogglePreviewEnabledCommand.is(e):
 				this.onTogglePreviewEnabled();

src/webviews/home/protocol.ts

@@ -63,10 +63,6 @@ export const GetLaunchpadSummary = new IpcRequest<GetLaunchpadSummaryRequest, Ge
 	'launchpad/summary',
 );
 
-export interface GetOverviewRequest {
-	[key: string]: unknown;
-}
-
 export interface GetOverviewBranch {
 	reference: GitBranchReference;
 
@@ -238,7 +234,8 @@ export const GetInactiveOverview = new IpcRequest<GetInactiveOverviewRequest, Ge
 export type GetOverviewFilterStateResponse = OverviewFilters;
 export const GetOverviewFilterState = new IpcRequest<void, GetOverviewFilterStateResponse>(scope, 'overviewFilter');
 
-export const ChangeOverviewRepository = new IpcRequest<undefined, undefined>(scope, 'overview/repository/change');
+export const ChangeOverviewRepositoryCommand = new IpcCommand<undefined>(scope, 'overview/repository/change');
+export const DidChangeOverviewRepository = new IpcNotification<undefined>(scope, 'overview/repository/didChange');
 
 // COMMANDS