Avoids requiring an open repo

 - Using `getRepository` requires that the repo to be open, but many commands can work against non-opened repos

Author: eamodio

src/commands/browseRepoAtRevision.ts

@@ -56,13 +56,14 @@ export class BrowseRepoAtRevisionCommand extends ActiveEditorCommand {
 			}
 
 			let gitUri = await GitUri.fromUri(uri);
-			if (gitUri.sha == null) throw new Error('No SHA for Uri');
+			if (gitUri.repoPath == null || gitUri.sha == null) throw new Error('No repo or SHA for Uri');
 
-			const repo = this.container.git.getRepository(gitUri.repoPath!);
-			if (repo == null) throw new Error('No repository for Uri');
+			const { git } = this.container;
 
-			const sha = args?.before ? (await repo.git.revision().resolveRevision(`${gitUri.sha}^`)).sha : gitUri.sha;
-			uri = repo.git.getRevisionUri(sha, gitUri.repoPath!);
+			const sha = args?.before
+				? (await git.revision(gitUri.repoPath).resolveRevision(`${gitUri.sha}^`)).sha
+				: gitUri.sha;
+			uri = git.getRevisionUri(gitUri.repoPath, sha, gitUri.repoPath);
 			gitUri = GitUri.fromRevisionUri(uri);
 
 			openWorkspace(uri, {

src/commands/diffWith.ts

@@ -74,9 +74,12 @@ export class DiffWithCommand extends GlCommandBase {
 
 	async execute(args?: DiffWithCommandArgs): Promise<any> {
 		if (args?.lhs == null || args?.rhs == null) return;
+		if (args.repoPath == null) {
+			debugger;
+			return;
+		}
 
-		const repo = args.repoPath ? this.container.git.getRepository(args.repoPath) : undefined;
-		if (repo == null) return;
+		const { git } = this.container;
 
 		try {
 			let {
@@ -86,8 +89,8 @@ export class DiffWithCommand extends GlCommandBase {
 			const showOptions = { viewColumn: ViewColumn.Active, ...args.showOptions };
 
 			let [lhsResolvedResult, rhsResolvedResult] = await Promise.allSettled([
-				repo.git.revision().resolveRevision(lhsSha, lhsUri),
-				repo.git.revision().resolveRevision(rhsSha, rhsUri),
+				git.revision(args.repoPath).resolveRevision(lhsSha, lhsUri),
+				git.revision(args.repoPath).resolveRevision(rhsSha, rhsUri),
 			]);
 
 			let lhsResolved = getSettledValue(lhsResolvedResult)!;
@@ -96,8 +99,8 @@ export class DiffWithCommand extends GlCommandBase {
 			// If both are missing, check for renames by swapping the paths
 			if (lhsResolved.sha === deletedOrMissing && rhsResolved.sha === deletedOrMissing) {
 				[lhsResolvedResult, rhsResolvedResult] = await Promise.allSettled([
-					repo?.git.revision().resolveRevision(lhsSha, rhsUri),
-					repo?.git.revision().resolveRevision(rhsSha, lhsUri),
+					git.revision(args.repoPath).resolveRevision(lhsSha, rhsUri),
+					git.revision(args.repoPath).resolveRevision(rhsSha, lhsUri),
 				]);
 
 				lhsResolved = getSettledValue(lhsResolvedResult)!;
@@ -118,8 +121,8 @@ export class DiffWithCommand extends GlCommandBase {
 			}
 
 			const [lhsResult, rhsResult] = await Promise.allSettled([
-				repo.git.getBestRevisionUri(lhsUri.fsPath, lhsResolved.sha),
-				repo.git.getBestRevisionUri(rhsUri.fsPath, rhsResolved.sha),
+				git.getBestRevisionUri(args.repoPath, lhsUri.fsPath, lhsResolved.sha),
+				git.getBestRevisionUri(args.repoPath, rhsUri.fsPath, rhsResolved.sha),
 			]);
 
 			const lhs = getSettledValue(lhsResult);
@@ -168,8 +171,8 @@ export class DiffWithCommand extends GlCommandBase {
 			}
 
 			await openDiffEditor(
-				lhs ?? repo.git.getRevisionUri(deletedOrMissing, args.lhs.uri.fsPath),
-				rhs ?? repo.git.getRevisionUri(deletedOrMissing, args.rhs.uri.fsPath),
+				lhs ?? git.getRevisionUri(args.repoPath, deletedOrMissing, args.lhs.uri.fsPath),
+				rhs ?? git.getRevisionUri(args.repoPath, deletedOrMissing, args.rhs.uri.fsPath),
 				title,
 				showOptions,
 			);

src/git/models/commit.ts

@@ -291,10 +291,11 @@ export class GitCommit implements GitRevisionReference {
 	}): Promise<void> {
 		if (this.hasFullDetails(options)) return;
 
-		const repo = this.container.git.getRepository(this.repoPath);
+		const { git } = this.container;
 
 		// If the commit is "uncommitted", then have the files list be all uncommitted files
 		if (this.isUncommitted) {
+			const repo = this.container.git.getRepository(this.repoPath);
 			this._etagFileSystem = repo?.etagFileSystem;
 
 			if (this._etagFileSystem != null || options?.include?.uncommittedFiles) {
@@ -331,7 +332,7 @@ export class GitCommit implements GitRevisionReference {
 
 		if (this.refType === 'stash') {
 			const [stashFilesResult] = await Promise.allSettled([
-				repo?.git.stash()?.getStashCommitFiles(this.sha),
+				git.stash(this.repoPath)?.getStashCommitFiles(this.sha),
 				this.getPreviousSha(),
 			]);
 
@@ -342,7 +343,7 @@ export class GitCommit implements GitRevisionReference {
 			this._stashUntrackedFilesLoaded = true;
 		} else {
 			const [commitResult] = await Promise.allSettled([
-				repo?.git.commits().getCommit(this.sha),
+				git.commits(this.repoPath).getCommit(this.sha),
 				this.getPreviousSha(),
 			]);
 

src/quickpicks/comparisonPicker.ts

@@ -77,8 +77,7 @@ export async function showComparisonPicker(
 
 			if (isBranchReference(head)) {
 				// get the merge target for the branch
-				const repo = container.git.getRepository(repoPath);
-				const branch = await repo?.git.branches().getBranch(head.name);
+				const branch = await container.git.branches(repoPath).getBranch(head.name);
 				if (branch != null) {
 					const info = await getBranchMergeTargetInfo(container, branch);
 					let target;