Skip to content

Commit 3a7ec96

Browse files
committed
Fixes icons on chart
1 parent 7b69abd commit 3a7ec96

File tree

2 files changed

+11
-14
lines changed

2 files changed

+11
-14
lines changed

src/webviews/apps/plus/timeline/components/chart.css.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -348,7 +348,7 @@ export const timelineChartStyles = css`
348348
font-family: var(--font-family);
349349
}
350350
351-
:host-context(:host[placement='view']) .bb .bb-button {
351+
:host-context([data-placement='view']) .bb .bb-button {
352352
margin-right: 2.8rem;
353353
}
354354
@@ -392,7 +392,7 @@ export const timelineChartStyles = css`
392392
opacity: 0;
393393
}
394394
395-
:host-context(:host[placement='view']) .notice--blur {
395+
:host-context([data-placement='view']) .notice--blur {
396396
animation-delay: 0.5s;
397397
}
398398
@@ -477,25 +477,25 @@ export const timelineChartStyles = css`
477477
white-space: pre-line;
478478
}
479479
480-
:host-context(:host[placement='editor']) .bb-axis-y .tick text {
480+
:host-context([data-placement='editor']) .bb-axis-y .tick text {
481481
fill: var(--color-foreground--85);
482482
}
483483
484-
:host-context(:host[placement='view']) .bb-axis-y .tick text {
484+
:host-context([data-placement='view']) .bb-axis-y .tick text {
485485
transform: translate(0, 0.4rem);
486486
font-family: codicon;
487487
font-size: 1.5rem;
488488
}
489489
490490
@media (max-height: 275px) {
491-
:host-context(:host[placement='view']) .bb-axis-y .tick text {
491+
:host-context([data-placement='view']) .bb-axis-y .tick text {
492492
transform: none;
493493
font-size: 1rem;
494494
}
495495
}
496496
497497
@media (max-height: 225px) {
498-
:host-context(:host[placement='view']) .bb-axis-y .tick text {
498+
:host-context([data-placement='view']) .bb-axis-y .tick text {
499499
display: none;
500500
}
501501
}

src/webviews/apps/plus/timeline/components/chart.ts

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -158,13 +158,6 @@ export class GlTimelineChart extends GlElement {
158158
super.disconnectedCallback();
159159
}
160160

161-
// override firstUpdated(changedProperties: PropertyValues): void {
162-
// if (!changedProperties.has('dataPromise')) {
163-
// this.updateChart();
164-
// }
165-
// super.firstUpdated(changedProperties);
166-
// }
167-
168161
override update(changedProperties: PropertyValues): void {
169162
if (changedProperties.has('dataPromise') || this.dataPromise == null) {
170163
this.updateChart();
@@ -765,7 +758,11 @@ export class GlTimelineChart extends GlElement {
765758
padding: { top: 75, bottom: 75 },
766759
tick: {
767760
format: (y: number) => {
768-
if (this.compact) return this.sliceBy === 'branch' ? '\u{EA68}' : '\u{EB99}';
761+
if (this.compact) {
762+
return this.sliceBy === 'branch'
763+
? '\u{EA68}' /* git-branch codicon */
764+
: '\u{EB99}' /* account codicon */;
765+
}
769766
return truncateMiddle(this._slicesByIndex.get(y) ?? '', 30);
770767
},
771768
outer: true,

0 commit comments

Comments
 (0)