Avoids dangling promises

eamodio · eamodio · commit 4d2e632563eb · 2024-12-10T00:05:11.000-05:00
diff --git a/src/ai/aiProviderService.ts b/src/ai/aiProviderService.ts
@@ -566,12 +566,12 @@ async function confirmAIProviderToS<Provider extends AIProviders>(
 	if (result === accept) return true;
 
 	if (result === acceptWorkspace) {
-		void storage.storeWorkspace(`confirm:ai:tos:${model.provider.id}`, true);
+		void storage.storeWorkspace(`confirm:ai:tos:${model.provider.id}`, true).catch();
 		return true;
 	}
 
 	if (result === acceptAlways) {
-		void storage.store(`confirm:ai:tos:${model.provider.id}`, true);
+		void storage.store(`confirm:ai:tos:${model.provider.id}`, true).catch();
 		return true;
 	}
 
@@ -642,7 +642,7 @@ export async function getOrPromptApiKey(
 
 		if (!apiKey) return undefined;
 
-		void storage.storeSecret(`gitlens.${provider.id}.key`, apiKey);
+		void storage.storeSecret(`gitlens.${provider.id}.key`, apiKey).catch();
 	}
 
 	return apiKey;
diff --git a/src/avatars.ts b/src/avatars.ts
@@ -36,7 +36,7 @@ _onDidFetchAvatar.event(
 						),
 				  ]
 				: undefined;
-		void Container.instance.storage.store('avatars', avatars);
+		void Container.instance.storage.store('avatars', avatars).catch();
 	}, 1000),
 );
 
diff --git a/src/env/node/git/localGitProvider.ts b/src/env/node/git/localGitProvider.ts
@@ -467,7 +467,7 @@ export class LocalGitProvider implements GitProvider, Disposable {
 
 		const location = await any<GitLocation>(findGitPromise, findGitFromSCMPromise);
 		// Save the found git path, but let things settle first to not impact startup performance
-		setTimeout(() => void this.container.storage.storeWorkspace('gitPath', location.path), 1000);
+		setTimeout(() => void this.container.storage.storeWorkspace('gitPath', location.path).catch(), 1000);
 
 		if (scope != null) {
 			setLogScopeExit(
diff --git a/src/extension.ts b/src/extension.ts
@@ -189,11 +189,11 @@ export async function activate(context: ExtensionContext): Promise<GitLensApi |
 
 		void showWhatsNew(container, gitlensVersion, prerelease, previousVersion);
 
-		void storage.store(prerelease ? 'preVersion' : 'version', gitlensVersion);
+		void storage.store(prerelease ? 'preVersion' : 'version', gitlensVersion).catch();
 
 		// Only update our synced version if the new version is greater
 		if (syncedVersion == null || compare(gitlensVersion, syncedVersion) === 1) {
-			void storage.store(prerelease ? 'synced:preVersion' : 'synced:version', gitlensVersion);
+			void storage.store(prerelease ? 'synced:preVersion' : 'synced:version', gitlensVersion).catch();
 		}
 
 		if (logLevel === 'debug') {
diff --git a/src/git/gitProviderService.ts b/src/git/gitProviderService.ts
@@ -939,7 +939,7 @@ export class GitProviderService implements Disposable {
 	private updateVisibilityCache(key: string, visibilityInfo: RepositoryVisibilityInfo): void {
 		this.ensureRepoVisibilityCache();
 		this._repoVisibilityCache?.set(key, visibilityInfo);
-		void this.container.storage.store('repoVisibility', Array.from(this._repoVisibilityCache!.entries()));
+		void this.container.storage.store('repoVisibility', Array.from(this._repoVisibilityCache!.entries())).catch();
 	}
 
 	@debug()
diff --git a/src/plus/gk/account/subscriptionService.ts b/src/plus/gk/account/subscriptionService.ts
@@ -1096,11 +1096,13 @@ export class SubscriptionService implements Disposable {
 	private storeCheckInData(data: GKCheckInResponse): void {
 		if (data.user?.id == null) return;
 
-		void this.container.storage.store(`gk:${data.user.id}:checkin`, {
-			v: 1,
-			timestamp: Date.now(),
-			data: data,
-		});
+		void this.container.storage
+			.store(`gk:${data.user.id}:checkin`, {
+				v: 1,
+				timestamp: Date.now(),
+				data: data,
+			})
+			.catch();
 	}
 
 	private async loadStoredCheckInData(userId: string): Promise<GKCheckInResponse | undefined> {
@@ -1373,7 +1375,7 @@ export class SubscriptionService implements Disposable {
 		// If the previous and new subscriptions are exactly the same, kick out
 		if (matches) {
 			if (options?.store) {
-				void this.storeSubscription(subscription);
+				void this.storeSubscription(subscription).catch();
 			}
 			return;
 		}
@@ -1391,7 +1393,7 @@ export class SubscriptionService implements Disposable {
 		});
 
 		if (options?.store !== false) {
-			void this.storeSubscription(subscription);
+			void this.storeSubscription(subscription).catch();
 		}
 
 		this._subscription = subscription;
diff --git a/src/plus/integrations/integration.ts b/src/plus/integrations/integration.ts
@@ -200,7 +200,7 @@ export abstract class IntegrationBase<
 			// Don't store the disconnected flag if silently disconnecting or disconnecting this only for
 			// this current VS Code session (will be re-connected on next restart)
 			if (!options?.currentSessionOnly && !options?.silent) {
-				void this.container.storage.storeWorkspace(this.connectedKey, false);
+				void this.container.storage.storeWorkspace(this.connectedKey, false).catch();
 			}
 
 			this._onDidChange.fire();
diff --git a/src/plus/launchpad/launchpad.ts b/src/plus/launchpad/launchpad.ts
@@ -161,7 +161,7 @@ export class LaunchpadCommand extends QuickCommand<State> {
 			args?.source === 'launchpad-indicator' &&
 			container.storage.get('launchpad:indicator:hasInteracted') == null
 		) {
-			void container.storage.store('launchpad:indicator:hasInteracted', new Date().toISOString());
+			void container.storage.store('launchpad:indicator:hasInteracted', new Date().toISOString()).catch();
 		}
 
 		this.source = { source: args?.source ?? 'commandPalette' };
diff --git a/src/plus/launchpad/launchpadIndicator.ts b/src/plus/launchpad/launchpadIndicator.ts
@@ -584,7 +584,7 @@ export class LaunchpadIndicator implements Disposable {
 
 		const hasLoaded = this.container.storage.get('launchpad:indicator:hasLoaded') ?? false;
 		if (!hasLoaded) {
-			void this.container.storage.store('launchpad:indicator:hasLoaded', true);
+			void this.container.storage.store('launchpad:indicator:hasLoaded', true).catch();
 			this.container.telemetry.sendEvent('launchpad/indicator/firstLoad');
 		}
 	}
diff --git a/src/plus/utils.ts b/src/plus/utils.ts
@@ -158,7 +158,7 @@ export async function confirmDraftStorage(container: Container): Promise<boolean
 		);
 
 		if (result === accept) {
-			void container.storage.store('confirm:draft:storage', true);
+			void container.storage.store('confirm:draft:storage', true).catch();
 			return true;
 		}
 
diff --git a/src/plus/webviews/graph/graphWebview.ts b/src/plus/webviews/graph/graphWebview.ts
@@ -858,7 +858,7 @@ export class GraphWebviewProvider implements WebviewProvider<State, State, Graph
 	}
 
 	updateGraphSearchMode(params: UpdateGraphSearchModeParams) {
-		void this.container.storage.store('graph:searchMode', params.searchMode);
+		void this.container.storage.store('graph:searchMode', params.searchMode).catch();
 	}
 
 	private _showActiveSelectionDetailsDebounced:
@@ -2591,7 +2591,7 @@ export class GraphWebviewProvider implements WebviewProvider<State, State, Graph
 		for (const [key, value] of Object.entries(columnsCfg)) {
 			columns = updateRecordValue(columns, key, value);
 		}
-		void this.container.storage.storeWorkspace('graph:columns', columns);
+		void this.container.storage.storeWorkspace('graph:columns', columns).catch();
 		void this.notifyDidChangeColumns();
 	}
 
diff --git a/src/system/vscode/command.ts b/src/system/vscode/command.ts
@@ -47,7 +47,7 @@ export function registerCommand(command: string, callback: CommandCallback, this
 					'context.submode': context?.submode,
 				});
 			}
-			void Container.instance.usage.track(`command:${command as Commands}:executed`);
+			void Container.instance.usage.track(`command:${command as Commands}:executed`).catch();
 			callback.call(this, ...args);
 		},
 		thisArg,
diff --git a/src/views/nodes/compareBranchNode.ts b/src/views/nodes/compareBranchNode.ts
@@ -110,7 +110,7 @@ export class CompareBranchNode extends SubscribeableViewNode<
 	private onNodesCheckedStateChanged(e: TreeCheckboxChangeEvent<ViewNode>) {
 		const prefix = getComparisonStoragePrefix(this.getStorageId());
 		if (e.items.some(([n]) => n.id?.startsWith(prefix))) {
-			void this.storeCompareWith(false);
+			void this.storeCompareWith(false).catch();
 		}
 	}
 
@@ -254,7 +254,7 @@ export class CompareBranchNode extends SubscribeableViewNode<
 
 	@log()
 	clearReviewed() {
-		void this.storeCompareWith(true);
+		void this.storeCompareWith(true).catch();
 		void this.triggerChange();
 	}
 
diff --git a/src/views/nodes/compareResultsNode.ts b/src/views/nodes/compareResultsNode.ts
@@ -54,7 +54,7 @@ export class CompareResultsNode extends SubscribeableViewNode<
 		// If this is a new comparison, save it
 		if (this._storedAt === 0) {
 			this._storedAt = Date.now();
-			void this.store(true);
+			void this.store(true).catch();
 		}
 	}
 
@@ -123,7 +123,7 @@ export class CompareResultsNode extends SubscribeableViewNode<
 	private onNodesCheckedStateChanged(e: TreeCheckboxChangeEvent<ViewNode>) {
 		const prefix = getComparisonStoragePrefix(this.getStorageId());
 		if (e.items.some(([n]) => n.id?.startsWith(prefix))) {
-			void this.store(true);
+			void this.store(true).catch();
 		}
 	}
 
@@ -252,7 +252,7 @@ export class CompareResultsNode extends SubscribeableViewNode<
 	@log()
 	clearReviewed() {
 		resetComparisonCheckedFiles(this.view, this.getStorageId());
-		void this.store();
+		void this.store().catch();
 	}
 
 	@log()
diff --git a/src/views/nodes/launchpadViewGroupingNode.ts b/src/views/nodes/launchpadViewGroupingNode.ts
@@ -39,7 +39,7 @@ export class LaunchpadViewGroupingNode<TChild extends ViewNode = ViewNode> exten
 				storedExpandedGroups.splice(storedExpandedGroups.indexOf(this.group), 1);
 			}
 
-			void this.view.container.storage.store('launchpadView:groups:expanded', storedExpandedGroups);
+			void this.view.container.storage.store('launchpadView:groups:expanded', storedExpandedGroups).catch();
 		}
 	}
 }
diff --git a/src/views/nodes/searchResultsNode.ts b/src/views/nodes/searchResultsNode.ts
@@ -58,7 +58,7 @@ export class SearchResultsNode extends ViewNode<'search-results', SearchAndCompa
 		// If this is a new search, save it
 		if (this._storedAt === 0) {
 			this._storedAt = Date.now();
-			void this.store(true);
+			void this.store(true).catch();
 		}
 	}
 
diff --git a/src/views/viewBase.ts b/src/views/viewBase.ts
@@ -502,7 +502,7 @@ export abstract class ViewBase<
 
 	protected onVisibilityChanged(e: TreeViewVisibilityChangeEvent) {
 		if (e.visible) {
-			void this.container.usage.track(`${this.trackingFeature}:shown`);
+			void this.container.usage.track(`${this.trackingFeature}:shown`).catch();
 		}
 
 		this._onDidChangeVisibility.fire(e);
diff --git a/src/views/views.ts b/src/views/views.ts
@@ -80,7 +80,7 @@ export class Views implements Disposable {
 	set lastSelectedScmGroupedView(type: GroupableTreeViewTypes | undefined) {
 		this._lastSelectedScmGroupedView = type;
 		void setContext('gitlens:views:scm:grouped:view', type);
-		void this.container.storage.storeWorkspace('views:scm:grouped:selected', type);
+		void this.container.storage.storeWorkspace('views:scm:grouped:selected', type).catch();
 	}
 
 	private _scmGroupedView: ScmGroupedView | undefined;
@@ -294,12 +294,12 @@ export class Views implements Disposable {
 
 			registerCommand('gitlens.views.scm.grouped.welcome.dismiss', () => {
 				this._welcomeDismissed = true;
-				void this.container.storage.store('views:scm:grouped:welcome:dismissed', true);
+				void this.container.storage.store('views:scm:grouped:welcome:dismissed', true).catch();
 				this.updateScmGroupedViewsRegistration();
 			}),
 			registerCommand('gitlens.views.scm.grouped.welcome.restore', async () => {
 				this._welcomeDismissed = true;
-				void this.container.storage.store('views:scm:grouped:welcome:dismissed', true);
+				void this.container.storage.store('views:scm:grouped:welcome:dismissed', true).catch();
 				await updateScmGroupedViewsInConfig(new Set());
 			}),
 		];
diff --git a/src/webviews/commitDetails/commitDetailsWebview.ts b/src/webviews/commitDetails/commitDetailsWebview.ts
@@ -1616,10 +1616,9 @@ export class CommitDetailsWebviewProvider
 			preferences.autolinksExpanded != null &&
 			this._context.preferences?.autolinksExpanded !== preferences.autolinksExpanded
 		) {
-			void this.container.storage.storeWorkspace(
-				'views:commitDetails:autolinksExpanded',
-				preferences.autolinksExpanded,
-			);
+			void this.container.storage
+				.storeWorkspace('views:commitDetails:autolinksExpanded', preferences.autolinksExpanded)
+				.catch();
 
 			changes.autolinksExpanded = preferences.autolinksExpanded;
 		}
@@ -1628,10 +1627,9 @@ export class CommitDetailsWebviewProvider
 			preferences.pullRequestExpanded != null &&
 			this._context.preferences?.pullRequestExpanded !== preferences.pullRequestExpanded
 		) {
-			void this.container.storage.storeWorkspace(
-				'views:commitDetails:pullRequestExpanded',
-				preferences.pullRequestExpanded,
-			);
+			void this.container.storage
+				.storeWorkspace('views:commitDetails:pullRequestExpanded', preferences.pullRequestExpanded)
+				.catch();
 
 			changes.pullRequestExpanded = preferences.pullRequestExpanded;
 		}
diff --git a/src/webviews/home/homeWebview.ts b/src/webviews/home/homeWebview.ts
@@ -421,31 +421,31 @@ export class HomeWebviewProvider implements WebviewProvider<State, State, HomeWe
 		const collapsed = this.container.storage.get('home:sections:collapsed');
 		if (collapsed == null) {
 			if (params.collapsed === true) {
-				void this.container.storage.store('home:sections:collapsed', [params.section]);
+				void this.container.storage.store('home:sections:collapsed', [params.section]).catch();
 			}
 			return;
 		}
 
 		const idx = collapsed.indexOf(params.section);
 		if (params.collapsed === true) {
 			if (idx === -1) {
-				void this.container.storage.store('home:sections:collapsed', [...collapsed, params.section]);
+				void this.container.storage.store('home:sections:collapsed', [...collapsed, params.section]).catch();
 			}
 
 			return;
 		}
 
 		if (idx !== -1) {
 			collapsed.splice(idx, 1);
-			void this.container.storage.store('home:sections:collapsed', collapsed);
+			void this.container.storage.store('home:sections:collapsed', collapsed).catch();
 		}
 	}
 
 	private dismissWalkthrough() {
 		const dismissed = this.container.storage.get('home:walkthrough:dismissed');
 		if (!dismissed) {
-			void this.container.storage.store('home:walkthrough:dismissed', true);
-			void this.container.usage.track('home:walkthrough:dismissed');
+			void this.container.storage.store('home:walkthrough:dismissed', true).catch();
+			void this.container.usage.track('home:walkthrough:dismissed').catch();
 		}
 	}
 
diff --git a/src/webviews/rebase/rebaseEditor.ts b/src/webviews/rebase/rebaseEditor.ts
@@ -166,7 +166,7 @@ export class RebaseEditorProvider implements CustomTextEditorProvider, Disposabl
 
 	@debug<RebaseEditorProvider['resolveCustomTextEditor']>({ args: { 1: false, 2: false } })
 	async resolveCustomTextEditor(document: TextDocument, panel: WebviewPanel, _token: CancellationToken) {
-		void this.container.usage.track(`rebaseEditor:shown`);
+		void this.container.usage.track(`rebaseEditor:shown`).catch();
 
 		const repoPath = normalizePath(Uri.joinPath(document.uri, '..', '..', '..').fsPath);
 		const repo = this.container.git.getRepository(repoPath);
diff --git a/src/webviews/webviewController.ts b/src/webviews/webviewController.ts
@@ -456,7 +456,7 @@ export class WebviewController<
 		}
 
 		if (visible) {
-			void this.container.usage.track(`${this.descriptor.trackingFeature}:shown`);
+			void this.container.usage.track(`${this.descriptor.trackingFeature}:shown`).catch();
 
 			setContextKeys(this.descriptor.contextKeyPrefix);
 			if (active != null) {
diff --git a/src/webviews/webviewsController.ts b/src/webviews/webviewsController.ts
@@ -277,7 +277,7 @@ export class WebviewsController implements Disposable {
 				if (!(await ensurePlusFeaturesEnabled())) return;
 			}
 
-			void container.usage.track(`${descriptor.trackingFeature}:shown`);
+			void container.usage.track(`${descriptor.trackingFeature}:shown`).catch();
 
 			let column = options?.column ?? descriptor.column ?? ViewColumn.Beside;
 			// Only try to open beside if there is an active tab

Original file line number	Diff line number	Diff line change
`@@ -566,12 +566,12 @@ async function confirmAIProviderToS<Provider extends AIProviders>(`
`566`	`566`	`if (result === accept) return true;`
`567`	`567`
`568`	`568`	`if (result === acceptWorkspace) {`
`569`		- void storage.storeWorkspace(`confirm:ai:tos:${model.provider.id}`, true);
	`569`	+ void storage.storeWorkspace(`confirm:ai:tos:${model.provider.id}`, true).catch();
`570`	`570`	`return true;`
`571`	`571`	`}`
`572`	`572`
`573`	`573`	`if (result === acceptAlways) {`
`574`		- void storage.store(`confirm:ai:tos:${model.provider.id}`, true);
	`574`	+ void storage.store(`confirm:ai:tos:${model.provider.id}`, true).catch();
`575`	`575`	`return true;`
`576`	`576`	`}`
`577`	`577`
`@@ -642,7 +642,7 @@ export async function getOrPromptApiKey(`
`642`	`642`
`643`	`643`	`if (!apiKey) return undefined;`
`644`	`644`
`645`		- void storage.storeSecret(`gitlens.${provider.id}.key`, apiKey);
	`645`	+ void storage.storeSecret(`gitlens.${provider.id}.key`, apiKey).catch();
`646`	`646`	`}`
`647`	`647`
`648`	`648`	`return apiKey;`
Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@ _onDidFetchAvatar.event(`
`36`	`36`	`),`
`37`	`37`	`]`
`38`	`38`	`: undefined;`
`39`		`- void Container.instance.storage.store('avatars', avatars);`
	`39`	`+ void Container.instance.storage.store('avatars', avatars).catch();`
`40`	`40`	`}, 1000),`
`41`	`41`	`);`
`42`	`42`
Original file line number	Diff line number	Diff line change
`@@ -939,7 +939,7 @@ export class GitProviderService implements Disposable {`
`939`	`939`	`private updateVisibilityCache(key: string, visibilityInfo: RepositoryVisibilityInfo): void {`
`940`	`940`	`this.ensureRepoVisibilityCache();`
`941`	`941`	`this._repoVisibilityCache?.set(key, visibilityInfo);`
`942`		`- void this.container.storage.store('repoVisibility', Array.from(this._repoVisibilityCache!.entries()));`
	`942`	`+ void this.container.storage.store('repoVisibility', Array.from(this._repoVisibilityCache!.entries())).catch();`
`943`	`943`	`}`
`944`	`944`
`945`	`945`	`@debug()`
Original file line number	Diff line number	Diff line change
`@@ -200,7 +200,7 @@ export abstract class IntegrationBase<`
`200`	`200`	`// Don't store the disconnected flag if silently disconnecting or disconnecting this only for`
`201`	`201`	`// this current VS Code session (will be re-connected on next restart)`
`202`	`202`	`if (!options?.currentSessionOnly && !options?.silent) {`
`203`		`- void this.container.storage.storeWorkspace(this.connectedKey, false);`
	`203`	`+ void this.container.storage.storeWorkspace(this.connectedKey, false).catch();`
`204`	`204`	`}`
`205`	`205`
`206`	`206`	`this._onDidChange.fire();`
Original file line number	Diff line number	Diff line change
`@@ -161,7 +161,7 @@ export class LaunchpadCommand extends QuickCommand<State> {`
`161`	`161`	`args?.source === 'launchpad-indicator' &&`
`162`	`162`	`container.storage.get('launchpad:indicator:hasInteracted') == null`
`163`	`163`	`) {`
`164`		`- void container.storage.store('launchpad:indicator:hasInteracted', new Date().toISOString());`
	`164`	`+ void container.storage.store('launchpad:indicator:hasInteracted', new Date().toISOString()).catch();`
`165`	`165`	`}`
`166`	`166`
`167`	`167`	`this.source = { source: args?.source ?? 'commandPalette' };`
Original file line number	Diff line number	Diff line change
`@@ -584,7 +584,7 @@ export class LaunchpadIndicator implements Disposable {`
`584`	`584`
`585`	`585`	`const hasLoaded = this.container.storage.get('launchpad:indicator:hasLoaded') ?? false;`
`586`	`586`	`if (!hasLoaded) {`
`587`		`- void this.container.storage.store('launchpad:indicator:hasLoaded', true);`
	`587`	`+ void this.container.storage.store('launchpad:indicator:hasLoaded', true).catch();`
`588`	`588`	`this.container.telemetry.sendEvent('launchpad/indicator/firstLoad');`
`589`	`589`	`}`
`590`	`590`	`}`
Original file line number	Diff line number	Diff line change
`@@ -158,7 +158,7 @@ export async function confirmDraftStorage(container: Container): Promise<boolean`
`158`	`158`	`);`
`159`	`159`
`160`	`160`	`if (result === accept) {`
`161`		`- void container.storage.store('confirm:draft:storage', true);`
	`161`	`+ void container.storage.store('confirm:draft:storage', true).catch();`
`162`	`162`	`return true;`
`163`	`163`	`}`
`164`	`164`