Skip to content

Commit 51717dc

Browse files
eamodioeamodio
committed
Improves type-checking perf
1 parent 4afc61b commit 51717dc

File tree

3 files changed

+533
-460
lines changed

3 files changed

+533
-460
lines changed

‎docs/telemetry-events.md‎

Lines changed: 17 additions & 97 deletions
Original file line numberDiff line numberDiff line change
@@ -958,19 +958,8 @@ void
958958
959959
```typescript
960960
{
961-
'action': 'open' | 'code-suggest' | 'merge' | 'soft-open' | 'switch' | 'open-worktree' | 'switch-and-code-suggest' | 'show-overview' | 'open-changes' | 'open-in-graph' | 'pin' | 'unpin' | 'snooze' | 'unsnooze' | 'open-suggestion' | 'open-suggestion-browser',
962-
'initialState.group': string,
963-
'initialState.selectTopItem': boolean,
964961
'instance': number,
965-
[`item.${string}`]: string | number | boolean,
966-
'items.error': string
967-
}
968-
```
969-
970-
or
971-
972-
```typescript
973-
{
962+
'items.error': string,
974963
'action': 'open' | 'code-suggest' | 'merge' | 'soft-open' | 'switch' | 'open-worktree' | 'switch-and-code-suggest' | 'show-overview' | 'open-changes' | 'open-in-graph' | 'pin' | 'unpin' | 'snooze' | 'unsnooze' | 'open-suggestion' | 'open-suggestion-browser',
975964
'groups.blocked.collapsed': boolean,
976965
'groups.blocked.count': number,
@@ -995,7 +984,6 @@ or
995984
'groups.waiting-for-review.count': number,
996985
'initialState.group': string,
997986
'initialState.selectTopItem': boolean,
998-
'instance': number,
999987
[`item.${string}`]: string | number | boolean,
1000988
'items.count': number,
1001989
'items.timings.codeSuggestionCounts': number,
@@ -1030,19 +1018,8 @@ or
10301018
10311019
```typescript
10321020
{
1033-
'collapsed': boolean,
1034-
'group': 'current-branch' | 'pinned' | 'mergeable' | 'blocked' | 'follow-up' | 'needs-review' | 'waiting-for-review' | 'draft' | 'other' | 'snoozed',
1035-
'initialState.group': string,
1036-
'initialState.selectTopItem': boolean,
10371021
'instance': number,
1038-
'items.error': string
1039-
}
1040-
```
1041-
1042-
or
1043-
1044-
```typescript
1045-
{
1022+
'items.error': string,
10461023
'collapsed': boolean,
10471024
'group': 'current-branch' | 'pinned' | 'mergeable' | 'blocked' | 'follow-up' | 'needs-review' | 'waiting-for-review' | 'draft' | 'other' | 'snoozed',
10481025
'groups.blocked.collapsed': boolean,
@@ -1068,7 +1045,6 @@ or
10681045
'groups.waiting-for-review.count': number,
10691046
'initialState.group': string,
10701047
'initialState.selectTopItem': boolean,
1071-
'instance': number,
10721048
'items.count': number,
10731049
'items.timings.codeSuggestionCounts': number,
10741050
'items.timings.enrichedItems': number,
@@ -1098,9 +1074,9 @@ void
10981074
10991075
```typescript
11001076
{
1077+
'instance': number,
11011078
'initialState.group': string,
1102-
'initialState.selectTopItem': boolean,
1103-
'instance': number
1079+
'initialState.selectTopItem': boolean
11041080
}
11051081
```
11061082

@@ -1110,18 +1086,8 @@ void
11101086
11111087
```typescript
11121088
{
1113-
'connected': boolean,
1114-
'initialState.group': string,
1115-
'initialState.selectTopItem': boolean,
11161089
'instance': number,
1117-
'items.error': string
1118-
}
1119-
```
1120-
1121-
or
1122-
1123-
```typescript
1124-
{
1090+
'items.error': string,
11251091
'connected': boolean,
11261092
'groups.blocked.collapsed': boolean,
11271093
'groups.blocked.count': number,
@@ -1146,7 +1112,6 @@ or
11461112
'groups.waiting-for-review.count': number,
11471113
'initialState.group': string,
11481114
'initialState.selectTopItem': boolean,
1149-
'instance': number,
11501115
'items.count': number,
11511116
'items.timings.codeSuggestionCounts': number,
11521117
'items.timings.enrichedItems': number,
@@ -1172,18 +1137,8 @@ or
11721137
11731138
```typescript
11741139
{
1175-
'connected': boolean,
1176-
'initialState.group': string,
1177-
'initialState.selectTopItem': boolean,
11781140
'instance': number,
1179-
'items.error': string
1180-
}
1181-
```
1182-
1183-
or
1184-
1185-
```typescript
1186-
{
1141+
'items.error': string,
11871142
'connected': boolean,
11881143
'groups.blocked.collapsed': boolean,
11891144
'groups.blocked.count': number,
@@ -1208,7 +1163,6 @@ or
12081163
'groups.waiting-for-review.count': number,
12091164
'initialState.group': string,
12101165
'initialState.selectTopItem': boolean,
1211-
'instance': number,
12121166
'items.count': number,
12131167
'items.timings.codeSuggestionCounts': number,
12141168
'items.timings.enrichedItems': number,
@@ -1222,19 +1176,8 @@ or
12221176
12231177
```typescript
12241178
{
1225-
'action': 'select',
1226-
'initialState.group': string,
1227-
'initialState.selectTopItem': boolean,
12281179
'instance': number,
1229-
[`item.${string}`]: string | number | boolean,
1230-
'items.error': string
1231-
}
1232-
```
1233-
1234-
or
1235-
1236-
```typescript
1237-
{
1180+
'items.error': string,
12381181
'action': 'select',
12391182
'groups.blocked.collapsed': boolean,
12401183
'groups.blocked.count': number,
@@ -1259,7 +1202,6 @@ or
12591202
'groups.waiting-for-review.count': number,
12601203
'initialState.group': string,
12611204
'initialState.selectTopItem': boolean,
1262-
'instance': number,
12631205
[`item.${string}`]: string | number | boolean,
12641206
'items.count': number,
12651207
'items.timings.codeSuggestionCounts': number,
@@ -1274,18 +1216,8 @@ or
12741216
12751217
```typescript
12761218
{
1277-
'connected': boolean,
1278-
'initialState.group': string,
1279-
'initialState.selectTopItem': boolean,
12801219
'instance': number,
1281-
'items.error': string
1282-
}
1283-
```
1284-
1285-
or
1286-
1287-
```typescript
1288-
{
1220+
'items.error': string,
12891221
'connected': boolean,
12901222
'groups.blocked.collapsed': boolean,
12911223
'groups.blocked.count': number,
@@ -1310,7 +1242,6 @@ or
13101242
'groups.waiting-for-review.count': number,
13111243
'initialState.group': string,
13121244
'initialState.selectTopItem': boolean,
1313-
'instance': number,
13141245
'items.count': number,
13151246
'items.timings.codeSuggestionCounts': number,
13161247
'items.timings.enrichedItems': number,
@@ -1324,18 +1255,8 @@ or
13241255
13251256
```typescript
13261257
{
1327-
'action': 'settings' | 'feedback' | 'open-on-gkdev' | 'refresh' | 'connect',
1328-
'initialState.group': string,
1329-
'initialState.selectTopItem': boolean,
13301258
'instance': number,
1331-
'items.error': string
1332-
}
1333-
```
1334-
1335-
or
1336-
1337-
```typescript
1338-
{
1259+
'items.error': string,
13391260
'action': 'settings' | 'feedback' | 'open-on-gkdev' | 'refresh' | 'connect',
13401261
'groups.blocked.collapsed': boolean,
13411262
'groups.blocked.count': number,
@@ -1360,7 +1281,6 @@ or
13601281
'groups.waiting-for-review.count': number,
13611282
'initialState.group': string,
13621283
'initialState.selectTopItem': boolean,
1363-
'instance': number,
13641284
'items.count': number,
13651285
'items.timings.codeSuggestionCounts': number,
13661286
'items.timings.enrichedItems': number,
@@ -1378,7 +1298,7 @@ or
13781298
'provider': string,
13791299
'repoPrivacy': 'private' | 'public' | 'local',
13801300
'repository.visibility': 'private' | 'public' | 'local',
1381-
'source': 'graph' | 'patchDetails' | 'settings' | 'timeline' | 'home' | 'account' | 'subscription' | 'code-suggest' | 'cloud-patches' | 'commandPalette' | 'deeplink' | 'inspect' | 'inspect-overview' | 'integrations' | 'launchpad' | 'launchpad-indicator' | 'launchpad-view' | 'notification' | 'prompt' | 'quick-wizard' | 'remoteProvider' | 'startWork' | 'trial-indicator' | 'scm-input' | 'walkthrough' | 'whatsnew' | 'worktrees'
1301+
'source': 'account' | 'subscription' | 'graph' | 'patchDetails' | 'settings' | 'timeline' | 'home' | 'code-suggest' | 'cloud-patches' | 'commandPalette' | 'deeplink' | 'inspect' | 'inspect-overview' | 'integrations' | 'launchpad' | 'launchpad-indicator' | 'launchpad-view' | 'notification' | 'prompt' | 'quick-wizard' | 'remoteProvider' | 'startWork' | 'trial-indicator' | 'scm-input' | 'walkthrough' | 'whatsnew' | 'worktrees'
13821302
}
13831303
```
13841304

@@ -1547,9 +1467,9 @@ void
15471467
15481468
```typescript
15491469
{
1470+
'instance': number,
15501471
'action': 'connect' | 'manage',
15511472
'connected': boolean,
1552-
'instance': number,
15531473
'items.count': number
15541474
}
15551475
```
@@ -1560,9 +1480,9 @@ void
15601480
15611481
```typescript
15621482
{
1483+
'instance': number,
15631484
'action': 'soft-open',
15641485
'connected': boolean,
1565-
'instance': number,
15661486
[`item.${string}`]: string | number | boolean,
15671487
'items.count': number
15681488
}
@@ -1574,8 +1494,8 @@ void
15741494
15751495
```typescript
15761496
{
1577-
'connected': boolean,
15781497
'instance': number,
1498+
'connected': boolean,
15791499
[`item.${string}`]: string | number | boolean,
15801500
'items.count': number
15811501
}
@@ -1597,8 +1517,8 @@ void
15971517
15981518
```typescript
15991519
{
1600-
'connected': boolean,
16011520
'instance': number,
1521+
'connected': boolean,
16021522
'items.count': number
16031523
}
16041524
```
@@ -1609,8 +1529,8 @@ void
16091529
16101530
```typescript
16111531
{
1612-
'connected': boolean,
16131532
'instance': number,
1533+
'connected': boolean,
16141534
'items.count': number
16151535
}
16161536
```
@@ -1621,8 +1541,8 @@ void
16211541
16221542
```typescript
16231543
{
1624-
'connected': boolean,
16251544
'instance': number,
1545+
'connected': boolean,
16261546
'items.count': number
16271547
}
16281548
```
@@ -1633,9 +1553,9 @@ void
16331553
16341554
```typescript
16351555
{
1556+
'instance': number,
16361557
'action': 'connect',
16371558
'connected': boolean,
1638-
'instance': number,
16391559
'items.count': number
16401560
}
16411561
```

0 commit comments

Comments
 (0)