Adds support for untracked files in composer (#4653)

* Adds support for untracked files in composer

* Shortens try/catch block

Author: axosoft-ramint

src/env/node/git/sub-providers/staging.ts

@@ -78,11 +78,15 @@ export class StagingGitSubProvider implements GitStagingSubProvider {
 	}
 
 	@log()
-	async stageFiles(repoPath: string, pathOrUri: string[] | Uri[]): Promise<void> {
+	async stageFiles(
+		repoPath: string,
+		pathOrUri: string[] | Uri[],
+		options?: { intentToAdd?: boolean },
+	): Promise<void> {
 		await this.git.exec(
 			{ cwd: repoPath },
 			'add',
-			'-A',
+			options?.intentToAdd ? '-N' : '-A',
 			'--',
 			...pathOrUri.map(p => (typeof p === 'string' ? p : splitPath(p, repoPath)[0])),
 		);

src/git/gitProvider.ts

@@ -653,7 +653,7 @@ export interface DisposableTemporaryGitIndex extends UnifiedAsyncDisposable {
 export interface GitStagingSubProvider {
 	createTemporaryIndex(repoPath: string, base: string): Promise<DisposableTemporaryGitIndex>;
 	stageFile(repoPath: string, pathOrUri: string | Uri): Promise<void>;
-	stageFiles(repoPath: string, pathOrUri: string[] | Uri[]): Promise<void>;
+	stageFiles(repoPath: string, pathOrUri: string[] | Uri[], options?: { intentToAdd?: boolean }): Promise<void>;
 	stageDirectory(repoPath: string, directoryOrUri: string | Uri): Promise<void>;
 	unstageFile(repoPath: string, pathOrUri: string | Uri): Promise<void>;
 	unstageFiles(repoPath: string, pathOrUri: string[] | Uri[]): Promise<void>;

src/webviews/plus/composer/composerWebview.ts

@@ -78,6 +78,7 @@ import {
 	ReloadComposerCommand,
 } from './protocol';
 import type { ComposerWebviewShowingArgs } from './registration';
+import type { WorkingTreeDiffs } from './utils';
 import {
 	convertToComposerDiffInfo,
 	createCombinedDiffForCommit,
@@ -108,6 +109,9 @@ export class ComposerWebviewProvider implements WebviewProvider<State, State, Co
 	// Telemetry context - tracks composer-specific data for getTelemetryContext
 	private _context: ComposerContext;
 
+	// Flag to ignore index change tracking for when we need to stage untracked files
+	private _ignoreIndexChange = false;
+
 	constructor(
 		protected readonly container: Container,
 		protected readonly host: WebviewHost<'gitlens.composer'>,
@@ -299,13 +303,28 @@ export class ComposerWebviewProvider implements WebviewProvider<State, State, Co
 		source?: Sources,
 		isReload?: boolean,
 	): Promise<State> {
+		// Stop repo change subscription so we can deal with untracked files
+		this._repositorySubscription?.dispose();
+		const status = await repo.git.status?.getStatus();
+		const untrackedPaths = status?.untrackedChanges.map(f => f.path);
+		if (untrackedPaths?.length) {
+			try {
+				await repo.git.staging?.stageFiles(untrackedPaths, { intentToAdd: true });
+				this._ignoreIndexChange = true;
+			} catch {}
+		}
+
 		const [diffsResult, commitResult, branchResult] = await Promise.allSettled([
 			// Handle baseCommit - could be string (old format) or ComposerBaseCommit (new format)
 			getWorkingTreeDiffs(repo),
 			repo.git.commits.getCommit('HEAD'),
 			repo.git.branches.getBranch(),
 		]);
 
+		if (untrackedPaths?.length) {
+			await repo.git.staging?.unstageFiles(untrackedPaths).catch();
+		}
+
 		const diffs = getSettledValue(diffsResult)!;
 
 		this._context.diff.unstagedIncluded = false;
@@ -755,9 +774,13 @@ export class ComposerWebviewProvider implements WebviewProvider<State, State, Co
 
 	private async onRepositoryChanged(e: RepositoryChangeEvent): Promise<void> {
 		if (e.repository.id !== this._currentRepository?.id) return;
-
+		const ignoreIndexChange = this._ignoreIndexChange;
+		this._ignoreIndexChange = false;
 		// Only care about index changes (staged/unstaged changes)
-		if (!e.changed(RepositoryChange.Index, RepositoryChangeComparisonMode.Any)) {
+		if (
+			!e.changed(RepositoryChange.Index, RepositoryChangeComparisonMode.Any) ||
+			(ignoreIndexChange && e.changed(RepositoryChange.Index, RepositoryChangeComparisonMode.Exclusive))
+		) {
 			return;
 		}
 
@@ -1089,7 +1112,26 @@ export class ComposerWebviewProvider implements WebviewProvider<State, State, Co
 			);
 
 			// Validate repository safety state before proceeding
-			const validation = await validateSafetyState(repo, this._safetyState, hunksBeingCommitted);
+			// Stop repo change subscription so we can deal with untracked files
+			let workingTreeDiffs: WorkingTreeDiffs | undefined;
+			if (this._context.diff.unstagedIncluded) {
+				this._repositorySubscription?.dispose();
+				const status = await repo.git.status?.getStatus();
+				const untrackedPaths = status?.untrackedChanges.map(f => f.path);
+				if (untrackedPaths?.length) {
+					try {
+						workingTreeDiffs = await getWorkingTreeDiffs(repo);
+						await repo.git.staging?.stageFiles(untrackedPaths);
+					} catch {}
+				}
+			}
+
+			const validation = await validateSafetyState(
+				repo,
+				this._safetyState,
+				hunksBeingCommitted,
+				workingTreeDiffs,
+			);
 			if (!validation.isValid) {
 				// Clear loading state and show safety error
 				await this.host.notify(DidFinishCommittingNotification, undefined);
@@ -1197,7 +1239,7 @@ export class ComposerWebviewProvider implements WebviewProvider<State, State, Co
 				if (
 					stashCommit &&
 					stashCommit.ref !== previousStashCommit?.ref &&
-					stashCommit.message === stashMessage
+					stashCommit.message?.includes(stashMessage)
 				) {
 					stashedSuccessfully = true;
 				}

src/webviews/plus/composer/utils.ts

@@ -343,6 +343,7 @@ export async function validateSafetyState(
 	repo: Repository,
 	safetyState: ComposerSafetyState,
 	hunksBeingCommitted?: ComposerHunk[],
+	workingTreeDiffs?: WorkingTreeDiffs,
 ): Promise<{ isValid: boolean; errors: string[] }> {
 	const errors: string[] = [];
 
@@ -361,7 +362,7 @@ export async function validateSafetyState(
 
 		// 2. Smart diff validation - only check diffs for sources being committed
 		if (hunksBeingCommitted?.length) {
-			const { staged, unstaged /*, unified*/ } = await getWorkingTreeDiffs(repo);
+			const { staged, unstaged /*, unified*/ } = workingTreeDiffs ?? (await getWorkingTreeDiffs(repo));
 
 			const hashes = {
 				staged: staged?.contents ? await sha256(staged.contents) : null,