Require feedback context in markdown metadata

Ensures feedback context is always included in markdown document metadata,
improving consistency and reliability for downstream consumers. Updates
function signatures and metadata construction to treat feedback context
as required, removing conditional logic that previously made it optional.

move

Author: sergeibbb

src/commands/explainBase.ts

@@ -55,11 +55,37 @@ export abstract class ExplainCommandBase extends GlCommandBase {
 		return svc;
 	}
 
-	protected openDocument(result: AISummarizeResult, path: string, metadata: MarkdownContentMetadata): void {
-		const headerContent = getMarkdownHeaderContent(metadata, this.container.telemetry.enabled);
+	protected openDocument(
+		result: AISummarizeResult,
+		path: string,
+		metadata: Omit<MarkdownContentMetadata, 'feedbackContext'>,
+	): void {
+		// Add feedback context to metadata
+		const feedbackContext: AIFeedbackContext = {
+			feature: this.constructor.name,
+			model: {
+				id: result.model.id,
+				providerId: result.model.provider.id,
+				providerName: result.model.provider.name,
+			},
+			usage: result.usage,
+			outputLength: result.content?.length,
+		};
+
+		const enrichedMetadata = {
+			...metadata,
+			feedbackContext: feedbackContext as unknown as Record<string, unknown>,
+		};
+
+		const headerContent = getMarkdownHeaderContent(enrichedMetadata, this.container.telemetry.enabled);
 		const content = `${headerContent}\n\n${result.parsed.summary}\n\n${result.parsed.body}`;
 
-		const documentUri = this.container.markdown.openDocument(content, path, metadata.header.title, metadata);
+		const documentUri = this.container.markdown.openDocument(
+			content,
+			path,
+			metadata.header.title,
+			enrichedMetadata,
+		);
 
 		showMarkdownPreview(documentUri);
 	}

src/commands/generateRebase.ts

@@ -537,21 +537,17 @@ function generateRebaseMarkdown(
 	result: AIRebaseResult,
 	title = 'Rebase Commits',
 	telemetryEnabled: boolean,
-	feedbackContext?: AIFeedbackContext,
+	feedbackContext: AIFeedbackContext,
 ): { content: string; metadata: MarkdownContentMetadata } {
 	const metadata: MarkdownContentMetadata = {
 		header: {
 			title: title,
 			aiModel: result.model.name,
 			subtitle: 'Explanation',
 		},
+		feedbackContext: feedbackContext as unknown as Record<string, unknown>,
 	};
 
-	// Always store feedback context if available, but only show UI when telemetry is enabled
-	if (feedbackContext) {
-		metadata.feedbackContext = feedbackContext as unknown as Record<string, unknown>;
-	}
-
 	let markdown = '';
 	if (result.commits.length === 0) {
 		markdown = 'No Commits Generated';

src/documents/markdown.ts

@@ -18,7 +18,7 @@ export interface MarkdownContentMetadata {
 		name: GlCommands;
 		args?: Record<string, unknown>;
 	};
-	feedbackContext?: Record<string, unknown>;
+	feedbackContext: Record<string, unknown>;
 }
 
 export class MarkdownContentProvider implements TextDocumentContentProvider {