Fixes #3846 shows correct message when Launchpad has an error

Author: d13

src/plus/launchpad/utils.ts

@@ -4,9 +4,15 @@ import type { LaunchpadSummaryResult } from './launchpadIndicator';
 import { generateLaunchpadSummary } from './launchpadIndicator';
 import type { LaunchpadGroup } from './launchpadProvider';
 
-export async function getLaunchpadSummary(container: Container): Promise<LaunchpadSummaryResult> {
+export async function getLaunchpadSummary(container: Container): Promise<LaunchpadSummaryResult | { error: Error }> {
 	const result = await container.launchpad.getCategorizedItems();
-	const groups: LaunchpadGroup[] = configuration.get('launchpad.indicator.groups') ?? [];
 
+	if (result.error != null) {
+		return {
+			error: result.error,
+		};
+	}
+
+	const groups: LaunchpadGroup[] = configuration.get('launchpad.indicator.groups') ?? [];
 	return generateLaunchpadSummary(result.items, groups);
 }

src/webviews/apps/plus/home/components/launchpad.ts

@@ -200,6 +200,13 @@ export class GlLaunchpad extends SignalWatcher(LitElement) {
 
 	private renderSummary(summary: LaunchpadSummary | undefined) {
 		if (summary == null) return nothing;
+
+		if ('error' in summary) {
+			return html`<ul class="menu">
+				<li>Unable to load items</li>
+			</ul>`;
+		}
+
 		if (summary.total === 0) {
 			return html`<ul class="menu">
 				<li>You are all caught up!</li>

src/webviews/home/protocol.ts

@@ -44,7 +44,7 @@ export interface OverviewFilters {
 export interface GetLaunchpadSummaryRequest {
 	[key: string]: unknown;
 }
-export type GetLaunchpadSummaryResponse = LaunchpadSummaryResult | undefined;
+export type GetLaunchpadSummaryResponse = LaunchpadSummaryResult | { error: Error } | undefined;
 export const GetLaunchpadSummary = new IpcRequest<GetLaunchpadSummaryRequest, GetLaunchpadSummaryResponse>(
 	scope,
 	'launchpad/summary',