Skip to content

Commit 63e3126

Browse files
committed
Simplifies the event name
(#4224, #4258)
1 parent c9b3afc commit 63e3126

File tree

11 files changed

+23
-23
lines changed

11 files changed

+23
-23
lines changed

contributions.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,8 +71,8 @@
7171
"enablement": "gitlens:enabled && resourceScheme =~ /^(gitlens|pr)$/",
7272
"commandPalette": "!gitlens:hasVirtualFolders && gitlens:enabled && resourceScheme =~ /^(gitlens|git|pr)$/"
7373
},
74-
"gitlens.changeUserDefinedMergeBase": {
75-
"label": "Change Merge Target of a branch",
74+
"gitlens.changeBranchMergeTarget": {
75+
"label": "Change Branch Merge Target",
7676
"commandPalette": "gitlens:enabled && !gitlens:readonly && !gitlens:untrusted && !gitlens:hasVirtualFolders"
7777
},
7878
"gitlens.clearFileAnnotations": {

docs/telemetry-events.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1160,7 +1160,7 @@ or
11601160
}
11611161
```
11621162

1163-
### home/changeUserDefinedMergeBase
1163+
### home/changeBranchMergeTarget
11641164

11651165
> Sent when the user starts defining a user-specific merge target branch
11661166

package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6086,8 +6086,8 @@
60866086
"enablement": "gitlens:enabled && resourceScheme =~ /^(gitlens|pr)$/"
60876087
},
60886088
{
6089-
"command": "gitlens.changeUserDefinedMergeBase",
6090-
"title": "Change Merge Target of a branch",
6089+
"command": "gitlens.changeBranchMergeTarget",
6090+
"title": "Change Branch Merge Target",
60916091
"category": "GitLens"
60926092
},
60936093
{
@@ -10376,7 +10376,7 @@
1037610376
"when": "!gitlens:hasVirtualFolders && gitlens:enabled && resourceScheme =~ /^(gitlens|git|pr)$/"
1037710377
},
1037810378
{
10379-
"command": "gitlens.changeUserDefinedMergeBase",
10379+
"command": "gitlens.changeBranchMergeTarget",
1038010380
"when": "gitlens:enabled && !gitlens:readonly && !gitlens:untrusted && !gitlens:hasVirtualFolders"
1038110381
},
1038210382
{

src/commands/changeUserDefinedMergeBase.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,13 +30,13 @@ function assertState(state: PartialStepState<InitialState>): asserts state is St
3030
}
3131

3232
export interface ChangeUserDefinedMergeBaseCommandArgs {
33-
readonly command: 'changeUserDefinedMergeBase';
33+
readonly command: 'changeBranchMergeTarget';
3434
state?: Partial<InitialState>;
3535
}
3636

3737
export class ChangeUserDefinedMergeBaseCommand extends QuickCommand {
3838
constructor(container: Container, args?: ChangeUserDefinedMergeBaseCommandArgs) {
39-
super(container, 'changeUserDefinedMergeBase', 'changeUserDefinedMergeBase', 'Change Merge Target', {
39+
super(container, 'changeBranchMergeTarget', 'changeBranchMergeTarget', 'Change Merge Target', {
4040
description: 'Change Merge Target for a branch',
4141
});
4242
let counter = 0;

src/commands/quickWizard.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ export class QuickWizardCommand extends QuickWizardCommandBase {
2020
'gitlens.showLaunchpad',
2121
'gitlens.startWork',
2222
'gitlens.associateIssueWithBranch',
23-
'gitlens.changeUserDefinedMergeBase',
23+
'gitlens.changeBranchMergeTarget',
2424
]);
2525
}
2626

@@ -35,8 +35,8 @@ export class QuickWizardCommand extends QuickWizardCommandBase {
3535
case 'gitlens.associateIssueWithBranch':
3636
return this.execute({ command: 'associateIssueWithBranch', ...args });
3737

38-
case 'gitlens.changeUserDefinedMergeBase':
39-
return this.execute({ command: 'changeUserDefinedMergeBase', ...args });
38+
case 'gitlens.changeBranchMergeTarget':
39+
return this.execute({ command: 'changeBranchMergeTarget', ...args });
4040

4141
default:
4242
return this.execute(args);

src/commands/quickWizard.utils.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ export class QuickWizardRootStep implements QuickPickStep<QuickCommand> {
124124
this.hiddenItems.push(new AssociateIssueWithBranchCommand(container, args));
125125
}
126126

127-
if (args?.command === 'changeUserDefinedMergeBase') {
127+
if (args?.command === 'changeBranchMergeTarget') {
128128
this.hiddenItems.push(new ChangeUserDefinedMergeBaseCommand(container, args));
129129
}
130130
}

src/constants.commands.generated.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -619,7 +619,7 @@ export type ContributedPaletteCommands =
619619
| 'gitlens.browseRepoAtRevisionInNewWindow'
620620
| 'gitlens.browseRepoBeforeRevision'
621621
| 'gitlens.browseRepoBeforeRevisionInNewWindow'
622-
| 'gitlens.changeUserDefinedMergeBase'
622+
| 'gitlens.changeBranchMergeTarget'
623623
| 'gitlens.clearFileAnnotations'
624624
| 'gitlens.closeUnchangedFiles'
625625
| 'gitlens.compareHeadWith'

src/constants.commands.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ type InternalGraphWebviewCommands =
3333
| 'gitlens.graph.skipPausedOperation';
3434

3535
type InternalHomeWebviewCommands =
36-
| 'gitlens.home.changeUserDefinedMergeBase'
36+
| 'gitlens.home.changeBranchMergeTarget'
3737
| 'gitlens.home.deleteBranchOrWorktree'
3838
| 'gitlens.home.pushBranch'
3939
| 'gitlens.home.openMergeTargetComparison'
@@ -104,7 +104,7 @@ type InternalWalkthroughCommands =
104104

105105
type InternalGlCommands =
106106
| `gitlens.action.${string}`
107-
| 'gitlens.changeUserDefinedMergeBase'
107+
| 'gitlens.changeBranchMergeTarget'
108108
| 'gitlens.diffWith'
109109
| 'gitlens.openOnRemote'
110110
| 'gitlens.openWalkthrough'

src/constants.telemetry.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@ export interface TelemetryEvents extends WebviewShowAbortedEvents, WebviewShownE
158158
/** Sent when the user chooses to start work on an issue from the home view */
159159
'home/startWork': void;
160160
/** Sent when the user starts defining a user-specific merge target branch */
161-
'home/changeUserDefinedMergeBase': void;
161+
'home/changeBranchMergeTarget': void;
162162

163163
/** Sent when the user takes an action on the Launchpad title bar */
164164
'launchpad/title/action': LaunchpadTitleActionEvent;

src/webviews/apps/plus/home/components/merge-target-status.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -477,7 +477,7 @@ export class GlMergeTargetStatus extends LitElement {
477477
return html`<span class="header__actions"
478478
>${branchRef && targetRef
479479
? html`<gl-button
480-
href="${createCommandLink<BranchAndTargetRefs>('gitlens.home.changeUserDefinedMergeBase', {
480+
href="${createCommandLink<BranchAndTargetRefs>('gitlens.home.changeBranchMergeTarget', {
481481
...branchRef,
482482
mergeTargetId: targetRef.branchId,
483483
mergeTargetName: targetRef.branchName,

0 commit comments

Comments
 (0)