Skip to content

Commit 657db40

Browse files
eamodioeamodio
committed
Updates banner content
1 parent 8c04ce4 commit 657db40

File tree

3 files changed

+58
-53
lines changed

3 files changed

+58
-53
lines changed

‎CHANGELOG.md‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,10 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/) and this p
66

77
## [Unreleased]
88

9+
### Added
10+
11+
- Adds a banner to the _Commit Details_ view to let users know they can move the view to the Secondary Side Bar
12+
913
## [13.0.2] - 2022-10-17
1014

1115
### Added

‎src/webviews/apps/commitDetails/commitDetails.html‎

Lines changed: 52 additions & 52 deletions
Original file line numberDiff line numberDiff line change
@@ -43,59 +43,59 @@ <h2>Best practice</h2>
4343
<p>To best take advantage of this view, we highly recommend moving it to the Secondary Side Bar.</p> -->
4444
</div>
4545
<main class="commit-details commit-detail-panel__main" id="main" tabindex="-1">
46-
<div class="commit-details__top">
47-
<div class="commit-banner" data-region="sidebar-banner">
48-
<code-icon class="commit-banner__icon" icon="layout-sidebar-right"></code-icon>
49-
<div class="commit-banner__message">
50-
<h2>Lock to Sidebar</h2>
51-
<p>Drag and drop this component to the sidepanel to lock it into view.</p>
52-
</div>
53-
<svg
54-
class="svg-themed commit-banner__media"
55-
fill="none"
56-
xmlns="http://www.w3.org/2000/svg"
57-
viewBox="0 0 101 49"
58-
>
59-
<g opacity=".2" stroke="#E6E8FA" class="svg-themed__outline">
60-
<rect x=".5" y=".5" width="99.45" height="48" rx="2.5" />
61-
<path d="M82 0v49M15.66 0v49M1.23 35.02h15.92" />
62-
</g>
63-
<rect
64-
x="6.5"
65-
y="29.5"
66-
width="19"
67-
height="14"
68-
rx=".5"
69-
fill="#2E3346"
70-
stroke="#91D3FF"
71-
class="svg-themed__view"
72-
/>
73-
<rect
74-
x="85.5"
75-
y="4.5"
76-
width="11"
77-
height="41"
78-
rx=".5"
79-
fill="#2E3346"
80-
stroke="#91D3FF"
81-
stroke-dasharray="2 2"
82-
class="svg-themed__view"
83-
/>
84-
<path
85-
d="M22.33 31a2.67 2.67 0 1 0 5.34 0 2.67 2.67 0 0 0-5.34 0ZM76 7l-5.09-2.73.18 5.77L76 7ZM25.42 31.28c4.91-7.46 20.77-22.07 46.1-23.64l-.05-1c-25.7 1.59-41.82 16.4-46.89 24.08l.84.56Z"
86-
fill="#91D3FF"
87-
class="svg-themed__line"
88-
/>
89-
</svg>
90-
<a
91-
class="commit-banner__icon commit-details__commit-action"
92-
href="#"
93-
data-action="dismiss-banner"
94-
aria-label="Dismiss banner"
95-
title="Dismiss banner"
96-
><code-icon icon="chrome-close"></code-icon
97-
></a>
46+
<div class="commit-banner" data-region="sidebar-banner">
47+
<code-icon class="commit-banner__icon" icon="layout-sidebar-right"></code-icon>
48+
<div class="commit-banner__message">
49+
<h2>Move into Secondary Side Bar</h2>
50+
<p>For a better experience, drag and drop this view into the Secondary Side Bar.</p>
9851
</div>
52+
<svg
53+
class="svg-themed commit-banner__media"
54+
fill="none"
55+
xmlns="http://www.w3.org/2000/svg"
56+
viewBox="0 0 101 49"
57+
>
58+
<g opacity=".2" stroke="#E6E8FA" class="svg-themed__outline">
59+
<rect x=".5" y=".5" width="99.45" height="48" rx="2.5" />
60+
<path d="M82 0v49M15.66 0v49M1.23 35.02h15.92" />
61+
</g>
62+
<rect
63+
x="6.5"
64+
y="29.5"
65+
width="19"
66+
height="14"
67+
rx=".5"
68+
fill="#2E3346"
69+
stroke="#91D3FF"
70+
class="svg-themed__view"
71+
/>
72+
<rect
73+
x="85.5"
74+
y="4.5"
75+
width="11"
76+
height="41"
77+
rx=".5"
78+
fill="#2E3346"
79+
stroke="#91D3FF"
80+
stroke-dasharray="2 2"
81+
class="svg-themed__view"
82+
/>
83+
<path
84+
d="M22.33 31a2.67 2.67 0 1 0 5.34 0 2.67 2.67 0 0 0-5.34 0ZM76 7l-5.09-2.73.18 5.77L76 7ZM25.42 31.28c4.91-7.46 20.77-22.07 46.1-23.64l-.05-1c-25.7 1.59-41.82 16.4-46.89 24.08l.84.56Z"
85+
fill="#91D3FF"
86+
class="svg-themed__line"
87+
/>
88+
</svg>
89+
<a
90+
class="commit-banner__icon commit-details__commit-action"
91+
href="#"
92+
data-action="dismiss-banner"
93+
aria-label="Dismiss banner"
94+
title="Dismiss banner"
95+
><code-icon icon="chrome-close"></code-icon
96+
></a>
97+
</div>
98+
<div class="commit-details__top">
9999
<div class="commit-details__top-menu">
100100
<ul class="commit-details__authors" aria-label="Authors">
101101
<li class="commit-details__author" data-region="author">

‎src/webviews/apps/commitDetails/commitDetails.scss‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -250,7 +250,7 @@ ul {
250250
gap: 0.4rem;
251251
font-size: 1.2rem;
252252
border-radius: 0.3rem;
253-
margin-bottom: 1rem;
253+
margin: 1rem;
254254

255255
.vscode-high-contrast &,
256256
.vscode-dark & {
@@ -292,6 +292,7 @@ ul {
292292
min-width: 10rem;
293293
flex-basis: 40%;
294294
max-width: 12rem;
295+
margin-right: 0.6rem;
295296
}
296297

297298
&__icon {

0 commit comments

Comments
 (0)