Refactors feedback button visibility logic for markdown AI

Introduces a context key and a tracker to control the visibility of AI feedback buttons in markdown previews based on both feedback context presence and telemetry settings. Streamlines menu conditions, ensuring buttons only appear when feedback is available and telemetry is enabled, improving maintainability and aligning UI with user permissions.

Author: sergeibbb

contributions.json

@@ -149,7 +149,7 @@
 			"menus": {
 				"editor/title": [
 					{
-						"when": "resourceScheme == gitlens-markdown && config.gitlens.telemetry.enabled && activeCustomEditorId == vscode.markdown.preview.editor",
+						"when": "resourceScheme == gitlens-markdown && config.telemetry.enabled && activeCustomEditorId == vscode.markdown.preview.editor",
 						"group": "navigation",
 						"order": 2
 					}
@@ -162,7 +162,7 @@
 			"menus": {
 				"editor/title": [
 					{
-						"when": "resourceScheme == gitlens-markdown && config.gitlens.telemetry.enabled && activeCustomEditorId == vscode.markdown.preview.editor",
+						"when": "resourceScheme == gitlens-markdown && config.telemetry.enabled && activeCustomEditorId == vscode.markdown.preview.editor",
 						"group": "navigation",
 						"order": 1
 					}

docs/telemetry-events.md

@@ -145,16 +145,10 @@
 
 ```typescript
 {
-  // Request duration if available
-  'duration': number,
   // The AI feature that feedback was submitted for
-  'feature': 'explain' | 'generateCommit' | 'generateRebase' | 'generateStash' | 'generateDraft' | 'generateChangelog' | 'generateCreatePullRequest',
+  'feature': string,
   // Type of feedback provided
   'feedbackType': 'preset' | 'writeIn' | 'both',
-  // Whether write-in feedback was provided
-  'hasWriteInFeedback': boolean,
-  // Input/output lengths if available
-  'input.length': number,
   // Model information
   'model.id': string,
   'model.provider.id': 'anthropic' | 'azure' | 'deepseek' | 'gemini' | 'github' | 'gitkraken' | 'huggingface' | 'mistral' | 'ollama' | 'openai' | 'openaicompatible' | 'openrouter' | 'vscode' | 'xai',
@@ -165,11 +159,15 @@
   // The original rating that led to this feedback
   'rating': 'positive' | 'negative',
   'usage.completionTokens': number,
+  'usage.limits.limit': number,
+  'usage.limits.resetsOn': string,
+  'usage.limits.used': number,
   // Token usage information if available
   'usage.promptTokens': number,
   'usage.totalTokens': number,
   // Length of write-in feedback if provided
-  'writeInFeedback.length': number
+  'writeInFeedback.length': number,
+  'writeInFeedback.text': string
 }
 ```
 

package.json

@@ -14138,12 +14138,12 @@
 				},
 				{
 					"command": "gitlens.ai.feedback.positive",
-					"when": "resourceScheme == gitlens-markdown && config.gitlens.telemetry.enabled && activeCustomEditorId == vscode.markdown.preview.editor",
+					"when": "resourceScheme == gitlens-markdown && config.telemetry.enabled && activeCustomEditorId == vscode.markdown.preview.editor",
 					"group": "navigation@1"
 				},
 				{
 					"command": "gitlens.ai.feedback.negative",
-					"when": "resourceScheme == gitlens-markdown && config.gitlens.telemetry.enabled && activeCustomEditorId == vscode.markdown.preview.editor",
+					"when": "resourceScheme == gitlens-markdown && config.telemetry.enabled && activeCustomEditorId == vscode.markdown.preview.editor",
 					"group": "navigation@2"
 				},
 				{

src/commands/generateRebase.ts

@@ -547,8 +547,8 @@ function generateRebaseMarkdown(
 		},
 	};
 
-	// Add feedback context and commands to toolbar if telemetry is enabled
-	if (feedbackContext && telemetryEnabled) {
+	// Always store feedback context if available, but only show UI when telemetry is enabled
+	if (feedbackContext) {
 		metadata.feedbackContext = feedbackContext as unknown as Record<string, unknown>;
 	}