Skip to content

Commit 868e764

Browse files
committed
Fixes #4061 dragging Settings editor into tab group
1 parent d54eee2 commit 868e764

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/) and this p
88

99
### Fixed
1010

11+
- Fixes Settings editor breaking when dragging it to a new tab group ([#4061](https://github.com/gitkraken/vscode-gitlens/issues/4061))
1112
- Fixes regression where hovering over the Graph WIP row doesn't show up anymore ([#4062](https://github.com/gitkraken/vscode-gitlens/issues/4062))
1213
- Fixes Inspect & Graph Details: autolinks rendering when enabled setting is false ([#3841](https://github.com/gitkraken/vscode-gitlens/issues/3841))
1314
- Fixes comparison with Merge Target on Home fails to open a valid comparison ([#4060](https://github.com/gitkraken/vscode-gitlens/issues/4060))

src/webviews/webviewController.ts

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -498,11 +498,6 @@ export class WebviewController<
498498

499499
@debug()
500500
private onParentVisibilityChanged(visible: boolean, active?: boolean, forceReload?: boolean) {
501-
if (forceReload) {
502-
void this.refresh();
503-
return;
504-
}
505-
506501
if (this.descriptor.webviewHostOptions?.retainContextWhenHidden !== true) {
507502
if (visible) {
508503
if (this._ready) {
@@ -516,6 +511,8 @@ export class WebviewController<
516511
} else {
517512
this._ready = false;
518513
}
514+
} else if (forceReload) {
515+
void this.refresh();
519516
}
520517

521518
if (visible) {

0 commit comments

Comments
 (0)