Removes GlCommand usages

Author: eamodio

contributions.json

@@ -3682,9 +3682,6 @@
 			"label": "Show Cloud Patches View",
 			"commandPalette": "gitlens:enabled && gitlens:gk:organization:drafts:enabled"
 		},
-		"gitlens.showFileHistoryInView": {
-			"label": "Open File History"
-		},
 		"gitlens.showFileHistoryView": {
 			"label": "Show File History View",
 			"commandPalette": "gitlens:enabled"

package.json

@@ -7219,10 +7219,6 @@
 				"title": "Show Cloud Patches View",
 				"category": "GitLens"
 			},
-			{
-				"command": "gitlens.showFileHistoryInView",
-				"title": "Open File History"
-			},
 			{
 				"command": "gitlens.showFileHistoryView",
 				"title": "Show File History View",
@@ -11038,10 +11034,6 @@
 					"command": "gitlens.showDraftsView",
 					"when": "gitlens:enabled && gitlens:gk:organization:drafts:enabled"
 				},
-				{
-					"command": "gitlens.showFileHistoryInView",
-					"when": "false"
-				},
 				{
 					"command": "gitlens.showFileHistoryView",
 					"when": "gitlens:enabled"

src/codelens/codeLensProvider.ts

@@ -760,7 +760,7 @@ function applyToggleFileBlameCommand<T extends GitRecentChangeCodeLens | GitAuth
 	title: string,
 	lens: T,
 ): T {
-	lens.command = createCommand<[Uri]>(GlCommand.ToggleFileBlame, title, lens.uri!.toFileUri());
+	lens.command = createCommand<[Uri]>('gitlens.toggleFileBlame', title, lens.uri!.toFileUri());
 	return lens;
 }
 
@@ -771,7 +771,7 @@ function applyToggleFileChangesCommand<T extends GitRecentChangeCodeLens | GitAu
 	only?: boolean,
 ): T {
 	lens.command = createCommand<[Uri, ToggleFileChangesAnnotationCommandArgs]>(
-		GlCommand.ToggleFileChanges,
+		'gitlens.toggleFileChanges',
 		title,
 		lens.uri!.toFileUri(),
 		{
@@ -786,7 +786,7 @@ function applyToggleFileHeatmapCommand<T extends GitRecentChangeCodeLens | GitAu
 	title: string,
 	lens: T,
 ): T {
-	lens.command = createCommand<[Uri]>(GlCommand.ToggleFileHeatmap, title, lens.uri!.toFileUri());
+	lens.command = createCommand<[Uri]>('gitlens.toggleFileHeatmap', title, lens.uri!.toFileUri());
 	return lens;
 }
 

src/commands/addAuthors.ts

@@ -1,5 +1,4 @@
 import type { SourceControl } from 'vscode';
-import { GlCommand } from '../constants.commands';
 import type { Container } from '../container';
 import { executeGitCommand } from '../git/actions';
 import { command } from '../system/-webview/command';
@@ -8,7 +7,7 @@ import { GlCommandBase } from './commandBase';
 @command()
 export class AddAuthorsCommand extends GlCommandBase {
 	constructor(private readonly container: Container) {
-		super(GlCommand.AddAuthors);
+		super('gitlens.addAuthors');
 	}
 
 	execute(sourceControl: SourceControl): Promise<void> {

src/commands/closeUnchangedFiles.ts

@@ -1,6 +1,5 @@
 import type { Uri } from 'vscode';
 import { TabInputCustom, TabInputNotebook, TabInputNotebookDiff, TabInputText, TabInputTextDiff, window } from 'vscode';
-import { GlCommand } from '../constants.commands';
 import type { Container } from '../container';
 import { showGenericErrorMessage } from '../messages';
 import { getRepositoryOrShowPicker } from '../quickpicks/repositoryPicker';
@@ -16,7 +15,7 @@ export interface CloseUnchangedFilesCommandArgs {
 @command()
 export class CloseUnchangedFilesCommand extends GlCommandBase {
 	constructor(private readonly container: Container) {
-		super(GlCommand.CloseUnchangedFiles);
+		super('gitlens.closeUnchangedFiles');
 	}
 
 	async execute(args?: CloseUnchangedFilesCommandArgs): Promise<void> {

src/commands/commandBase.ts

@@ -36,7 +36,7 @@ export abstract class GlCommandBase implements Disposable {
 
 	abstract execute(...args: any[]): any;
 
-	protected _execute(command: string, ...args: any[]): Promise<unknown> {
+	protected _execute(command: GlCommands, ...args: any[]): Promise<unknown> {
 		const [context, rest] = parseCommandContext(command, { ...this.contextParsingOptions }, ...args);
 
 		// If there an array of contexts, then we want to execute the command for each
@@ -60,7 +60,7 @@ export abstract class ActiveEditorCommand extends GlCommandBase {
 		return this.execute(context.editor, context.uri, ...args);
 	}
 
-	protected override _execute(command: string, ...args: any[]): any {
+	protected override _execute(command: GlCommands, ...args: any[]): any {
 		return super._execute(command, undefined, ...args);
 	}
 
@@ -73,7 +73,7 @@ export function getLastCommand(): { command: string; args: any[] } | undefined {
 }
 
 export abstract class ActiveEditorCachedCommand extends ActiveEditorCommand {
-	protected override _execute(command: string, ...args: any[]): any {
+	protected override _execute(command: GlCommands, ...args: any[]): any {
 		lastCommand = {
 			command: command,
 			args: args,

src/commands/commandContext.ts

@@ -6,6 +6,7 @@ import type {
 	TextEditor,
 	Uri,
 } from 'vscode';
+import type { GlCommands } from '../constants.commands';
 import type { ViewNode } from '../views/nodes/abstract/viewNode';
 
 export type CommandContext =
@@ -22,7 +23,7 @@ export type CommandContext =
 	| CommandViewNodesContext;
 
 export interface CommandContextBase {
-	command: string;
+	command: GlCommands;
 	editor?: TextEditor;
 	uri?: Uri;
 

src/commands/commandContext.utils.ts

@@ -1,5 +1,6 @@
 import type { GitTimelineItem, SourceControl, TextEditor } from 'vscode';
 import { Uri, window } from 'vscode';
+import type { GlCommands } from '../constants.commands';
 import type { StoredNamedRef } from '../constants.storage';
 import type { GitBranch } from '../git/models/branch';
 import { isBranch } from '../git/models/branch';
@@ -157,7 +158,7 @@ export interface CommandContextParsingOptions {
 }
 
 export function parseCommandContext(
-	command: string,
+	command: GlCommands,
 	options?: CommandContextParsingOptions,
 	...args: any[]
 ): [CommandContext | CommandContext[], any[]] {

src/commands/compareWith.ts

@@ -21,8 +21,8 @@ export class CompareWithCommand extends ActiveEditorCommand {
 			GlCommand.CompareWith,
 			GlCommand.CompareHeadWith,
 			GlCommand.CompareWorkingWith,
-			GlCommand.Deprecated_DiffHeadWith,
-			GlCommand.Deprecated_DiffWorkingWith,
+			/** @deprecated */ 'gitlens.diffHeadWith',
+			/** @deprecated */ 'gitlens.diffWorkingWith',
 		]);
 	}
 
@@ -33,13 +33,13 @@ export class CompareWithCommand extends ActiveEditorCommand {
 				break;
 
 			case GlCommand.CompareHeadWith:
-			case GlCommand.Deprecated_DiffHeadWith:
+			case /** @deprecated */ 'gitlens.diffHeadWith':
 				args = { ...args };
 				args.ref1 = 'HEAD';
 				break;
 
 			case GlCommand.CompareWorkingWith:
-			case GlCommand.Deprecated_DiffWorkingWith:
+			case /** @deprecated */ 'gitlens.diffWorkingWith':
 				args = { ...args };
 				args.ref1 = '';
 				break;

src/commands/copyCurrentBranch.ts

@@ -1,6 +1,5 @@
 import type { TextEditor, Uri } from 'vscode';
 import { env } from 'vscode';
-import { GlCommand } from '../constants.commands';
 import type { Container } from '../container';
 import { GitUri } from '../git/gitUri';
 import { showGenericErrorMessage } from '../messages';
@@ -13,7 +12,7 @@ import { getCommandUri } from './commandBase.utils';
 @command()
 export class CopyCurrentBranchCommand extends ActiveEditorCommand {
 	constructor(private readonly container: Container) {
-		super(GlCommand.CopyCurrentBranch);
+		super('gitlens.copyCurrentBranch');
 	}
 
 	async execute(editor?: TextEditor, uri?: Uri): Promise<void> {