Skip to content

Commit 8ecffb3

Browse files
committed
Normalizes gk settings to lowercase
1 parent e969614 commit 8ecffb3

File tree

6 files changed

+26
-11
lines changed

6 files changed

+26
-11
lines changed

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3990,7 +3990,7 @@
39903990
"scope": "window",
39913991
"order": 20
39923992
},
3993-
"gitlens.gitKraken.cli.integration.enabled": {
3993+
"gitlens.gitkraken.cli.integration.enabled": {
39943994
"type": "boolean",
39953995
"default": false,
39963996
"markdownDescription": "Specifies whether to enable experimental integration with the GitKraken CLI",
@@ -4903,7 +4903,7 @@
49034903
"title": "GitKraken",
49044904
"order": 9000,
49054905
"properties": {
4906-
"gitlens.gitKraken.activeOrganizationId": {
4906+
"gitlens.gitkraken.activeOrganizationId": {
49074907
"type": "string",
49084908
"markdownDescription": "Specifies the ID of the user's active GitKraken organization in GitLens",
49094909
"scope": "window",

src/config.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ export interface Config {
2525
readonly detectNestedRepositories: boolean;
2626
readonly fileAnnotations: FileAnnotationsConfig;
2727
readonly gitCommands: GitCommandsConfig;
28-
readonly gitKraken: GitKrakenConfig;
28+
readonly gitkraken: GitKrakenConfig;
2929
readonly graph: GraphConfig;
3030
readonly heatmap: HeatmapConfig;
3131
readonly home: HomeConfig;

src/env/node/gk/cli/integration.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,8 @@ export class GkCliIntegrationProvider implements Disposable {
2929
}
3030

3131
private onConfigurationChanged(e?: ConfigurationChangeEvent): void {
32-
if (e == null || configuration.changed(e, 'gitKraken.cli.integration.enabled')) {
33-
if (!configuration.get('gitKraken.cli.integration.enabled')) {
32+
if (e == null || configuration.changed(e, 'gitkraken.cli.integration.enabled')) {
33+
if (!configuration.get('gitkraken.cli.integration.enabled')) {
3434
this.stop();
3535
} else {
3636
void this.start();

src/plus/gk/__debug__accountDebug.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,9 @@ import type { Container } from '../../container';
1010
import type { QuickPickItemOfT } from '../../quickpicks/items/common';
1111
import { createQuickPickSeparator } from '../../quickpicks/items/common';
1212
import { registerCommand } from '../../system/-webview/command';
13-
import { configuration } from '../../system/-webview/configuration';
1413
import type { GKCheckInResponse, GKLicenses, GKLicenseType, GKUser } from './models/checkin';
1514
import type { SubscriptionService } from './subscriptionService';
15+
import { getConfiguredActiveOrganizationId } from './utils/-webview/subscription.utils';
1616
import { getSubscriptionFromCheckIn } from './utils/checkin.utils';
1717
import { getPreviewSubscription } from './utils/subscription.utils';
1818

@@ -308,7 +308,7 @@ class AccountDebug {
308308
(await this.container.organizations.getOrganizations({
309309
userId: subscription.account.id,
310310
})) ?? [];
311-
let activeOrganizationId = configuration.get('gitKraken.activeOrganizationId') ?? undefined;
311+
let activeOrganizationId = getConfiguredActiveOrganizationId();
312312
if (activeOrganizationId === '' || (activeOrganizationId == null && organizations.length === 1)) {
313313
activeOrganizationId = organizations[0].id;
314314
}

src/plus/gk/subscriptionService.ts

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,7 @@ import type { Promo } from './models/promo';
7474
import type { Subscription } from './models/subscription';
7575
import type { ServerConnection } from './serverConnection';
7676
import { ensurePlusFeaturesEnabled } from './utils/-webview/plus.utils';
77+
import { getConfiguredActiveOrganizationId, updateActiveOrganizationId } from './utils/-webview/subscription.utils';
7778
import { getSubscriptionFromCheckIn } from './utils/checkin.utils';
7879
import {
7980
assertSubscriptionState,
@@ -1174,12 +1175,12 @@ export class SubscriptionService implements Disposable {
11741175
Logger.error(ex, scope);
11751176
organizations = [];
11761177
}
1177-
let chosenOrganizationId: string | undefined = configuration.get('gitKraken.activeOrganizationId') ?? undefined;
1178+
let chosenOrganizationId = getConfiguredActiveOrganizationId();
11781179
if (chosenOrganizationId === '') {
11791180
chosenOrganizationId = undefined;
11801181
} else if (chosenOrganizationId != null && !organizations.some(o => o.id === chosenOrganizationId)) {
11811182
chosenOrganizationId = undefined;
1182-
void configuration.updateEffective('gitKraken.activeOrganizationId', undefined);
1183+
void updateActiveOrganizationId(undefined);
11831184
}
11841185
const subscription = getSubscriptionFromCheckIn(data, organizations, chosenOrganizationId);
11851186
this._lastValidatedDate = new Date();
@@ -1668,8 +1669,8 @@ export class SubscriptionService implements Disposable {
16681669

16691670
const organizationSubscription = getSubscriptionFromCheckIn(checkInData, organizations, pick.org.id);
16701671

1671-
if (configuration.get('gitKraken.activeOrganizationId') !== pick.org.id) {
1672-
await configuration.updateEffective('gitKraken.activeOrganizationId', pick.org.id);
1672+
if (getConfiguredActiveOrganizationId() !== pick.org.id) {
1673+
await updateActiveOrganizationId(pick.org.id);
16731674
}
16741675

16751676
this.changeSubscription(
Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
import { configuration } from '../../../../system/-webview/configuration';
2+
3+
export function getConfiguredActiveOrganizationId(): string | undefined {
4+
return (
5+
configuration.get('gitkraken.activeOrganizationId') ??
6+
// Deprecated: Use `gitlens.gitkraken.activeOrganizationId` instead
7+
configuration.getAny('gitlens.gitKraken.activeOrganizationId') ??
8+
undefined
9+
);
10+
}
11+
12+
export async function updateActiveOrganizationId(orgId: string | undefined): Promise<void> {
13+
await configuration.updateEffective('gitkraken.activeOrganizationId', orgId);
14+
}

0 commit comments

Comments
 (0)