Skip to content

Commit 8ed5684

Browse files
committed
Adds more comments
1 parent 40e2ce2 commit 8ed5684

File tree

2 files changed

+8
-0
lines changed

2 files changed

+8
-0
lines changed

docs/telemetry-events.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,9 @@
6969
'global.subscription.featurePreviews.graph.status': 'eligible' | 'active' | 'expired',
7070
'global.subscription.previewTrial.expiresOn': string,
7171
'global.subscription.previewTrial.startedOn': string,
72+
// Promo discount code associated with the upgrade
7273
'global.subscription.promo.code': string,
74+
// Promo key (identifier) associated with the upgrade
7375
'global.subscription.promo.key': string,
7476
'global.subscription.state': -1 | 0 | 1 | 2 | 3 | 4 | 5 | 6,
7577
'global.subscription.stateString': 'verification' | 'free' | 'preview' | 'preview-expired' | 'trial' | 'trial-expired' | 'trial-reactivation-eligible' | 'paid' | 'unknown',
@@ -1766,7 +1768,9 @@ void
17661768
'subscription.featurePreviews.graph.status': 'eligible' | 'active' | 'expired',
17671769
'subscription.previewTrial.expiresOn': string,
17681770
'subscription.previewTrial.startedOn': string,
1771+
// Promo discount code associated with the upgrade
17691772
'subscription.promo.code': string,
1773+
// Promo key (identifier) associated with the upgrade
17701774
'subscription.promo.key': string,
17711775
'subscription.state': -1 | 0 | 1 | 2 | 3 | 4 | 5 | 6,
17721776
'subscription.stateString': 'verification' | 'free' | 'preview' | 'preview-expired' | 'trial' | 'trial-expired' | 'trial-reactivation-eligible' | 'paid' | 'unknown'
@@ -1871,7 +1875,9 @@ or
18711875
'subscription.featurePreviews.graph.status': 'eligible' | 'active' | 'expired',
18721876
'subscription.previewTrial.expiresOn': string,
18731877
'subscription.previewTrial.startedOn': string,
1878+
// Promo discount code associated with the upgrade
18741879
'subscription.promo.code': string,
1880+
// Promo key (identifier) associated with the upgrade
18751881
'subscription.promo.key': string,
18761882
'subscription.state': -1 | 0 | 1 | 2 | 3 | 4 | 5 | 6,
18771883
'subscription.stateString': 'verification' | 'free' | 'preview' | 'preview-expired' | 'trial' | 'trial-expired' | 'trial-reactivation-eligible' | 'paid' | 'unknown'

src/constants.telemetry.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -789,7 +789,9 @@ export interface SubscriptionPreviousEventData
789789
Partial<Flatten<NonNullable<Subscription['previewTrial']>, 'previous.subscription.previewTrial', true>> {}
790790

791791
export interface SubscriptionEventData extends Partial<SubscriptionCurrentEventData> {
792+
/** Promo key (identifier) associated with the upgrade */
792793
'subscription.promo.key'?: string;
794+
/** Promo discount code associated with the upgrade */
793795
'subscription.promo.code'?: string;
794796
'subscription.state'?: SubscriptionState;
795797
'subscription.stateString'?: SubscriptionStateString;

0 commit comments

Comments
 (0)