Aligns "empties"

Author: eamodio

src/api/api.ts

@@ -3,11 +3,7 @@ import { Container } from '../container';
 import { builtInActionRunnerName } from './actionRunners';
 import type { Action, ActionContext, ActionRunner, GitLensApi } from './gitlens';
 
-const emptyDisposable = Object.freeze({
-	dispose: () => {
-		/* noop */
-	},
-});
+const emptyDisposable: Disposable = Object.freeze({ dispose: () => {} });
 
 export class Api implements GitLensApi {
 	readonly #container: Container;

src/env/node/git/git.ts

@@ -50,7 +50,7 @@ import type { RunOptions, RunResult } from './shell';
 import { fsExists, isWindows, runSpawn } from './shell';
 import { CancelledRunError, RunError } from './shell.errors';
 
-const emptyArray = Object.freeze([]) as unknown as any[];
+const emptyArray: readonly any[] = Object.freeze([]);
 const emptyObj = Object.freeze({});
 
 const gitBranchDefaultConfigs = Object.freeze(['-c', 'color.branch=false']);

src/git/cache.ts

@@ -23,7 +23,7 @@ interface RepositoryInfo {
 	user?: GitUser | null;
 }
 
-const emptyArray = Object.freeze([]) as unknown as any[];
+const emptyArray: readonly any[] = Object.freeze([]);
 
 export class GitCache implements Disposable {
 	private readonly _disposable: Disposable;

src/git/fsProvider.ts

@@ -12,7 +12,8 @@ import { GitUri, isGitUri } from './gitUri';
 import { deletedOrMissing } from './models/revision';
 import type { GitTreeEntry } from './models/tree';
 
-const emptyArray = new Uint8Array(0);
+const emptyArray = Object.freeze(new Uint8Array(0));
+const emptyDisposable: Disposable = Object.freeze({ dispose: () => {} });
 
 export function fromGitLensFSUri(uri: Uri): { path: string; ref: string; repoPath: string } {
 	const gitUri = isGitUri(uri) ? uri : GitUri.fromRevisionUri(uri);
@@ -128,11 +129,7 @@ export class GitFileSystemProvider implements FileSystemProvider, Disposable {
 	}
 
 	watch(): Disposable {
-		return {
-			dispose: () => {
-				// nothing to dispose
-			},
-		};
+		return emptyDisposable;
 	}
 
 	writeFile(uri: Uri): void | Thenable<void> {

src/git/gitProviderService.ts

@@ -84,12 +84,8 @@ import { calculateDistribution } from './utils/contributor.utils';
 import { getRemoteThemeIconString, getVisibilityCacheKey } from './utils/remote.utils';
 import { createRevisionRange } from './utils/revision.utils';
 
-const emptyArray = Object.freeze([]) as unknown as any[];
-const emptyDisposable = Object.freeze({
-	dispose: () => {
-		/* noop */
-	},
-});
+const emptyArray: readonly any[] = Object.freeze([]);
+const emptyDisposable: Disposable = Object.freeze({ dispose: () => {} });
 
 const maxDefaultBranchWeight = 100;
 const weightedDefaultBranches = new Map<string, number>([

src/views/nodes/branchNode.ts

@@ -756,11 +756,7 @@ export async function getBranchNodeParts(
 	};
 }
 
-const emptyDisposable = Object.freeze({
-	dispose: () => {
-		/* noop */
-	},
-});
+const emptyDisposable: Disposable = Object.freeze({ dispose: () => {} });
 
 export class CommitsCurrentBranchNode extends SubscribeableViewNode<'commits-current-branch'> {
 	private repo: Repository | undefined;

src/webviews/home/homeWebview.ts

@@ -119,11 +119,7 @@ import {
 } from './protocol';
 import type { HomeWebviewShowingArgs } from './registration';
 
-const emptyDisposable = Object.freeze({
-	dispose: () => {
-		/* noop */
-	},
-});
+const emptyDisposable: Disposable = Object.freeze({ dispose: () => {} });
 
 interface RepositoryBranchData {
 	repo: Repository;