Skip to content

Commit 943da85

Browse files
committed
replace magic number
1 parent 448441e commit 943da85

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

src/features.ts

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,11 +60,13 @@ export function getFeaturePreviewLabel(feature: FeaturePreviews) {
6060
}
6161
}
6262

63+
const hoursInMs = 3600000;
64+
6365
export function isFeaturePreviewActive(featurePreview?: FeaturePreview) {
6466
const usages = featurePreview?.usages;
6567
if (usages == null || usages.length === 0) return false;
6668

67-
const remainingHours = (new Date(usages[usages.length - 1].expiresOn).getTime() - new Date().getTime()) / 3600000;
69+
const remainingHours = (new Date(usages[usages.length - 1].expiresOn).getTime() - new Date().getTime()) / hoursInMs;
6870
return (
6971
usages.length <= proFeaturePreviewUsages &&
7072
remainingHours > 0 &&
@@ -74,7 +76,9 @@ export function isFeaturePreviewActive(featurePreview?: FeaturePreview) {
7476

7577
export function isFeaturePreviewExpired(featurePreview: FeaturePreview) {
7678
const usages = featurePreview.usages;
77-
const remainingHours = (new Date(usages[usages.length - 1].expiresOn).getTime() - new Date().getTime()) / 3600000;
79+
if (usages == null || usages.length === 0) return false;
80+
81+
const remainingHours = (new Date(usages[usages.length - 1].expiresOn).getTime() - new Date().getTime()) / hoursInMs;
7882
return (
7983
usages.length > proFeaturePreviewUsages ||
8084
(usages.length === proFeaturePreviewUsages && remainingHours <= 0) ||

0 commit comments

Comments
 (0)