Improves delayed detection of active items: uses onDidChangeActive

instead of a timout delay
(#3763, #3770)

Author: sergeibbb

src/commands/quickCommand.ts

@@ -71,6 +71,7 @@ export interface QuickPickStep<T extends QuickPickItem = QuickPickItem> {
 	onDidActivate?(quickpick: QuickPick<DirectiveQuickPickItem | T>): void;
 
 	onDidAccept?(quickpick: QuickPick<DirectiveQuickPickItem | T>): boolean | Promise<boolean>;
+	onDidChangeActive?(quickpick: QuickPick<DirectiveQuickPickItem | T>): boolean | Promise<boolean>;
 	onDidChangeValue?(quickpick: QuickPick<DirectiveQuickPickItem | T>): boolean | Promise<boolean>;
 	onDidChangeSelection?(quickpick: QuickPick<DirectiveQuickPickItem | T>, selection: readonly T[]): void;
 	onDidClickButton?(

src/commands/quickWizard.base.ts

@@ -621,6 +621,11 @@ export abstract class QuickWizardCommandBase extends Command {
 							firstActiveChange = false;
 						}
 
+						if (step.onDidChangeActive != null) {
+							const cancel = step.onDidChangeActive(quickpick);
+							if (cancel) return;
+						}
+
 						if (rootStep.command != null || quickpick.activeItems.length === 0) return;
 
 						const command = quickpick.activeItems[0];

src/plus/launchpad/launchpad.ts

@@ -559,6 +559,17 @@ export class LaunchpadCommand extends QuickCommand<State> {
 				LaunchpadSettingsQuickInputButton,
 				RefreshQuickInputButton,
 			],
+
+			onDidChangeActive: quickpick => {
+				const hasActiveLaunchpadItems = quickpick.activeItems.find(i => 'item' in i);
+				if (hasActiveLaunchpadItems) {
+					this.updateItemsDebouncer.cancel();
+					return true;
+				}
+
+				return false;
+			},
+
 			onDidChangeValue: async quickpick => {
 				const { value } = quickpick;
 				const hideGroups = Boolean(value?.length);
@@ -614,15 +625,15 @@ export class LaunchpadCommand extends QuickCommand<State> {
 					}
 				}
 
-				// wait a little bit because the active quickpick is updated with some delay
-				await new Promise(resolve => setTimeout(resolve, 100));
-				const hasActiveLaunchpadItems = quickpick.activeItems.find(i => 'item' in i);
-				if (hasActiveLaunchpadItems) {
-					// We have an active item, so we can exit now without sending any requests to API
-					this.updateItemsDebouncer.cancel();
-					return true;
-				}
-
+				// Here we cannot check for active items, because they are not yet updated after the last search value.
+				// So, we immediately init updating process, without a condition.
+				// But it's delayed by a debouncer.
+				//
+				// Right after the `onDidChangeValue` it goes to `onDidChangeActive`, where active items are already updated.
+				// It happens very soon much after that the delay of the debouncer.
+				//
+				// If it occurs that the quickpic has an active item, it cancells the update operation,
+				// it happens before the update procedure starts executing.
 				await updateItems(quickpick);
 				return true;
 			},