File tree Expand file tree Collapse file tree 2 files changed +10
-0
lines changed Expand file tree Collapse file tree 2 files changed +10
-0
lines changed Original file line number Diff line number Diff line change @@ -150,6 +150,7 @@ const instanceCounter = getScopedCounter();
150150const defaultCollapsedGroups : LaunchpadGroup [ ] = [ 'draft' , 'other' , 'snoozed' ] ;
151151
152152export class LaunchpadCommand extends QuickCommand < State > {
153+ // TODO: The debouncer needs to be cancelled when the step is changed when the quickpick is closed
153154 private readonly updateItemsDebouncer = createAsyncDebouncer ( 500 ) ;
154155 private readonly source : Source ;
155156 private readonly telemetryContext : LaunchpadTelemetryContext | undefined ;
@@ -586,6 +587,11 @@ export class LaunchpadCommand extends QuickCommand<State> {
586587 return true ;
587588 }
588589
590+ // TODO: This needs to be generalized to work outside of GitHub,
591+ // The current idea is that we should iterate the connected integrations and apply their parsing.
592+ // Probably we even want to build a map like this: { integrationId: identity }
593+ // Then when we iterate local items we can check them to corresponding identitie according to the item's repo type.
594+ // Same with API: we iterate connected integrations and search in each of them with the corresponding identity.
589595 const prUrlIdentity = getPullRequestIdentityValuesFromSearch ( value ) ;
590596 if ( prUrlIdentity . prNumber != null ) {
591597 const launchpadItems = quickpick . items . filter ( ( i ) : i is LaunchpadItemQuickPickItem => 'item' in i ) ;
Original file line number Diff line number Diff line change @@ -321,6 +321,10 @@ export class LaunchpadProvider implements Disposable {
321321 }
322322
323323 private async getSearchedPullRequests ( search : string ) {
324+ // TODO: This needs to be generalized to work outside of GitHub,
325+ // The current idea is that we should iterate the connected integrations and apply their parsing.
326+ // Probably we even want to build a map like this: { integrationId: identity }
327+ // Then we iterate connected integrations and search in each of them with the corresponding identity.
324328 const { ownerAndRepo, prNumber } = getPullRequestIdentityValuesFromSearch ( search ) ;
325329 let result : TimedResult < SearchedPullRequest [ ] | undefined > | undefined ;
326330
You can’t perform that action at this time.
0 commit comments