Improves types in remoteProviders for cloudRemotesMap: makes it stricter

(#4107, #4146)

Author: sergeibbb

src/git/remotes/remoteProviders.ts

@@ -1,4 +1,5 @@
 import type { RemotesConfig } from '../../config';
+import type { CloudSelfHostedIntegrationId } from '../../constants.integrations';
 import { SelfHostedIntegrationId } from '../../constants.integrations';
 import type { Container } from '../../container';
 import type { ConfiguredIntegrationDescriptor } from '../../plus/integrations/authentication/models';
@@ -76,7 +77,10 @@ const builtInProviders: RemoteProviders = [
 	},
 ];
 
-const cloudRemotesMap: { [key: string]: typeof GitHubRemote | typeof GitLabRemote | typeof BitbucketServerRemote } = {
+const cloudRemotesMap: Record<
+	CloudSelfHostedIntegrationId,
+	typeof GitHubRemote | typeof GitLabRemote | typeof BitbucketServerRemote
+> = {
 	[SelfHostedIntegrationId.CloudGitHubEnterprise]: GitHubRemote,
 	[SelfHostedIntegrationId.CloudGitLabSelfHosted]: GitLabRemote,
 	[SelfHostedIntegrationId.BitbucketServer]: BitbucketServerRemote,
@@ -111,10 +115,11 @@ export function loadRemoteProviders(
 
 	if (configuredIntegrations?.length) {
 		for (const ci of configuredIntegrations) {
-			if (isCloudSelfHostedIntegrationId(ci.integrationId) && ci.domain) {
+			const integrationId = ci.integrationId;
+			if (isCloudSelfHostedIntegrationId(integrationId) && ci.domain) {
 				const matcher = ci.domain.toLocaleLowerCase();
 				const providerCreator = (_container: Container, domain: string, path: string): RemoteProvider =>
-					new cloudRemotesMap[ci.integrationId](domain, path);
+					new cloudRemotesMap[integrationId](domain, path);
 				const provider = {
 					custom: false,
 					matcher: matcher,