Moves filter into getRemotes

Author: eamodio

src/commands/openBranchInRemote.ts

@@ -52,7 +52,7 @@ export class OpenBranchInRemoteCommand extends ActiveEditorCommand {
                 if (args.branch === undefined) return undefined;
             }
 
-            const remotes = (await Container.git.getRemotes(repoPath)).filter(r => r.provider !== undefined);
+            const remotes = await Container.git.getRemotes(repoPath);
 
             return commands.executeCommand(Commands.OpenInRemote, uri, {
                 resource: {

src/commands/openBranchesInRemote.ts

@@ -34,7 +34,7 @@ export class OpenBranchesInRemoteCommand extends ActiveEditorCommand {
         if (!repoPath) return undefined;
 
         try {
-            const remotes = (await Container.git.getRemotes(repoPath)).filter(r => r.provider !== undefined);
+            const remotes = await Container.git.getRemotes(repoPath);
 
             return commands.executeCommand(Commands.OpenInRemote, uri, {
                 resource: {

src/commands/openCommitInRemote.ts

@@ -66,7 +66,7 @@ export class OpenCommitInRemoteCommand extends ActiveEditorCommand {
                 args.sha = commit.sha;
             }
 
-            const remotes = (await Container.git.getRemotes(gitUri.repoPath)).filter(r => r.provider !== undefined);
+            const remotes = await Container.git.getRemotes(gitUri.repoPath);
 
             return commands.executeCommand(Commands.OpenInRemote, uri, {
                 resource: {

src/commands/openFileInRemote.ts

@@ -45,7 +45,7 @@ export class OpenFileInRemoteCommand extends ActiveEditorCommand {
         }
 
         try {
-            const remotes = (await Container.git.getRemotes(gitUri.repoPath)).filter(r => r.provider !== undefined);
+            const remotes = await Container.git.getRemotes(gitUri.repoPath);
             const range = (args.range && editor !== undefined)
                 ? new Range(editor.selection.start.with({ line: editor.selection.start.line + 1 }), editor.selection.end.with({ line: editor.selection.end.line + 1 }))
                 : undefined;

src/commands/openRepoInRemote.ts

@@ -34,7 +34,7 @@ export class OpenRepoInRemoteCommand extends ActiveEditorCommand {
         if (!repoPath) return undefined;
 
         try {
-            const remotes = (await Container.git.getRemotes(repoPath)).filter(r => r.provider !== undefined);
+            const remotes = await Container.git.getRemotes(repoPath);
 
             return commands.executeCommand(Commands.OpenInRemote, uri, {
                 resource: {

src/gitService.ts

@@ -1073,15 +1073,19 @@ export class GitService extends Disposable {
         }
     }
 
-    async getRemotes(repoPath: string | undefined): Promise<GitRemote[]> {
+    async getRemotes(repoPath: string | undefined, options: { includeAll?: boolean } = {}): Promise<GitRemote[]> {
         if (repoPath === undefined) return [];
 
         Logger.log(`getRemotes('${repoPath}')`);
 
         const repository = await this.getRepository(repoPath);
-        if (repository !== undefined) return repository.getRemotes();
+        const remotes = repository !== undefined
+            ? repository.getRemotes()
+            : this.getRemotesCore(repoPath);
 
-        return this.getRemotesCore(repoPath);
+        if (options.includeAll) return remotes;
+
+        return (await remotes).filter(r => r.provider !== undefined);
     }
 
     async getRemotesCore(repoPath: string | undefined, providerMap?: RemoteProviderMap): Promise<GitRemote[]> {

src/quickPicks/branchHistoryQuickPick.ts

@@ -36,7 +36,7 @@ export class BranchHistoryQuickPick {
                 } as ShowQuickBranchHistoryCommandArgs
             ]);
 
-        const remotes = (await Container.git.getRemotes((uri && uri.repoPath) || log.repoPath)).filter(r => r.provider !== undefined);
+        const remotes = await Container.git.getRemotes((uri && uri.repoPath) || log.repoPath);
         if (remotes.length) {
             items.splice(0, 0, new OpenRemotesCommandQuickPickItem(remotes, {
                 type: 'branch',

src/quickPicks/commitFileQuickPick.ts

@@ -120,7 +120,7 @@ export class CommitFileQuickPick {
         }
         items.push(new OpenCommitFileRevisionCommandQuickPickItem(commit));
 
-        const remotes = (await Container.git.getRemotes(commit.repoPath)).filter(r => r.provider !== undefined);
+        const remotes = await Container.git.getRemotes(commit.repoPath);
         if (remotes.length) {
             if (commit.workingFileName && commit.status !== 'D') {
                 const branch = await Container.git.getBranch(commit.repoPath);

src/quickPicks/commitQuickPick.ts

@@ -129,7 +129,7 @@ export class CommitQuickPick {
         else {
             items.splice(index++, 0, new ShowCommitInResultsQuickPickItem(commit));
 
-            const remotes = (await Container.git.getRemotes(commit.repoPath)).filter(r => r.provider !== undefined);
+            const remotes = await Container.git.getRemotes(commit.repoPath);
             if (remotes.length) {
                 items.splice(index++, 0, new OpenRemotesCommandQuickPickItem(remotes, {
                     type: 'commit',

src/quickPicks/fileHistoryQuickPick.ts

@@ -110,7 +110,7 @@ export class FileHistoryQuickPick {
                     ]));
             }
 
-            const remotes = (await Container.git.getRemotes(uri.repoPath!)).filter(r => r.provider !== undefined);
+            const remotes = await Container.git.getRemotes(uri.repoPath!);
             if (remotes.length) {
                 const resource = uri.sha !== undefined
                     ? {