Fixes #1932 invalid comparison & only on windows

eamodio · eamodio · commit b0c39edbd45e · 2022-03-31T02:11:49.000-04:00
diff --git a/src/system/path.ts b/src/system/path.ts
@@ -178,7 +178,7 @@ export function normalizePath(path: string): string {
 	path = path.replace(pathNormalizeRegex, '/');
 	if (path.charCodeAt(path.length - 1) === slash) {
 		// Don't remove the trailing slash on Windows root folders, such as z:\
-		if (path.length != 3 || (path.length == 3 && path.charCodeAt(1) != ':')) {
+		if (!isWindows || path.length !== 3 || path[1] !== ':') {
 			path = path.slice(0, -1);
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -178,7 +178,7 @@ export function normalizePath(path: string): string {`
`178`	`178`	`path = path.replace(pathNormalizeRegex, '/');`
`179`	`179`	`if (path.charCodeAt(path.length - 1) === slash) {`
`180`	`180`	`// Don't remove the trailing slash on Windows root folders, such as z:\`
`181`		`- if (path.length != 3 \|\| (path.length == 3 && path.charCodeAt(1) != ':')) {`
	`181`	`+ if (!isWindows \|\| path.length !== 3 \|\| path[1] !== ':') {`
`182`	`182`	`path = path.slice(0, -1);`
`183`	`183`	`}`
`184`	`184`	`}`