Adds & enforces module boundary types

 - For improved type performance

Author: eamodio

eslint.config.mjs

@@ -156,6 +156,10 @@ export default ts.config(
 				},
 			],
 			'@typescript-eslint/consistent-type-imports': ['error', { disallowTypeAnnotations: false }],
+			'@typescript-eslint/explicit-module-boundary-types': [
+				'error',
+				{ allowArgumentsExplicitlyTypedAsAny: true },
+			],
 			'@typescript-eslint/naming-convention': [
 				'error',
 				{
@@ -414,6 +418,7 @@ export default ts.config(
 			},
 		},
 		rules: {
+			'@typescript-eslint/explicit-module-boundary-types': 'off',
 			'@typescript-eslint/no-restricted-imports': [
 				'error',
 				{

src/ai/aiProviderService.ts

@@ -98,11 +98,11 @@ export class AIProviderService implements Disposable {
 
 	constructor(private readonly container: Container) {}
 
-	dispose() {
+	dispose(): void {
 		this._provider?.dispose();
 	}
 
-	get currentProviderId() {
+	get currentProviderId(): AIProviders | undefined {
 		return this._provider?.id;
 	}
 
@@ -486,7 +486,7 @@ export class AIProviderService implements Disposable {
 		}
 	}
 
-	async reset(all?: boolean) {
+	async reset(all?: boolean): Promise<void> {
 		let { _provider: provider } = this;
 		if (provider == null) {
 			// If we have no provider, try to get the current model (which will load the provider)
@@ -540,11 +540,11 @@ export class AIProviderService implements Disposable {
 		}
 	}
 
-	supports(provider: AIProviders | string) {
+	supports(provider: AIProviders | string): boolean {
 		return _supportedProviderTypes.has(provider as AIProviders);
 	}
 
-	async switchModel() {
+	async switchModel(): Promise<void> {
 		void (await this.getModel({ force: true }));
 	}
 }
@@ -702,7 +702,7 @@ function splitMessageIntoSummaryAndBody(message: string): AIResult {
 	};
 }
 
-export function showDiffTruncationWarning(maxCodeCharacters: number, model: AIModel) {
+export function showDiffTruncationWarning(maxCodeCharacters: number, model: AIModel): void {
 	void window.showWarningMessage(
 		`The diff of the changes had to be truncated to ${maxCodeCharacters} characters to fit within the ${getPossessiveForm(
 			model.provider.name,

src/ai/geminiProvider.ts

@@ -1,4 +1,5 @@
 import type { CancellationToken } from 'vscode';
+import type { Response } from '@env/fetch';
 import type { AIModel } from './aiProviderService';
 import { OpenAICompatibleProvider } from './openAICompatibleProvider';
 
@@ -71,7 +72,7 @@ export class GeminiProvider extends OpenAICompatibleProvider<typeof provider.id>
 		apiKey: string,
 		request: object,
 		cancellation: CancellationToken | undefined,
-	) {
+	): Promise<Response> {
 		if ('max_completion_tokens' in request) {
 			const { max_completion_tokens: _, ...rest } = request;
 			request = rest;

src/ai/openAICompatibleProvider.ts

@@ -1,4 +1,5 @@
 import type { CancellationToken } from 'vscode';
+import type { Response } from '@env/fetch';
 import { fetch } from '@env/fetch';
 import type { AIProviders } from '../constants.ai';
 import type { TelemetryEvents } from '../constants.telemetry';
@@ -30,7 +31,7 @@ export interface AIProviderConfig {
 export abstract class OpenAICompatibleProvider<T extends AIProviders> implements AIProvider<T> {
 	constructor(protected readonly container: Container) {}
 
-	dispose() {}
+	dispose(): void {}
 
 	abstract readonly id: T;
 	abstract readonly name: string;
@@ -261,7 +262,7 @@ export abstract class OpenAICompatibleProvider<T extends AIProviders> implements
 		apiKey: string,
 		request: object,
 		cancellation: CancellationToken | undefined,
-	) {
+	): Promise<Response> {
 		let aborter: AbortController | undefined;
 		if (cancellation != null) {
 			aborter = new AbortController();

src/ai/vscodeProvider.ts

@@ -28,13 +28,13 @@ export class VSCodeAIProvider implements AIProvider<typeof provider.id> {
 	readonly id = provider.id;
 
 	private _name: string | undefined;
-	get name() {
+	get name(): string {
 		return this._name ?? provider.name;
 	}
 
 	constructor(private readonly container: Container) {}
 
-	dispose() {}
+	dispose(): void {}
 
 	async getModels(): Promise<readonly AIModel<typeof provider.id>[]> {
 		const models = await lm.selectChatModels();

src/annotations/annotationProvider.ts

@@ -52,7 +52,7 @@ export abstract class AnnotationProviderBase<TContext extends AnnotationContext
 		);
 	}
 
-	dispose() {
+	dispose(): void {
 		void this.clear();
 
 		this.disposable.dispose();
@@ -102,7 +102,7 @@ export abstract class AnnotationProviderBase<TContext extends AnnotationContext
 		return true;
 	}
 
-	async clear() {
+	async clear(): Promise<void> {
 		if (this._computing?.pending) {
 			await this._computing.promise;
 		}
@@ -156,7 +156,7 @@ export abstract class AnnotationProviderBase<TContext extends AnnotationContext
 
 	protected abstract onProvideAnnotation(context?: TContext, state?: AnnotationState): Promise<boolean>;
 
-	refresh(replaceDecorationTypes: Map<TextEditorDecorationType, TextEditorDecorationType | null>) {
+	refresh(replaceDecorationTypes: Map<TextEditorDecorationType, TextEditorDecorationType | null>): void {
 		if (this.editor == null || !this.decorations?.length) return;
 
 		const decorations = [];
@@ -175,7 +175,7 @@ export abstract class AnnotationProviderBase<TContext extends AnnotationContext
 		this.setDecorations(this.decorations);
 	}
 
-	restore(editor: TextEditor, recompute?: boolean) {
+	restore(editor: TextEditor, recompute?: boolean): void {
 		// If the editor isn't disposed then we don't need to do anything
 		// Explicitly check for `false`
 		if ((this.editor as any)._disposed === false) return;
@@ -201,7 +201,7 @@ export abstract class AnnotationProviderBase<TContext extends AnnotationContext
 	selection?(selection?: TContext['selection']): Promise<void>;
 	validate?(): boolean | Promise<boolean>;
 
-	protected setDecorations(decorations: Decoration[]) {
+	protected setDecorations(decorations: Decoration[]): void {
 		if (this.decorations?.length) {
 			// If we have no new decorations, just completely clear the old ones
 			if (!decorations?.length) {

src/annotations/annotations.ts

@@ -64,8 +64,12 @@ const defaultHeatmapColors = [
 	'#0a60f6',
 ];
 
-let heatmapColors: { hot: string[]; cold: string[] } | undefined;
-export function getHeatmapColors() {
+interface HeatmapColors {
+	hot: string[];
+	cold: string[];
+}
+let heatmapColors: HeatmapColors | undefined;
+export function getHeatmapColors(): HeatmapColors {
 	if (heatmapColors == null) {
 		const { coldColor, hotColor } = configuration.get('heatmap');
 
@@ -91,7 +95,7 @@ export function getHeatmapColors() {
 	return heatmapColors;
 }
 
-export function applyHeatmap(decoration: Partial<DecorationOptions>, date: Date, heatmap: ComputedHeatmap) {
+export function applyHeatmap(decoration: Partial<DecorationOptions>, date: Date, heatmap: ComputedHeatmap): void {
 	const [r, g, b, a] = getHeatmapColor(date, heatmap);
 	decoration.renderOptions!.before!.borderColor = `rgba(${r},${g},${b},${a})`;
 }
@@ -101,7 +105,7 @@ export function addOrUpdateGutterHeatmapDecoration(
 	heatmap: ComputedHeatmap,
 	range: Range,
 	map: Map<string, Decoration<Range[]>>,
-) {
+): TextEditorDecorationType {
 	const [r, g, b, a] = getHeatmapColor(date, heatmap);
 
 	const { fadeLines, locations } = configuration.get('heatmap');

src/annotations/blameAnnotationProvider.ts

@@ -36,7 +36,7 @@ export abstract class BlameAnnotationProviderBase extends AnnotationProviderBase
 		}
 	}
 
-	override clear() {
+	override clear(): Promise<void> {
 		if (this.hoverProviderDisposable != null) {
 			this.hoverProviderDisposable.dispose();
 			this.hoverProviderDisposable = undefined;
@@ -140,7 +140,7 @@ export abstract class BlameAnnotationProviderBase extends AnnotationProviderBase
 		};
 	}
 
-	registerHoverProviders(providers: { details: boolean; changes: boolean }) {
+	registerHoverProviders(providers: { details: boolean; changes: boolean }): void {
 		const cfg = configuration.get('hovers');
 		if (!cfg.enabled || !cfg.annotations.enabled || (!providers.details && !providers.changes)) {
 			return;

src/annotations/fileAnnotationController.ts

@@ -81,7 +81,7 @@ export class FileAnnotationController implements Disposable {
 		this._toggleModes = new Map<FileAnnotationType, AnnotationsToggleMode>();
 	}
 
-	dispose() {
+	dispose(): void {
 		void this.clearAll();
 
 		Decorations.gutterBlameAnnotation?.dispose();
@@ -280,15 +280,15 @@ export class FileAnnotationController implements Disposable {
 	}
 
 	@log<FileAnnotationController['clear']>({ args: { 0: e => e?.document.uri.toString(true) } })
-	clear(editor: TextEditor | undefined) {
+	clear(editor: TextEditor | undefined): Promise<void> | undefined {
 		if (this.isInWindowToggle()) return this.clearAll();
 		if (editor == null) return;
 
 		return this.clearCore(getEditorCorrelationKey(editor), true);
 	}
 
 	@log()
-	async clearAll() {
+	async clearAll(): Promise<void> {
 		this._windowAnnotationType = undefined;
 
 		for (const [key] of this._annotationProviders) {
@@ -335,7 +335,10 @@ export class FileAnnotationController implements Disposable {
 	private readonly _annotatedUris = new UriSet();
 	private readonly _computingUris = new UriSet();
 
-	async onProviderEditorStatusChanged(editor: TextEditor | undefined, status: AnnotationStatus | undefined) {
+	async onProviderEditorStatusChanged(
+		editor: TextEditor | undefined,
+		status: AnnotationStatus | undefined,
+	): Promise<void> {
 		if (editor == null) return;
 
 		let changed = false;
@@ -530,13 +533,13 @@ export class FileAnnotationController implements Disposable {
 	}
 
 	@log()
-	nextChange() {
+	nextChange(): void {
 		const provider = this.getProvider(window.activeTextEditor);
 		provider?.nextChange?.();
 	}
 
 	@log()
-	previousChange() {
+	previousChange(): void {
 		const provider = this.getProvider(window.activeTextEditor);
 		provider?.previousChange?.();
 	}

src/annotations/gutterBlameAnnotationProvider.ts

@@ -39,7 +39,7 @@ export class GutterBlameAnnotationProvider extends BlameAnnotationProviderBase {
 		super(container, onDidChangeStatus, 'blame', editor, trackedDocument);
 	}
 
-	override async clear() {
+	override async clear(): Promise<void> {
 		await super.clear();
 
 		if (Decorations.gutterBlameHighlight != null) {