Skip to content

Commit c007b15

Browse files
committed
Updates commit graph status bar
- adds feedback link - updates focus state colors - updates aria-activedescendant when viewing repos
1 parent 5b4181f commit c007b15

File tree

2 files changed

+27
-6
lines changed

2 files changed

+27
-6
lines changed

src/webviews/apps/plus/graph/GraphWrapper.tsx

Lines changed: 17 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -274,7 +274,13 @@ export function GraphWrapper({
274274
id="repo-actioncombo-label"
275275
className="actioncombo__label"
276276
role="combobox"
277-
aria-activedescendant=""
277+
aria-activedescendant={
278+
repoExpanded
279+
? `repo-actioncombo-item-${reposList.findIndex(
280+
item => item.path === currentRepository?.path,
281+
)}`
282+
: undefined
283+
}
278284
onClick={() => handleToggleRepos()}
279285
>
280286
<span className="codicon codicon-repo actioncombo__icon" aria-label="Repository "></span>
@@ -304,14 +310,14 @@ export function GraphWrapper({
304310
</button>
305311
))
306312
) : (
307-
<li
313+
<span
308314
className="actioncombo__item"
309315
role="option"
310316
id="repo-actioncombo-item-0"
311317
aria-selected="true"
312318
>
313319
None available
314-
</li>
320+
</span>
315321
)}
316322
</div>
317323
</div>
@@ -320,11 +326,16 @@ export function GraphWrapper({
320326
{graphList.length} commit{graphList.length ? 's' : ''}
321327
</span>
322328
)}
323-
{isLoading && (
324-
<span className={'icon--loading'}/>
325-
)}
329+
{isLoading && <span className="icon--loading" />}
326330
</div>
327331
<div className="actionbar__group">
332+
<a
333+
href="https://github.com/gitkraken/vscode-gitlens/discussions/2158"
334+
title="Commit Graph Feedback"
335+
aria-label="Commit Graph Feedback"
336+
>
337+
<span className="codicon codicon-feedback"></span>
338+
</a>{' '}
328339
<span className="badge">Preview</span>
329340
</div>
330341
</footer>

src/webviews/apps/plus/graph/graph.scss

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,15 @@ a {
4646
margin: 0;
4747
}
4848
}
49+
50+
a {
51+
color: inherit;
52+
}
53+
54+
:focus {
55+
outline: 1px solid var(--vscode-focusBorder);
56+
outline-offset: -1x;
57+
}
4958
}
5059

5160
.actioncombo {
@@ -105,6 +114,7 @@ a {
105114
min-width: 100%;
106115
width: max-content;
107116
z-index: 100;
117+
background-color: var(--actionbar-background-color);
108118
}
109119

110120
&__label:not([aria-expanded='true']) + &__list {

0 commit comments

Comments
 (0)