Improves when clause to hide feedback buttons when telemetry is disabled

sergeibbb · eamodio · commit c46258926171 · 2025-07-07T19:42:34.000-04:00
(#4449, #4475)
diff --git a/contributions.json b/contributions.json
@@ -149,7 +149,7 @@
 			"menus": {
 				"editor/title": [
 					{
-						"when": "resourceScheme == gitlens-markdown && config.gitlens.telemetry.enabled && activeCustomEditorId == vscode.markdown.preview.editor",
+						"when": "resourceScheme == gitlens-markdown && config.gitlens.telemetry.enabled && config.telemetry.telemetryLevel != off && activeCustomEditorId == vscode.markdown.preview.editor",
 						"group": "navigation",
 						"order": 2
 					}
@@ -162,7 +162,7 @@
 			"menus": {
 				"editor/title": [
 					{
-						"when": "resourceScheme == gitlens-markdown && config.gitlens.telemetry.enabled && activeCustomEditorId == vscode.markdown.preview.editor",
+						"when": "resourceScheme == gitlens-markdown && config.gitlens.telemetry.enabled && config.telemetry.telemetryLevel != off && activeCustomEditorId == vscode.markdown.preview.editor",
 						"group": "navigation",
 						"order": 1
 					}
diff --git a/package.json b/package.json
@@ -14138,12 +14138,12 @@
 				},
 				{
 					"command": "gitlens.ai.feedback.positive",
-					"when": "resourceScheme == gitlens-markdown && config.gitlens.telemetry.enabled && activeCustomEditorId == vscode.markdown.preview.editor",
+					"when": "resourceScheme == gitlens-markdown && config.gitlens.telemetry.enabled && config.telemetry.telemetryLevel != off && activeCustomEditorId == vscode.markdown.preview.editor",
 					"group": "navigation@1"
 				},
 				{
 					"command": "gitlens.ai.feedback.negative",
-					"when": "resourceScheme == gitlens-markdown && config.gitlens.telemetry.enabled && activeCustomEditorId == vscode.markdown.preview.editor",
+					"when": "resourceScheme == gitlens-markdown && config.gitlens.telemetry.enabled && config.telemetry.telemetryLevel != off && activeCustomEditorId == vscode.markdown.preview.editor",
 					"group": "navigation@2"
 				},
 				{

Original file line number	Diff line number	Diff line change
`@@ -149,7 +149,7 @@`
`149`	`149`	`"menus": {`
`150`	`150`	`"editor/title": [`
`151`	`151`	`{`
`152`		`- "when": "resourceScheme == gitlens-markdown && config.gitlens.telemetry.enabled && activeCustomEditorId == vscode.markdown.preview.editor",`
	`152`	`+ "when": "resourceScheme == gitlens-markdown && config.gitlens.telemetry.enabled && config.telemetry.telemetryLevel != off && activeCustomEditorId == vscode.markdown.preview.editor",`
`153`	`153`	`"group": "navigation",`
`154`	`154`	`"order": 2`
`155`	`155`	`}`
`@@ -162,7 +162,7 @@`
`162`	`162`	`"menus": {`
`163`	`163`	`"editor/title": [`
`164`	`164`	`{`
`165`		`- "when": "resourceScheme == gitlens-markdown && config.gitlens.telemetry.enabled && activeCustomEditorId == vscode.markdown.preview.editor",`
	`165`	`+ "when": "resourceScheme == gitlens-markdown && config.gitlens.telemetry.enabled && config.telemetry.telemetryLevel != off && activeCustomEditorId == vscode.markdown.preview.editor",`
`166`	`166`	`"group": "navigation",`
`167`	`167`	`"order": 1`
`168`	`168`	`}`
Original file line number	Diff line number	Diff line change
`@@ -14138,12 +14138,12 @@`
`14138`	`14138`	`},`
`14139`	`14139`	`{`
`14140`	`14140`	`"command": "gitlens.ai.feedback.positive",`
`14141`		`- "when": "resourceScheme == gitlens-markdown && config.gitlens.telemetry.enabled && activeCustomEditorId == vscode.markdown.preview.editor",`
	`14141`	`+ "when": "resourceScheme == gitlens-markdown && config.gitlens.telemetry.enabled && config.telemetry.telemetryLevel != off && activeCustomEditorId == vscode.markdown.preview.editor",`
`14142`	`14142`	`"group": "navigation@1"`
`14143`	`14143`	`},`
`14144`	`14144`	`{`
`14145`	`14145`	`"command": "gitlens.ai.feedback.negative",`
`14146`		`- "when": "resourceScheme == gitlens-markdown && config.gitlens.telemetry.enabled && activeCustomEditorId == vscode.markdown.preview.editor",`
	`14146`	`+ "when": "resourceScheme == gitlens-markdown && config.gitlens.telemetry.enabled && config.telemetry.telemetryLevel != off && activeCustomEditorId == vscode.markdown.preview.editor",`
`14147`	`14147`	`"group": "navigation@2"`
`14148`	`14148`	`},`
`14149`	`14149`	`{`