Skip to content

Commit ca71d5d

Browse files
committed
Fixes issue where section fn was reused (won't work)
1 parent c7e0c6a commit ca71d5d

File tree

2 files changed

+11
-9
lines changed

2 files changed

+11
-9
lines changed

src/views/gitExplorer.ts

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -70,18 +70,19 @@ export class GitExplorer implements TreeDataProvider<ExplorerNode> {
7070
private async onConfigurationChanged(e: ConfigurationChangeEvent) {
7171
const initializing = configuration.initializing(e);
7272

73-
const section = configuration.name('gitExplorer');
74-
if (!initializing && !configuration.changed(e, section.value)) return;
73+
if (!initializing && !configuration.changed(e, configuration.name('gitExplorer').value)) return;
7574

76-
if (!initializing && (configuration.changed(e, section('gravatars').value) || configuration.changed(e, section('gravatarsDefault').value))) {
75+
if (!initializing &&
76+
(configuration.changed(e, configuration.name('gitExplorer')('gravatars').value) ||
77+
configuration.changed(e, configuration.name('gitExplorer')('gravatarsDefault').value))) {
7778
clearGravatarCache();
7879
}
7980

80-
if (initializing || configuration.changed(e, section('autoRefresh').value)) {
81-
this.setAutoRefresh(configuration.get<boolean>(section('autoRefresh').value));
81+
if (initializing || configuration.changed(e, configuration.name('gitExplorer')('autoRefresh').value)) {
82+
this.setAutoRefresh(configuration.get<boolean>(configuration.name('gitExplorer')('autoRefresh').value));
8283
}
8384

84-
let view = configuration.get<GitExplorerView>(section('view').value);
85+
let view = configuration.get<GitExplorerView>(configuration.name('gitExplorer')('view').value);
8586
if (view === GitExplorerView.Auto) {
8687
view = Container.context.workspaceState.get<GitExplorerView>(WorkspaceState.GitExplorerView, GitExplorerView.Repository);
8788
}

src/views/resultsExplorer.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,10 +44,11 @@ export class ResultsExplorer implements TreeDataProvider<ExplorerNode> {
4444
private async onConfigurationChanged(e: ConfigurationChangeEvent) {
4545
const initializing = configuration.initializing(e);
4646

47-
const section = configuration.name('resultsExplorer');
48-
if (!initializing && !configuration.changed(e, section.value)) return;
47+
if (!initializing && !configuration.changed(e, configuration.name('resultsExplorer').value)) return;
4948

50-
if (!initializing && (configuration.changed(e, section('gravatars').value) || configuration.changed(e, section('gravatarsDefault').value))) {
49+
if (!initializing &&
50+
(configuration.changed(e, configuration.name('resultsExplorer')('gravatars').value) ||
51+
configuration.changed(e, configuration.name('resultsExplorer')('gravatarsDefault').value))) {
5152
clearGravatarCache();
5253
}
5354

0 commit comments

Comments
 (0)