Skip to content

Commit cbf83ce

Browse files
committed
Fixes inspect autolinks rendering when setting is false
1 parent d221575 commit cbf83ce

File tree

4 files changed

+12
-3
lines changed

4 files changed

+12
-3
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,10 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/) and this p
66

77
## [Unreleased]
88

9+
### Fixed
10+
11+
- Fixes [#3841](https://github.com/gitkraken/vscode-gitlens/issues/3841) - Inspect & Graph Details: autolinks rendering when enabled setting is false
12+
913
## [16.3.0] - 2025-02-11
1014

1115
### Added

src/webviews/apps/commitDetails/components/gl-commit-details.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -203,7 +203,7 @@ export class GlCommitDetails extends GlDetailsBase {
203203
}
204204

205205
private renderAutoLinks() {
206-
if (this.isUncommitted) return undefined;
206+
if (!this.state?.autolinksEnabled || this.isUncommitted) return undefined;
207207

208208
const deduped = new Map<
209209
string,

src/webviews/commitDetails/commitDetailsWebview.ts

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -155,6 +155,7 @@ interface Context {
155155
preferences: Preferences;
156156

157157
commit: GitCommit | undefined;
158+
autolinksEnabled: boolean;
158159
richStateLoaded: boolean;
159160
formattedMessage: string | undefined;
160161
autolinkedIssues: IssueOrPullRequest[] | undefined;
@@ -196,6 +197,7 @@ export class CommitDetailsWebviewProvider
196197
preferences: this.getPreferences(),
197198

198199
commit: undefined,
200+
autolinksEnabled: false,
199201
richStateLoaded: false,
200202
formattedMessage: undefined,
201203
autolinkedIssues: undefined,
@@ -1241,6 +1243,7 @@ export class CommitDetailsWebviewProvider
12411243
pinned: current.pinned,
12421244
preferences: current.preferences,
12431245
includeRichContent: current.richStateLoaded,
1246+
autolinksEnabled: current.autolinksEnabled,
12441247
autolinkedIssues: current.autolinkedIssues?.map(serializeIssueOrPullRequest),
12451248
pullRequest: current.pullRequest != null ? serializePullRequest(current.pullRequest) : undefined,
12461249
wip: serializeWipContext(wip),
@@ -1422,10 +1425,10 @@ export class CommitDetailsWebviewProvider
14221425

14231426
if (cancellation.isCancellationRequested) return;
14241427

1428+
const autolinksEnabled = configuration.get('views.commitDetails.autolinks.enabled');
14251429
const [enrichedAutolinksResult, prResult] =
1426-
remote?.provider != null
1430+
remote?.provider != null && autolinksEnabled
14271431
? await Promise.allSettled([
1428-
configuration.get('views.commitDetails.autolinks.enabled') &&
14291432
configuration.get('views.commitDetails.autolinks.enhanced')
14301433
? pauseOnCancelOrTimeoutMapTuplePromise(commit.getEnrichedAutolinks(remote))
14311434
: undefined,
@@ -1443,6 +1446,7 @@ export class CommitDetailsWebviewProvider
14431446
const formattedMessage = this.getFormattedMessage(commit, remote, enrichedAutolinks);
14441447

14451448
this.updatePendingContext({
1449+
autolinksEnabled: autolinksEnabled,
14461450
richStateLoaded: true,
14471451
formattedMessage: formattedMessage,
14481452
autolinkedIssues:

src/webviews/commitDetails/protocol.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -102,6 +102,7 @@ export interface State extends WebviewState {
102102
includeRichContent?: boolean;
103103

104104
commit?: CommitDetails;
105+
autolinksEnabled: boolean;
105106
autolinkedIssues?: IssueOrPullRequest[];
106107
pullRequest?: PullRequestShape;
107108
wip?: Wip;

0 commit comments

Comments
 (0)