Fixes logging names missing w/ minification

Author: eamodio

src/git/models/repository.ts

@@ -151,7 +151,7 @@ export interface RepositoryFileSystemChangeEvent {
 
 const instanceCounter = getScopedCounter();
 
-@logName<Repository>((r, name) => `${name}(${r.id}|${r.instance})`)
+@logName<Repository>(r => `Repository(${r.id}|${r.instance})`)
 export class Repository implements Disposable {
 	private _onDidChange = new EventEmitter<RepositoryChangeEvent>();
 	get onDidChange(): Event<RepositoryChangeEvent> {

src/system/decorators/log.ts

@@ -1,7 +1,7 @@
 /* eslint-disable @typescript-eslint/no-unsafe-return */
 import { hrtime } from '@env/hrtime';
 import { getParameters } from '../function';
-import { getLoggableName, Logger } from '../logger';
+import { customLoggableNameFns, getLoggableName, Logger } from '../logger';
 import { slowCallWarningThreshold } from '../logger.constants';
 import type { LogScope } from '../logger.scope';
 import { clearLogScope, getLoggableScopeBlock, logScopeIdGenerator, setLogScope } from '../logger.scope';
@@ -37,13 +37,8 @@ interface LogOptions<T extends (...arg: any) => any> {
 	timed?: boolean;
 }
 
-export const LogInstanceNameFn = Symbol('logInstanceNameFn');
-
 export function logName<T>(fn: (c: T, name: string) => string) {
-	// eslint-disable-next-line @typescript-eslint/no-unsafe-function-type
-	return (target: Function): void => {
-		(target as any)[LogInstanceNameFn] = fn;
-	};
+	return (target: any): void => void customLoggableNameFns.set(target, fn);
 }
 
 export function debug<T extends (...arg: any) => any>(

src/system/logger.ts

@@ -1,4 +1,3 @@
-import { LogInstanceNameFn } from './decorators/log';
 import type { LogLevel } from './logger.constants';
 import type { LogScope } from './logger.scope';
 import { padOrTruncateEnd } from './string';
@@ -317,28 +316,26 @@ function toOrderedLevel(logLevel: LogLevel): OrderedLevel {
 	}
 }
 
-// eslint-disable-next-line @typescript-eslint/no-unsafe-function-type
-export function getLoggableName(instance: Function | object): string {
+export const customLoggableNameFns = new WeakMap<object, (instance: any, name: string) => string>();
+
+export function getLoggableName(instance: object): string {
 	let ctor;
 	if (typeof instance === 'function') {
-		if (instance.prototype?.constructor == null) return instance.name;
-
-		ctor = instance.prototype.constructor;
+		ctor = instance.prototype?.constructor;
+		if (ctor == null) return instance.name;
 	} else {
 		ctor = instance.constructor;
 	}
 
 	let name: string = ctor?.name ?? '';
-
 	// Strip webpack module name (since I never name classes with an _)
 	const index = name.indexOf('_');
-	name = index === -1 ? name : name.substring(index + 1);
-
-	if (ctor?.[LogInstanceNameFn] != null) {
-		name = ctor[LogInstanceNameFn](instance, name);
+	if (index !== -1) {
+		name = name.substring(index + 1);
 	}
 
-	return name;
+	const customNameFn = customLoggableNameFns.get(ctor);
+	return customNameFn?.(instance, name) ?? name;
 }
 
 export interface LogProvider {

src/trackers/trackedDocument.ts

@@ -96,7 +96,7 @@ export interface TrackedGitDocumentStatus {
 	dirtyIdle?: boolean;
 }
 
-@logName<TrackedGitDocument>((c, name) => `${name}(${Logger.toLoggable(c.document)})`)
+@logName<TrackedGitDocument>(c => `TrackedGitDocument(${Logger.toLoggable(c.document)})`)
 export class TrackedGitDocument implements Disposable {
 	static async create(
 		container: Container,

src/webviews/apps/shared/ipc.ts

@@ -31,7 +31,7 @@ function nextIpcId() {
 
 type PendingHandler = (msg: IpcMessage) => void;
 
-@logName<HostIpc>((c, name) => `${c.appName}(${name})`)
+@logName<HostIpc>(c => `${c.appName}(HostIpc)`)
 export class HostIpc implements Disposable {
 	private _onReceiveMessage = new Emitter<IpcMessage>();
 	get onReceiveMessage(): Event<IpcMessage> {