Fixes #3592 can't connect to remote integration

 - Avoids affecting consumers by cloning the response

Author: eamodio

CHANGELOG.md

@@ -8,6 +8,12 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/) and this p
 
 ### Fixed
 
+- Fixes [#3592](https://github.com/gitkraken/vscode-gitlens/issues/3592) - Connecting to an integration via Remotes view (but likely others) doesn't work
+
+## [15.5.1] - 2024-09-16
+
+### Fixed
+
 - Fixes [#3582](https://github.com/gitkraken/vscode-gitlens/issues/3582) - "Delete Branch" option is sometimes unexpectedly missing
 
 ## [15.5.0] - 2024-09-12
@@ -5614,7 +5620,8 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/) and this p
 
 - Initial release but still heavily a work in progress.
 
-[unreleased]: https://github.com/gitkraken/vscode-gitlens/compare/v15.5.0...HEAD
+[unreleased]: https://github.com/gitkraken/vscode-gitlens/compare/v15.5.1...HEAD
+[15.5.1]: https://github.com/gitkraken/vscode-gitlens/compare/v15.5.0...gitkraken:v15.5.1
 [15.5.0]: https://github.com/gitkraken/vscode-gitlens/compare/v15.4.0...gitkraken:v15.5.0
 [15.4.0]: https://github.com/gitkraken/vscode-gitlens/compare/v15.3.1...gitkraken:v15.4.0
 [15.3.1]: https://github.com/gitkraken/vscode-gitlens/compare/v15.3.0...gitkraken:v15.3.1

src/plus/gk/serverConnection.ts

@@ -226,57 +226,57 @@ export class ServerConnection implements Disposable {
 	}
 
 	private async handleGkUnsuccessfulResponse(rsp: Response, scope: LogScope | undefined): Promise<void> {
-		// Too Many Requests
-		if (rsp.status == 429) {
-			this.trackRequestException();
-			return;
-		}
-
-		// Forbidden
-		if (rsp.status == 403) {
-			if (rsp.statusText.includes('rate limit')) {
+		let content;
+		switch (rsp.status) {
+			// Forbidden
+			case 403:
+				if (rsp.statusText.includes('rate limit')) {
+					this.trackRequestException();
+				}
+				return;
+			// Too Many Requests
+			case 429:
 				this.trackRequestException();
-			}
-			return;
-		}
-
-		// Internal Server Error
-		if (rsp.status == 500) {
-			this.trackRequestException();
-			void showGkRequestFailed500WarningMessage(
-				'GitKraken failed to respond and might be experiencing issues. Please visit the [GitKraken status page](https://cloud.gitkrakenstatus.com) for more information.',
-			);
-			return;
-		}
+				return;
+			// Internal Server Error
+			case 500:
+				this.trackRequestException();
+				void showGkRequestFailed500WarningMessage(
+					'GitKraken failed to respond and might be experiencing issues. Please visit the [GitKraken status page](https://cloud.gitkrakenstatus.com) for more information.',
+				);
+				return;
+			// Bad Gateway
+			case 502: {
+				// Be sure to clone the response so we don't impact any upstream consumers
+				content = await rsp.clone().text();
 
-		const content = await rsp.text();
+				Logger.error(undefined, scope, `GitKraken request failed: ${content} (${rsp.statusText})`);
+				if (content.includes('timeout')) {
+					this.trackRequestException();
+					void showGkRequestTimedOutWarningMessage();
+				}
+				return;
+			}
+			// Service Unavailable
+			case 503: {
+				// Be sure to clone the response so we don't impact any upstream consumers
+				content = await rsp.clone().text();
 
-		// Bad Gateway
-		if (rsp.status == 502) {
-			Logger.error(`GitKraken request failed: ${content} (${rsp.statusText})`, scope);
-			if (content.includes('timeout')) {
+				Logger.error(undefined, scope, `GitKraken request failed: ${content} (${rsp.statusText})`);
 				this.trackRequestException();
-				void showGkRequestTimedOutWarningMessage();
+				void showGkRequestFailed500WarningMessage(
+					'GitKraken failed to respond and might be experiencing issues. Please visit the [GitKraken status page](https://cloud.gitkrakenstatus.com) for more information.',
+				);
+				return;
 			}
-			return;
 		}
 
-		// Service Unavailable
-		if (rsp.status == 503) {
-			Logger.error(`GitKraken request failed: ${content} (${rsp.statusText})`, scope);
-			this.trackRequestException();
-			void showGkRequestFailed500WarningMessage(
-				'GitKraken failed to respond and might be experiencing issues. Please visit the [GitKraken status page](https://cloud.gitkrakenstatus.com) for more information.',
-			);
-			return;
-		}
-
-		if (rsp.status >= 400 && rsp.status < 500) {
-			return;
-		}
+		if (rsp.status >= 400 && rsp.status < 500) return;
 
 		if (Logger.isDebugging) {
-			void window.showErrorMessage(`GitKraken request failed: ${content} (${rsp.statusText})`);
+			// Be sure to clone the response so we don't impact any upstream consumers
+			content ??= await rsp.clone().text();
+			void window.showErrorMessage(`DEBUGGING: GitKraken request failed: ${content} (${rsp.statusText})`);
 		}
 	}
 
@@ -336,7 +336,7 @@ export class ServerConnection implements Disposable {
 
 		if (Logger.isDebugging) {
 			void window.showErrorMessage(
-				`GitKraken request failed: ${(ex.response as any)?.errors?.[0]?.message ?? ex.message}`,
+				`DEBUGGING: GitKraken request failed: ${(ex.response as any)?.errors?.[0]?.message ?? ex.message}`,
 			);
 		}
 	}